Commit graph

10 commits

Author SHA1 Message Date
Maurizio M. Gavioli
93e31dc04c Fix #18869 : restore original clef on ChangeStaffType undo
When a staff type change is undone, the previous staff clef is not restored, if it has been changed to suit the new staff type.

Fixed by storing the original initial clef and restoring it on undo. Should fix the following issues: #18869, #23374, #24294 and, possibly others too.

- Added to ChangeStaffType class an initialClef member variable to hold the original staff initial clef type list.
- ChangeStaffType::flip() split into undo() and redo(), as the managing the clef and setting the staff type must be applied in reversed order in the two cases.
- Clef::layout() now hides a clef not compatible with the staff group, if the clef is not generated or changes it to the same clef as the staff initial clef if generated
- TAB ad-hoc code in Clef::layout() to check for compatibility between the clef type and the staff group generalized to all groups removed.
- Fixed GuitarPro test reference scores, which all contained wrong clefs for the TAB staves.

Tested with a few 2.0 and 1.3 scores; more tests are probably necessary.
2014-05-27 01:47:30 +02:00
Maurizio M. Gavioli
334bb09d73 Fix GuitarPro tests (actually revert them to pre-StaffType-refactoring)
Note: since the recent re-factoring of StaffType, all the GuitarPro tests were loading the wrong tablature template (as the == test in Staff::setStaffStyle() was wrong) and have been too quickly updated to accept this.

This reverts the tests to the status before the StaffType re-factoring.
2014-05-16 23:33:15 +02:00
Joachim Schmitz
85b2d3f86d fixing the regression test files in mtest 2014-05-12 18:54:52 +02:00
ws
37ce2e7d39 update mtest for guitarpro 2014-05-03 11:37:12 +02:00
ws
ba8443453d update mtest 2014-04-30 13:39:16 +02:00
Marc Sabatella
e470312caa enable style tag optimization 2014-04-23 15:37:12 -06:00
Maurizio M. Gavioli
490a61dcbe Fixed GuitarPro tests. 2014-04-16 18:54:02 +02:00
ws
3ed9ea3a63 update mtest 2014-03-21 10:25:10 +01:00
Igevorse
0654f65912 fix #23177: Importing ghost notes & test update 2014-03-15 18:37:10 +05:00
John Pirie
d7ecbb10a2 Added support for heavily accented notes in the GP5 format. 2014-03-12 17:36:12 +00:00