Commit graph

127 commits

Author SHA1 Message Date
anatoly-os
96c03195e3
Merge pull request #5745 from dmitrio95/layout-opt
Layout optimizations
2020-04-09 17:39:23 +03:00
Igor Korsukov
11f7060e2d fixed issues from PVS-Studio report (step2) 2020-03-20 16:52:52 +02:00
Dmitri Ovodok
dc4c3040a0 Optimize segment tick calculation when searching for staff type 2020-02-21 22:27:43 +02:00
Dmitri Ovodok
8ac7d265dc fix #299522: fix undoability of edit mode changes for Tuplet, ChordLine, Image 2020-01-10 14:55:21 +02:00
Dmitri Ovodok
5c3b407dae Move setting up grips out of Element::startEdit() 2019-12-24 14:16:06 +02:00
Peter Hieu Vu
f3e2d4c76d fix #293429: tuplet property saving 2019-09-22 23:55:08 -07:00
James Thistlewood
4e91c67f15 fix #289374: tuplet numbers: 'follow staff size' not working 2019-09-03 09:04:06 +01:00
Joachim Schmitz
a53bac4711 replace slashStyle with stemless
and all related things along with it, including a compatibility layer
2019-08-19 15:07:30 +02:00
Marc Sabatella
d1b2714fac fix #291491: tuplet autoplace issues 2019-07-01 16:41:34 -06:00
Dmitri Ovodok
2f2a4631d3 Enable autoplacement for non-cross-staff tuplets, place them above articulations 2019-06-10 16:43:59 +02:00
Marc Sabatella
d788c38b92 fix #282021: scale beam thickness 2019-04-11 06:36:32 -06:00
Marc Sabatella
2d600594e2 fix #285802: cross-staff tuplets 2019-03-25 14:31:32 -06:00
Dmitri Ovodok
1f8176aebe fix beams and tuplets memory leaks 2019-03-20 10:23:29 +02:00
ws
ec3be9a99a Replacd integer midi tick values by fractions.
- tick names a position on the time axis
- tick is always a Fraction()
- only Measure() and Segment() (and Tuplet?) have a tick value
- tick() for an generic element return only a sensible value if isMeasure() or isSegment() or isSegment(parent())

- "ticks" names a duration stored in a Fraction()
- the tick value for an Segment is relative to its measure

- rename "duration" to "ticks"
- rename afrac() to tick()
- rename rfrac() to rtick()
- rename some variables, changing "fraction" into "tick"
  (example: actualFraction() into actualTicks())

- Lyrics ticks are written as Fraction, on read if xmlreader sees a "/" it reads a fraction
  else midi ticks for backwards compatibility
2019-02-18 11:46:05 +01:00
AntonioBL
a8a519a3f5 fix #280547 tuplet brackets connected to two staves 2018-12-28 15:47:11 +01:00
ws
d5298f5d68 fix #279464 Error opening file created in 2.3.2
Tuplets can be layouted only if beams on the tuplet chord/rests are layouted.
Cross beams complicate this a lot as a cross beam can only be layouted after staff
distances are fixed.
2018-12-09 11:05:17 +01:00
anatoly-os
03fffbc3f6
Merge pull request #4246 from mattmcclinch/278943-paste-tuplet
fix #278943: Can't copy tuplet to last beat of measure
2018-12-05 17:22:27 +02:00
Matt McClinch
7ff253cae0 fix #278943: Can't copy tuplet to last beat of measure 2018-12-02 22:38:09 -05:00
Matt McClinch
b3cca7c0bf fix #279099: Dotted tuplet has incorrect duration after save/reload 2018-11-30 23:24:01 -05:00
ws
ffdab67a9d fix handling of custom formatted text and values in inspector:
- replace properties "BOLD ITALIC UNDERLINE" by one property FONT_STYLE
- if text is custom fomatted (has size/fontface changes, contains parts in bold/italic etc.
  then the appropriate property values are set to "unstyled". This enables the reset button
  in the inspector.
- pressing reset for some text properties strips changes of this property in the text
  Example: text contains a part in italic: pressing reset removes the italic formatting
- the "remove custom formatting" button is only enabled if there is some custom formatting
2018-11-26 21:17:19 +01:00
anatoly-os
bf508b9ad8
Merge pull request #3562 from mattmcclinch/add-missing-elements
fix #270496: Add missing elements to incomplete tuplets when reading …
2018-11-14 14:41:36 +02:00
Dmitri Ovodok
c95dfd5a40 Make it possible to record elements written to MSCX 2018-10-29 16:30:19 +02:00
Joachim Schmitz
474e8152cd fix #275218: fix MSVC C4456 warnings
reg. a declaration shadowing a previously declared local
variable,
"Warning C4456: declaration of 'XXX' hides previous local
declaration"
2018-09-27 17:38:19 +02:00
ws
d02575c521 fix vtest tuplets-2 2018-09-18 11:34:11 +02:00
ws
ab2d9696d1 fix wrong tuplet layout after switching from linear to page mode 2018-09-17 14:06:13 +02:00
ws
c1419f4e13 fix #275382 another attempt to fix tuplet number layout 2018-09-14 11:15:33 +02:00
Joachim Schmitz
b27817fe19 fix more MSVC warnings
* The one C4100
* The one C4189
* The two C4457
* The two C4701
* The 475 C4267, changing to size_t were easily possible, casting to
int elsewhere
* Fix GCC warnings reg. wrong printf format for a size_t, reg. unused
variables and reg. ambigous else branch, seen on Travis CI
2018-09-11 16:56:50 +02:00
alexandr
1d48226720 fix #275382: Tuplet numbers are incorrectly positioned
Add new position of tuplet number.

Set default font of the number in tuplet to italic

add different tuplets to vtests
2018-08-30 17:33:25 +02:00
Dmitri Ovodok
72be412663 Read/write tuplets without using IDs 2018-08-16 19:10:28 +03:00
Dmitri Ovodok
55bef706b8 Add API for retrieving positions of elements in terms of fractions
Rename fpos -> rfrac
Merge Element::ftick with Element::afrac
2018-08-16 19:08:45 +03:00
ws
4247e09755 fix #275102 Default A note is A3, but was A4 in 2.3.2 2018-08-09 15:36:37 +02:00
ws
10ebbb9080 update text style implementation 2018-08-01 11:46:35 +02:00
ws
d5b6ca6780 fix collision detection for tuplets 2018-07-23 11:18:02 +02:00
ws
0828f49810 add style value for tuplet bracket hook height 2018-07-20 11:11:59 +02:00
ws
a204e6b3fd fix tuplet number layout 2018-07-20 10:03:30 +02:00
ws
175d5aadb3 cleanup ElementFlags interface, use more Placement properties on mxml import/export 2018-07-04 12:41:14 +02:00
ws
ec3f2ca3c5 2.x import: fix tuplet number alignment 2018-06-27 10:38:00 +02:00
ws
9a9256c94f fix #272521 Crash whe saving slanted tuplets 2018-06-11 17:30:29 +02:00
Matt McClinch
e92ac205ab fix #272209: Tuplet bracket is way too thick 2018-05-09 12:11:33 -04:00
ws
af29311ec4 remove Element->_readPos 2018-04-30 16:08:25 +02:00
ws
6d460f012b regression fixes for tuplet layout 2018-04-09 11:51:45 +02:00
ws
f9effbaf23 fix visual test regressions 2018-03-28 17:49:08 +02:00
ws
33d1cd7fb4 rename StyleIdx -> Sid and P_ID -> Pid 2018-03-27 15:36:00 +02:00
ws
2580eb7a69 update for properties/styles 2018-03-27 14:40:45 +02:00
Matt McClinch
6e87c9d2a2 check for missing elements before sanitizing a tuplet 2018-03-23 12:27:37 -04:00
Matt McClinch
5b4e908237 compare duration() of tuplet with calculated duration to see if it needs to be sanitized 2018-03-23 12:27:37 -04:00
Matt McClinch
397b5989b9 fix #270496: Add missing elements to incomplete tuplets when reading from a file 2018-03-22 14:24:45 -04:00
ws
6969419cfc update subStyle implementation 2018-03-21 14:05:43 +01:00
lasconic
39a8b26718 fix #270476: Tuplets numbers, when creating parts, obey first to the scaling in main score instead of the default parts scaling 2018-03-19 22:12:38 +01:00
ws
974a388041 add LINE_WIDTH property to tuplet 2018-03-16 12:08:57 +01:00