Commit graph

5610 commits

Author SHA1 Message Date
Nicolas Froment
c231be2251 Merge pull request #3031 from lasconic/MarkusLutz63-176511-tablature-fingering
fix #176511: Allow fingerings in tablature staves
2017-03-01 09:30:06 +01:00
Nicolas Froment
b60cdb56a8 Merge pull request #3032 from ericfont/InputMethodPosition
#43681 InputMethod position when editing Chinese/Jap text
2017-03-01 08:21:40 +01:00
Eric Fontaine
faf7693b95 43681 InputMethod position when editing Chinese/Jap text
If editing Chinese or Japanese text, musescore previously did not tell the operating system where to position its InputMethod popup window, and would default in middle of the bottom edge of the scoreview (as is apparently the default for a QWidget).

This code implements inputMethodQuery, which is inheirited from QWidget, and returns a QRectF when receiving an ImCursorRectangle query if the scoreview is currently editing a text object.  Will position the InputMethod just below the cursor, if it exists, or if not just below the text object's bounding rect.
2017-02-28 20:08:11 -05:00
lasconic
762c1fe9aa fix #151711: Remove a time signature in a part causes corruption in the other parts and main score 2017-02-28 23:36:02 +01:00
lasconic
24d192df37 fix #178176: Hang/crash by extending a glissando on a note with another one in the second staff 2017-02-28 16:48:45 +01:00
Marku Lutz
a13b5a9cb0 fix #176511: Allow fingerings in tablature staves 2017-02-28 12:20:14 +01:00
lasconic
c0f92cc9f9 fix #112656: Crash when opening score with a duplicate Glissando 2017-02-28 11:21:57 +01:00
lasconic
576c6c45af fix #178271: Select->more... selects tuplets in all voices 2017-02-28 10:45:26 +01:00
Werner Schweer
33bf0a3a40 add text properties to instrument name in inspector 2017-02-28 08:39:25 +01:00
Werner Schweer
8dab53007b add text styles for header/footer in style editor 2017-02-27 15:39:19 +01:00
Nicolas Froment
9358fcafd0 Merge pull request #3027 from ericfont/176601-extra-mtest
mtest for dropping unicode after Symbol when cursor currently already set to SYMBOL
2017-02-27 14:54:39 +01:00
Werner Schweer
f6225ece52 more style values; fix alignment of instrument names 2017-02-27 13:58:17 +01:00
Werner Schweer
cfc5481d8f add font styles for measure numbers 2017-02-27 12:19:30 +01:00
Werner Schweer
e23ca8c80a update script interface 2017-02-27 12:19:30 +01:00
Eric Fontaine
8ad0e680aa Text::drop when not already in edit mode needs to handle Supplementary Unicode 2017-02-25 11:20:23 -05:00
lasconic
78051af6ed enable MusicXML mtest 2017-02-25 12:27:49 +01:00
Nicolas Froment
4fd002088a Merge pull request #3020 from ericfont/176601-InsertMultiByteChar
fix #176601 unicode insert Upper & Lower Surrogates simultaneously
2017-02-25 10:36:06 +01:00
lasconic
e2e19b99e1 fix #166651: Inability to select fingerings in different voices 2017-02-24 18:08:08 +01:00
lasconic
a5800b9243 fix #177116: Inability to select ties in a range selection if the last measure is also selected 2017-02-23 18:47:30 +01:00
Eric Fontaine
2d6ce9c635 fix #176601 Supplemental Unicode select, insert, paste
Any operations dealing with Supplemental Unicode must operate on high & low surrogates simulatenously, since they belong together as a pair:
-Text::insert method has a new version of which takes two QChars as input (the high & low surrogates), and inserts them together before incrementing the cursor.
-TextBlock::fragment method now has return parameter ridx (relative QChar index) in addition to rcol (relative cursor position).  For Basic Unicode TextFragments, ridx will be same as rcol, since each Basic Unicode char is one QChar.  But for text that has Supplemental Unicode, ridx will be be different since each Supplemental Unicode char is two QChars.
-TextBlock::text method now includes any high surrogate QChars in the returned string.  Previously, this method simply skipped over QChars that were high surrogates.  When iterating over the TextFragment, only increments col when comming across a QChar that is not a high surrogate.
-Text::createLayout, Text::paste and Text::drop methods now uses the new Text::insert method to insert both high & low surrogates together.  Previously, the cursor position would get messed up when each QChar was added seperately.
-TextBlock::remove(int start, int n) will now add both QChars of the surrogate pair to the return string.

Also was issue with adding text after a SMUFL symbol if the cursor mode was already in SMUFL.  Fixed by making sure to append a new TextFragment regardless of state of cursor, and also making TextFragment::TextFragment(TextCursor* cursor, const QString& s) constructor set the type to CharFormatType::TEXT.
2017-02-23 11:51:38 -05:00
lasconic
8381b3edc3 fix #105951: CRASH on close score after deleting all segment of a spanner 2017-02-23 11:56:06 +01:00
Werner Schweer
c4b477bab2 fixes for layout, align property 2017-02-23 11:42:03 +01:00
lasconic
d3e1c0bd24 fix #176631: Select -> more... selects wrong voice dots 2017-02-22 18:52:20 +01:00
Eric Fontaine
1b67e23194 fix #176151 MultiByte char TextBlock::remove()
Previously TextBlock::remove() did not delete Supplementary Multilingual Plane Unicode chars correctly.

Added tests using deletePreviousChar() for SMP Unicode as well as regular BMP Unicode as well as for text that has mixed BMP, SMP, and SMUFL symbols.
2017-02-22 08:33:39 -05:00
lasconic
c2ef50f646 fix #167416: cut a measure with tuplet causes crash. Trying to not reopen # #29796 2017-02-21 19:23:40 +01:00
Nicolas Froment
d884878d3a Merge pull request #2991 from RaphaelCojocaru/72896-imagecapture
fix #72896: solved the blank name issue within Save as option in Imag…
2017-02-20 18:38:00 +01:00
Raphael Cojocaru
316e09823b fix #72896: solved the blank name issue within Save as option in Image capture feature by setting a default name consisting of current score name; every score will use this default name for its first save
compute the default path only for the very first save

fixed the coding style issues

updated the solution in order to cover the native dialogs as well
2017-02-20 18:18:26 +02:00
lasconic
7a8ba0706d fix #175341: [GP6] Crash on a file involving arpeggios, ties and capo feature 2017-02-20 17:16:45 +01:00
lasconic
3340d623de fix #52841: No sound feedback in repitch mode when using MIDI or Piano Keyboard 2017-02-20 14:12:56 +01:00
Werner Schweer
2a5152a6a5 misc. fixes for time signatures 2017-02-20 11:44:03 +01:00
Eric Fontaine
896dafb939 fix #175461 Shift+W and Shift+Q to inc/dec duration to next dotted or undotted duration 2017-02-20 04:05:12 -05:00
lasconic
1725d1f845 fix #152506: Introduce a time signature in a measure which the Actual duration is exactly identical leads to corruption/crash 2017-02-19 22:13:04 +01:00
lasconic
d93ac18985 fix warning regarding braces in initialization 2017-02-19 11:00:10 +01:00
Werner Schweer
94fe39f52e fix alignment of tuplet numbers 2017-02-18 11:24:00 +01:00
Werner Schweer
fc55143b95 update mtest 2017-02-17 15:48:28 +01:00
Werner Schweer
90b1991912 replace Q_OBJECT with Q_GADGET for all Element based classes 2017-02-17 15:48:28 +01:00
Joachim Schmitz
9b9081bd36 fix some compiler warnings
not dealing with those where the code suggests that there are TODOs and
those are too far away to immediatelly spot them
2017-02-17 11:04:49 +01:00
lasconic
5a313cd4bb fix #64046: Korean input method on windows doesn't work with Shift 2017-02-17 00:48:35 +01:00
lasconic
5e52f115df fix compilation 2017-02-16 18:53:23 +01:00
lasconic
efd6f850f7 Partially fix #92591: No feedback while typing Korean 2017-02-16 18:24:54 +01:00
vinayak
b860643291 fix #25271: Part export automatic numeration of same instruments 2017-02-16 22:16:08 +05:30
Werner Schweer
723015c2a3 fix import problem of 2.x files with parts 2017-02-16 11:18:01 +01:00
lasconic
4f4b2049b8 fix case of bow actions 2017-02-15 18:34:59 +01:00
Nicolas Froment
6ffaf4ec0d Merge pull request #2928 from divya-urs/add_keyboard_shortcuts_bowing_symbols
fix #152766: Add keyboard shortcuts for up bow and down bow symbols
2017-02-15 18:19:37 +01:00
Werner Schweer
fa25d23bdc fix deleting measures 2017-02-15 13:59:06 +01:00
Werner Schweer
6b0a1e6c1e fix hairpin import of 2.0x files 2017-02-15 13:59:06 +01:00
Werner Schweer
9f94de8ca5 fix 'small' property for staves 2017-02-15 13:59:05 +01:00
Werner Schweer
70eec09476 fix update after add/remove of keysig 2017-02-13 17:06:30 +01:00
Werner Schweer
88703a3259 interpret custom keys 2017-02-13 12:45:37 +01:00
Werner Schweer
63c9ad1234 inspector update 2017-02-13 12:45:37 +01:00
Werner Schweer
bfebf95b66 update inspector for lyrics 2017-02-12 10:31:19 +01:00
Werner Schweer
59191a3710 fix layout position of Jump/Marker 2017-02-10 15:13:23 +01:00
Werner Schweer
f94b780f2b fix debugging code for CmdState 2017-02-09 16:07:07 +01:00
Werner Schweer
c130e6a9e3 fix header/footer text 2017-02-09 14:57:40 +01:00
Werner Schweer
a53bf1e2c3 some 2xx compatibility fixes 2017-02-09 11:57:10 +01:00
Werner Schweer
76820da37d fix crash writing styles 2017-02-08 20:12:07 +01:00
Werner Schweer
0bfff766d4 updates for RehearsalMark 2017-02-08 18:11:51 +01:00
Werner Schweer
be3e45d8c1 more inspector updates 2017-02-08 16:21:44 +01:00
Werner Schweer
eafb1e259d fix #167336: staff scaling doesn't work 2017-02-08 15:34:53 +01:00
Werner Schweer
3e978be4ba misc. layout fixes; inspector update 2017-02-08 13:29:25 +01:00
Werner Schweer
8d98c90995 inspector updates 2017-02-08 11:12:43 +01:00
Werner Schweer
fe8a3e5e9c move textline properties to inspector 2017-02-07 18:48:41 +01:00
Joachim Schmitz
f6b70bb004 Don't autosave unchanged 'imported' 1.x or 2.x scores
there's no real need for this and it changes the score properties in the
metaedit dialog after autosave.
It also prevents leftover temp files, apparently in this particular case
of scores 'imported' from 1.x or 2.x the temp files are not deleted on a
clean exit. Temp files for real imports and scores of the current version
are getting cleaned up though.
2017-02-03 14:52:02 +01:00
Joachim Schmitz
2bbf303530 fix #152206: Revision is not shown in Score Properties
for scores from 2.0 or later, actually for scores created after the move
from sourceforge to GitHub
2017-02-03 09:34:19 +01:00
Nicolas Froment
44d915869e Merge pull request #2980 from Jojo-Schmitz/note-bracket
Plural of parenthesis is parentheses
2017-02-02 09:48:43 +01:00
Nicolas Froment
7f3b0b9b99 Merge pull request #2976 from Jojo-Schmitz/ambitus
fix #166231: Ambitus gets reported an octave to high
2017-02-01 14:27:47 +01:00
Joachim Schmitz
75439a7bfc Plural of parenthesis is parentheses 2017-02-01 11:23:58 +01:00
Werner Schweer
ddc907d415 fix autoplacement of dynamics 2017-01-31 20:34:50 +01:00
Joachim Schmitz
6fdb67a3b4 note brackets are actually parenthesis 2017-01-31 18:52:09 +01:00
Werner Schweer
48f2f0897f add parenthesis/bracket to accidental 2017-01-31 17:28:56 +01:00
Werner Schweer
902a5f7add remove obsolete 'Album'; style updates 2017-01-31 12:22:05 +01:00
Joachim Schmitz
39c4224c4c fix #166231: Ambitus gets reported an octave to high
in Inspector, status bar and screen reader.
Also getting rid of superfluos backslashes and an unneded code
duplication
2017-01-30 09:20:12 +01:00
Werner Schweer
c1a143fc10 try to fix build 2017-01-25 18:46:21 +01:00
Werner Schweer
6ecd806ff3 better bw. compatibility 2017-01-25 15:55:04 +01:00
Werner Schweer
9a9dedf774 change PageFormat to simple style values 2017-01-23 21:53:51 +01:00
Werner Schweer
22743535f7 Merge pull request #2969 from Jojo-Schmitz/fingering-crash
fix #165196: crash on attempt to open fingering palette
2017-01-23 10:57:42 +01:00
Werner Schweer
251c298821 more complete SystemText impl. 2017-01-23 10:54:57 +01:00
Joachim Schmitz
ce331dc5f7 fix #165196: crash on attempt to open fingering palette 2017-01-23 10:17:57 +01:00
Werner Schweer
afe8c2f9e7 style fixes 2017-01-20 14:44:51 +01:00
Werner Schweer
f8417ca046 add SystemText element 2017-01-20 11:05:52 +01:00
Werner Schweer
e8621b8e2a fingering layout update; fixed layout bugs 2017-01-19 16:06:40 +01:00
Werner Schweer
6b7de2e9c3 add substyles to staff text and system text in inspector 2017-01-19 10:11:12 +01:00
Werner Schweer
bbc6767827 fix enabling reset button for styled properties in inspector 2017-01-19 09:35:38 +01:00
Werner Schweer
73d097eec6 cleanup some header files 2017-01-19 09:17:21 +01:00
Joachim Schmitz
20d5a45aca improve substyles 2017-01-18 20:25:37 +01:00
Werner Schweer
1d4c6b2f21 move Element::type() to ScoreElement 2017-01-18 14:16:33 +01:00
Werner Schweer
ab63cec0b7 add substyle to fingering in inspector 2017-01-17 17:52:17 +01:00
Werner Schweer
6356d898e2 remove debugging artifact 2017-01-17 15:49:54 +01:00
Werner Schweer
5610f94fe3 fix reset button initialization in inspector 2017-01-17 13:12:41 +01:00
Werner Schweer
0c48196551 move systemFlag from Text to Element 2017-01-17 10:16:15 +01:00
Werner Schweer
6ab16d83a3 enhance tick() method for text 2017-01-17 09:58:51 +01:00
lasconic
c745526cfe fix compilation after 5433d71 2017-01-16 22:16:10 +01:00
Werner Schweer
5433d719d9 replace TextStyle by SubStyle 2017-01-16 20:59:21 +01:00
lasconic
eb4455ca1f quick fix to make nightly start on Mac OS again 2017-01-15 09:20:08 +01:00
Nicolas Froment
fa56526fb7 Merge pull request #2959 from Jojo-Schmitz/articulation
small correction for articulation
2017-01-14 18:24:17 +01:00
Joachim Schmitz
541d2e643e small correction for articulation, see dafb5f3 2017-01-10 15:27:03 +01:00
Joachim Schmitz
c8fdd20908 fix accessibilty texts for new fingering inspector
and correct a typo in a comment
2017-01-09 10:50:52 +01:00
divya-urs
1b40bdcb9d fix #152766: Add keyboard shortcuts for up bow and down bow symbols 2017-01-06 18:18:36 +05:30
Werner Schweer
73a2e6a1a4 add fingering panel to inspector 2017-01-05 14:53:21 +01:00
Werner Schweer
0b1aea952f layout for movements 2017-01-05 11:28:45 +01:00
Werner Schweer
29a1f4725f add Movement class 2017-01-05 11:24:01 +01:00
Nicolas Froment
caff12726a Merge pull request #2943 from Fyrult/153501-enChangeDoubleFlats
fix #153501: After enharmonic change, double flats stay
2017-01-03 09:16:03 +01:00
lasconic
851f7e6f1b fix #109576: hidegray line above figured bass when Show Unprintable is unchecked 2017-01-03 08:36:31 +01:00
Nicolas Froment
996b881f7a Merge pull request #2937 from RaphaelCojocaru/109576-figuredbass
fix #109576: removed gray line above figured bass numbers when Show U…
2017-01-03 07:33:04 +01:00
Fyrult
f87b20b01e fix #153501: After enharmonic change, double flats stay 2016-12-31 23:34:17 -05:00
lasconic
3b8c8e6060 Fix #106026: System Text should be labeled as 'System Text' 2016-12-31 14:00:54 +01:00
lasconic
e0bedae6c2 fix warning on macosx 2016-12-30 14:37:27 +01:00
Nicolas Froment
8d0c64a12d Merge pull request #2933 from Jojo-Schmitz/inspector
Inspector fixes after 22454df, 84faf50, 95ce45a and 35b948a
2016-12-30 13:39:44 +01:00
Nicolas Froment
75ae531279 Merge pull request #2920 from AntonioBL/tuplet_sanitize
Tuplet sanitize
2016-12-30 13:36:49 +01:00
Joachim Schmitz
ac1a9a62aa Inspector fixes after 22454df, 84faf50, 95ce45a and 35b948a
and fix warning reg. unused parameter
2016-12-30 11:38:19 +01:00
Werner Schweer
35b948adaf add instrument name panel to inspector 2016-12-30 10:58:53 +01:00
Raphael Cojocaru
52df71e9ee fix #109576: removed gray line above figured bass numbers when Show Unprintable checkbox is checked. 2016-12-29 21:04:11 +02:00
Werner Schweer
95ce45afec add inspector panel for Bracket 2016-12-29 19:46:40 +01:00
Werner Schweer
b0074320d7 fix #151486: spanners expected to end at a system break span to next system break 2016-12-29 17:12:34 +01:00
Werner Schweer
142e44e39c return element Shape in element coordinates 2016-12-29 16:42:10 +01:00
Werner Schweer
9bbec943ad fix barlines in palette 2016-12-29 15:11:28 +01:00
Werner Schweer
62513977a0 misc. updates for barlines 2016-12-29 13:42:55 +01:00
Werner Schweer
aa98918784 add 'set as staff default' button for barline in inspector 2016-12-28 19:09:11 +01:00
Werner Schweer
22454df70e small fixes for save/restore barlines 2016-12-28 17:21:30 +01:00
Werner Schweer
1a52a38164 update BarLine, mtests 2016-12-28 16:36:59 +01:00
Werner Schweer
337e885896 barline changes, part-1 2016-12-28 16:36:59 +01:00
Nicolas Froment
ddc0f12ca9 Merge pull request #2913 from Jojo-Schmitz/dividers
fix #151456: right system dividers show left
2016-12-21 10:49:22 +01:00
Joachim Schmitz
4907fbaa8b treat files older than from 0.9.6 as 1.x files rather than as 2.x ones 2016-12-20 09:17:50 +01:00
Joachim Schmitz
8d855297d9 treat opening files from 2.x as import, just like files from 1.x 2016-12-20 08:53:26 +01:00
AntonioBL
b65df09211 fix reading of tuplets and add tests 2016-12-19 14:11:55 +01:00
AntonioBL
f58c0c0ea2 Cleanup and fixes for corrupted tuplets import 2016-12-19 14:11:40 +01:00
AntonioBL
d1eab7abeb fix import of old corrupted tuplets 2016-12-19 14:11:27 +01:00
AntonioBL
57f2791c44 fix tuplet duration and baselength when importing old files 2016-12-19 14:11:13 +01:00
Werner Schweer
dde08c9a70 fix incremental layout for staff type changes 2016-12-19 10:33:52 +01:00
Werner Schweer
6d0288efdd fix merge problem 2016-12-18 14:42:41 +01:00
Werner Schweer
6e7e05aaec impl. staff type changes 2016-12-18 14:31:34 +01:00
lasconic
67b1111937 fix #151501: Remove line breaks tool fails 2016-12-16 18:45:54 +01:00
Joachim Schmitz
686c46924f simply systemdivider 2016-12-16 17:25:07 +01:00
Joachim Schmitz
a79266e36a fix #151456: right system dividers show left 2016-12-16 17:17:12 +01:00
Joachim Schmitz
2053324a31 fix #111576: crash when using page settings dialog after having moved system dividers 2016-12-16 10:13:23 +01:00
lasconic
29d6140865 fix mac osx build 2016-12-15 23:33:31 +01:00
Joachim Schmitz
0f206cd099 fix warnings in RELEASE mode
reg. unused parameter and variables possibly being used uninitialized
2016-12-15 14:45:14 +01:00
Joachim Schmitz
fd1d06cf98 fix #151361: Can't build in RELEASE mode 2016-12-15 14:21:32 +01:00
lasconic
8051b4238e fix #151156: Cross-staff glissando missing when creating piano part 2016-12-15 00:27:46 +01:00
Joachim Schmitz
7bf492a745 fix warning reg. unused parameter 2016-12-14 16:48:54 +01:00
Werner Schweer
d34d09aab9 add StaffTypeChange element 2016-12-14 15:44:24 +01:00
Werner Schweer
9c8aa7a109 fix layout of system header 2016-12-14 15:44:24 +01:00
Werner Schweer
660b393b98 change StaffType interface 2016-12-14 15:44:24 +01:00
Werner Schweer
cb7485f6f8 hide MStaff 2016-12-14 15:40:26 +01:00
Werner Schweer
c5434443c3 remove Excerpt from Staff 2016-12-14 15:40:26 +01:00
Werner Schweer
6dd13e4074 hide MStaff elements 2016-12-14 15:40:26 +01:00
lasconic
b2e10c7aab fix layout of notehead and stem in drum palette and drum note preview 2016-12-13 16:55:42 +01:00
Werner Schweer
01e5df432b fix #140266: no system header after horizontal frame; code cleanups 2016-12-12 10:31:37 +01:00
Werner Schweer
49250a00ce fix incremental layout of slurs 2016-12-09 15:57:05 +01:00
Werner Schweer
01a3270458 remove A_CMD flag from 'pitch-down' shortcut 2016-12-09 15:57:05 +01:00