Commit graph

53 commits

Author SHA1 Message Date
Peter Hieu Vu
86a4e7b105 Added basic chord symbol realization 2020-03-19 13:52:39 +02:00
Joachim Schmitz
b1ab9574cc Use C++ casts 2020-03-03 15:49:37 +01:00
luz.paz
f31624d746 fix various typos
* Found via `codespell -q 3 -S ./share/locale,./thirdparty -L ba,cann,clas,dur,foto,iff,nd,ois,ot,pres,possibile,snaped,strack,tage,te,uint,thru,valu`  
* Some revisions made per feedback given during review.
* Follow-up typos for review  
* Add revisions per feedback
2019-12-19 06:13:30 -05:00
ws
ec3be9a99a Replacd integer midi tick values by fractions.
- tick names a position on the time axis
- tick is always a Fraction()
- only Measure() and Segment() (and Tuplet?) have a tick value
- tick() for an generic element return only a sensible value if isMeasure() or isSegment() or isSegment(parent())

- "ticks" names a duration stored in a Fraction()
- the tick value for an Segment is relative to its measure

- rename "duration" to "ticks"
- rename afrac() to tick()
- rename rfrac() to rtick()
- rename some variables, changing "fraction" into "tick"
  (example: actualFraction() into actualTicks())

- Lyrics ticks are written as Fraction, on read if xmlreader sees a "/" it reads a fraction
  else midi ticks for backwards compatibility
2019-02-18 11:46:05 +01:00
Joachim Schmitz
a4c491bd2a fix #281028, fix #280842, fix #280470, fix #281369 and some more text fixes
* Change sharps, flats and naturals to their unicode counterparts
* Fix #281028: remove superfluos double spaces
* Add missing "the"
* Fix #280842: change [Tablature] to (Tablature) for instruments
* fix #280470: Inconsistent reference to menu entry navigation
* Translate MusicXML import error message prefix
see https://musescore.org/en/node/281133
* Improve message on importing pre-3.0 scores
and also enabling it for pre-2.0 scores
* Fix #281369: Ottava bassa shows as "8vb", while 15ma and 22ma is used
for alta and bassa
see also PR #4547
Clefs were having the same issue, so changed those too
* Improve one text in Preferences > I/O and remove another
as that is no longer true
* Yet another ellipsis
2019-01-11 15:15:25 +01:00
Joachim Schmitz
6523abc0b6 fix compiler warnings with MinGW 64bit 2018-09-27 17:38:20 +02:00
Joachim Schmitz
474e8152cd fix #275218: fix MSVC C4456 warnings
reg. a declaration shadowing a previously declared local
variable,
"Warning C4456: declaration of 'XXX' hides previous local
declaration"
2018-09-27 17:38:19 +02:00
Joachim Schmitz
b27817fe19 fix more MSVC warnings
* The one C4100
* The one C4189
* The two C4457
* The two C4701
* The 475 C4267, changing to size_t were easily possible, casting to
int elsewhere
* Fix GCC warnings reg. wrong printf format for a size_t, reg. unused
variables and reg. ambigous else branch, seen on Travis CI
2018-09-11 16:56:50 +02:00
ws
33d1cd7fb4 rename StyleIdx -> Sid and P_ID -> Pid 2018-03-27 15:36:00 +02:00
lasconic
5012e85dc6 remove unused function in pitchspelling 2017-06-16 11:27:20 +02:00
lasconic
22cfe6a9db Add more noteheads and staff type for dynamic noteheads (shapes, notenames, etc...) 2016-11-18 13:09:49 +01:00
ws
9ec1d02471 code cleanups & speed optimizations 2016-04-13 11:18:14 +02:00
Marc Sabatella
f144d7c978 fix #9352: instrument change transposition 2015-09-25 08:35:55 -06:00
lasconic
61eed11401 fix all warnings on Mac OSX. Hopefully without side effects on other platforms. 2015-05-05 18:28:39 +02:00
Marc Sabatella
4974b2dc7b fix #53461: respell changes only concert pitch 2015-04-10 15:10:30 -06:00
Marc Sabatella
a52827e501 add ability to turn off automatic capitalization of chord symbols 2014-12-17 12:37:06 -07:00
Marc Sabatella
fbdd224791 add chord symbol style options: full german, french, lwoer case bass, all caps note names 2014-12-10 00:12:00 -07:00
Marc Sabatella
c4faee7198 fix #40066: use es/is for german chords if lower case option enabled 2014-12-05 16:25:36 -07:00
Andrei Tuicu
6460485d3f Score accessibility system.
Provides screen-reader feedback for the selected element.
2014-08-19 00:09:13 +03:00
ws
37cb28dcc7 mark imported 1.2 files as new 2014-07-14 11:18:34 +02:00
ws
b4066a7976 stronger typing for key 2014-06-20 17:07:22 +02:00
Joachim Schmitz
5a9b6395de avoid warnings reg. unused variables 2014-06-17 14:35:16 +02:00
Joachim Schmitz
9a636ac9c6 remove some unneeded '\n'
and also fix a typo
2014-06-10 09:27:55 +02:00
ws
b7dd5af499 update KeySig implementation 2014-06-03 15:28:10 +02:00
Joachim Schmitz
4e048f1712 convert enum Key into enum class
and to be able to ret rid of the KEY_ prefix, change enum Tpc's members
by adding (back) the prefix TPC_
2014-05-30 13:37:39 +02:00
Joachim Schmitz
76db7c6f66 convert enum AccidentalVal into enum class 2014-05-27 11:41:07 +02:00
Joachim Schmitz
93a60e8944 convert unnamed enum into enum Key
but converting into enum class requires some more work. And mostly for
that reason can't yet get rid of the "KEY_", as it clashes with enum Tpc
(which too hasn't yet been converted into en enum class)
2014-05-26 12:27:31 +02:00
Joachim Schmitz
0d6cc4ffe0 convert unnamed enum into enum Tpc
but haven't had the guts to make it an enum class yet
2014-05-26 12:27:29 +02:00
Joachim Schmitz
788852752d convert unnamed enum into enum class Prefer 2014-05-26 12:27:28 +02:00
Joachim Schmitz
1dd944e297 convert enum NoteSpellingType into enum class 2014-05-26 12:25:25 +02:00
ws
e534cccef8 bug fixes for concert pitch switch 2014-04-09 16:09:21 +02:00
Joachim Schmitz
5977488174 eliminating needless \n in qDebug() calls
searching for 'qDebug.*\\n\'
2014-03-25 14:59:32 +01:00
Joachim Schmitz
3adc1ea6ed fix #14764
convert qDebug();abort() to qFatal() and if(cond) abort() to
Q_ASSERT(!cond), esp. for the benefit of Windows, where it is impossible
to set a breakpoint on the abort()
Also modernizing mscoreMessageHandler() and making it more informative
by adding file, line and function to the output.
2014-03-04 13:06:23 +01:00
Marc Sabatella
48c3e2fd94 also B#, B## - and add test
transpose tests were not being run, it seems, but they do work, so I am
enabling them and adding a diatonic transpose test that includes a full
chromatic scale.
2013-12-17 16:47:55 -07:00
Marc Sabatella
4554f23b18 fix #22131: bad diatonic transposition of Cb, Cbb 2013-12-15 21:44:33 -07:00
Marc Sabatella
8e92462f42 Gernan chords use As and Es, not Aes and Ees
Also add hooks for French spelling of Re
2013-06-28 17:35:38 -06:00
Marc Sabatella
a90d21f8c7 fix #11115: support solfeggio note names
Actual support was added in previous commits; this is really just
cleanup and renaming the option from "Italian" to "Solfeggio".
2013-06-28 17:35:37 -06:00
Marc Sabatella
30d7afb2ed fix #7282 - support additional root/bass styles
German, Italian, lower case minor
2013-06-28 17:35:33 -06:00
ws
9ebabcc2e5 add namespace Ms 2013-05-13 19:43:59 +02:00
ws
0be1d3f78e synthesizer/midi cleanups 2013-04-08 11:27:14 +02:00
ws
220db94494 reorganize synthesizer; add zita1 reverb 2013-04-03 12:50:21 +02:00
Tony Mountifield
f79ae65f52 Update a couple of comments... 2013-02-12 12:02:59 +00:00
Tony Mountifield
c3ba739938 Remove code no longer used... 2013-02-12 11:46:14 +00:00
Tony Mountifield
50207f185c Key-based cursor note movement and pitch2tpc()
Replace pitch2tpc2() and both variants of pitch2tpc() with a single
generic pitch2tpc(). Add PREFER_SHARPS, PREFER_NEAREST and PREFER_FLATS.
Update all places where those functions are called from.
Use intelligent key-aware stepping of pitch and tpc in Score::upDown().
2013-02-10 22:58:59 +00:00
ws
4f9d80a7af fix regression tests 2013-01-04 10:18:06 +01:00
ws
501b98930c replaye toAscii() with toLatin1() 2013-01-02 16:39:19 +01:00
Maurizio Gavioli
717ad9d3c9 Fixed computing alteration of tcp's with respect to key degrees 2012-11-22 00:09:27 +01:00
Maurizio M. Gavioli
62ec5f4808 Adds diatonic mode to the Transposition dlg box.
Has option for keeping altered degrees or not.
Includes transposition of chord names, probably to be improved.
2012-11-22 00:09:27 +01:00
Werner Schweer
2f2d5a4a2f fix regressions for note entry 2012-08-08 20:46:29 +02:00
Werner Schweer
9d12841cf7 cleanup note entry 2012-08-07 16:05:37 +02:00