Peter Jonas
b33682292b
Porting real-time bug fixes from 2.X into master branch.
2018-03-21 00:26:40 +00:00
lasconic
838be7ac5b
fix mtest
2018-03-19 23:06:07 +01:00
Johan Temmerman
a67ae584b9
fix #270332 : playRepeats replay copy was too greedy
2018-03-14 14:39:57 +01:00
Leon Vinken
ba3d8adf9a
fix #269948 - [MusicXML import] crash when importing single staff part referring to staff 2
2018-03-12 21:49:11 +01:00
Nicolas Froment
ce6b003871
Merge pull request #3532 from Jojo-Schmitz/reverse-mtest-diff
...
reversing the order in which mtest compares reference and test file
2018-03-12 12:58:10 +01:00
Nicolas Froment
472149b75d
Merge pull request #3533 from jeetee/8604_followUp_enable_combined_repeatlist_test
...
fix #8604 follow up: re-enabled and actualized combined repeatList test 36
2018-03-12 11:16:09 +01:00
Johan Temmerman
e5c42af290
fix #8604 follow up: re-enabled and actualized combined test 36
...
* fix searchVolta for measure by checking the tick() rather than no() to ensure measure is found in the correct section
* fix crash if jumpToMeasure is found, but not yet in its final playThrough
2018-03-12 01:36:13 +01:00
Joachim Schmitz
5dbabfeb55
reversing the order in which mtest compares reference and test file
...
reference being the older and 'should-be' case, so should be diff's 1st
arg, so the + and - of the diff show what got added or removed in the
test
2018-03-11 13:44:37 +01:00
Leon Vinken
fdc0549cc9
fix #255791 - [MusicXML import] use lyric number as relative instead of as absolute line number
2018-03-10 11:02:03 +01:00
Nicolas Froment
b097bf89ba
Merge pull request #3515 from jeetee/269603_unwind_RepeatList_followup
...
fix #269603 , fix #148276 unwind followup especially with regards to DS having playRepeats enabled
2018-03-07 15:22:33 +01:00
mirabilos
d6ae8183b3
Remove redundant CMAKE_CXX_FLAGS assignment
...
mtest inherits its flags from the top-level file
2018-03-07 15:00:13 +01:00
Johan Temmerman
79d4227534
fix #148276 end Open Volta before next startRepeat as well
...
fix #269603 unwind followup especially with regards to DS having playRepeats enabled
2018-03-07 12:55:07 +01:00
Eric Fontaine
c64e557d20
fix #269919 undoRemoveElement detach parent system
...
The presence of a non-null parent system resulted in a crash in the intial layout after a redo of a deleted initial VBox. To fix this, I'm detaching the parent system during undo, so the VBox MeasureBase when undeleted won't point to the old system (which confused layout because layout couldn't find this old system in the new list of systems). Since a new parent system will be regenerated anyway on the initial layout after the redo operation, I believe it is safe to detach the parent system here during undo.
2018-03-02 09:29:58 -05:00
Finley Lau
5dd85bd5ab
fix #269467 : added stringutils class to support searching without accents, added tests in mtest
2018-02-27 15:15:34 -06:00
Leon Vinken
03f1388627
fix #268009 - Crash on MusicXML Import caused by duplicate clef definition ...
2018-02-25 20:35:31 +01:00
anatoly-os
8915b35db2
Fixed clang warnings:
...
- removed obsolete Score* _score from XmlReader
- removed not used variables
- added braces for initializer list
- fixed using similar var names in one scope
2018-02-21 19:41:36 +01:00
Johan Temmerman
e274a4167a
fix #269378 Double Coda leads to not detecting 'final' playthrough after 2nd jump rewind logic
2018-02-16 09:26:44 +01:00
Leon Vinken
d0c5ef59c2
refactor MusicXMLParserPass[12]::note(), MusicXMLParserPass2::notations() and ExportMusicXml::chord()
2018-02-14 19:24:07 +01:00
luz.paz
443be63167
Misc. typos
...
Found via `codespell -i 3 -w --skip="./thirdparty,./share/locale,./fonts" -I ../musescore-whitelist.txt`
Whitelist:
```
clas
nd
ot
pres
strack
tage
te
```
2018-02-13 12:06:05 -05:00
Dag Henning Liodden Sørbø
2b6cb8b432
Change to new preferences model
...
The old Preferences struct holding all preferences are removed in favor of a
new Preferences class which acts as a proxy for QSettings. The settings stored
in QSettings are accessed directly through access methods like getBool(key),
getInt(key), etc. and changed with setPreference(key, value).
Since we are using QSettings directly the preferences are stored automatically
without the need for a custom write() and read() method like before.
The preferences.cpp/.h and prefdialog.cpp/h are refactored to have fewer
responsibilities than before. The Preferences class are all about storing and
retrieving preferences - it should not contain any code to handle any other
aspect of MuseScore.
Testing:
The Preferences class can be used in tests. All preferences are initialized with
default values in mtest. If a test requires that a preference has a specific
value it can be changed using setPreference() for that single test. In the tests
the preferences are stored in memory only.
The Preference class is supposed to be used as a singleton. In preferences.h an
'extern Preferences preferences' is set and it is defined in preferences.cpp. All
files which includes preferences.h have access to the 'preferences' singleton
and should use this to get and set preferences.
2018-02-08 16:59:10 +01:00
Johan Temmerman
dd2050e2f1
fix #8604 , fix #4525 , fix #6091 , fix #48456 , fix #148276 , fix #230531 , fix #267778 : improve volta playback
...
unwindSection using RepeatList as how a human will notate the volta: using the n-th time a startRepeat is taken, also slightly modified the jump detection logic to have it check for jumps only upon the last passage of a measure
2018-02-07 11:21:59 +01:00
Johan Temmerman
30879209f5
added and actualized repeat tests:
...
* no-repeat (13) shouldn't have an off-page invalid jump either
* Jumps should be taken on last repeat
* repeatlist should make human-sense, not (only) programmer-sense (9)
* added 1,3/2,4 style test
* added tests to determine when an open volta should end
* added 'with repeats' tests
2018-02-07 11:21:40 +01:00
ws
218bf79302
autoplace & other cleanups
2018-02-01 15:36:30 +01:00
Giuseppe de Beer
8448417ed2
Fix #268968 : MusicXML import export lyric color
2018-01-30 22:07:42 +01:00
vliegnaarbeer
59002926b2
Fix #268578 : MusicXML import export rest colors
2018-01-30 18:58:32 +01:00
ws
54991c474a
updates for articulations and fermata
2018-01-23 14:09:18 +01:00
ws
6bba383c31
fermata layout fixes; new style values for fermata
2018-01-22 16:50:52 +01:00
ws
1fc16835c8
fix #268577
2018-01-22 10:13:07 +01:00
ws
9d9cd890d6
remove articulations from rest element
2018-01-17 13:25:23 +01:00
ws
35265cd358
implement new fermata element
2018-01-16 13:38:28 +01:00
lasconic
f75fb23df6
fix mtests
2018-01-04 14:31:40 +01:00
Werner Schweer
df237c58c2
fix visual test line-1
2018-01-03 10:00:01 +01:00
Werner Schweer
ef0e2ef0b2
fixes for element initialization
2017-12-27 16:09:27 +01:00
lasconic
0fd90b9433
fix mtests
2017-12-27 12:54:46 +01:00
Leon Vinken
dfb24a397c
fix #267131 - [MusicXML export] print new-system missing in multi-measure rests
2017-12-26 14:26:24 +01:00
Joachim Schmitz
5e116fe595
Fixing issues found in static code analysis by PVS-Studion
...
See https://musescore.org/en/node/255156
2017-12-20 16:26:23 +01:00
Werner Schweer
8c67df20ab
fix visual test emmentaler-4, wrong articulation
2017-12-19 09:18:22 +01:00
Nicolas Froment
0d22fd4d55
Merge pull request #3253 from IsaacWeiss/235516-musicxml-extension
...
Fix #235516 : support .musicxml file extension
2017-12-17 23:20:49 +01:00
lasconic
0deffdbb4e
fix musicxml mtests for MusicXML 3.1
2017-12-17 23:04:06 +01:00
Nicolas Froment
846e4fcb88
Merge pull request #3254 from Jojo-Schmitz/musicxml-3.1
...
Fix #235526 : Update musicxml to 3.1
2017-12-17 22:26:41 +01:00
lasconic
4b604f045e
Fix #267549 : metronome mark for swing contains several metronome-note and crash
2017-12-17 19:54:14 +01:00
Werner Schweer
d92ef8b9d4
update properties/styles, update glissando
2017-12-13 15:50:04 +01:00
wschweer
8d5916dd4a
autoplacement of FretDiagram, gp import fixes
2017-12-06 13:06:07 +02:00
Leon Vinken
a9f02622dd
255066 musicxml articulations dont play back ( #3345 )
...
fix #255066 - MusicMXL import articulations don't play back
2017-12-06 12:25:01 +02:00
lasconic
3f2ca78a5b
GP6 import: fix freetime, tuplet, display ratio of tuplets when custom
2017-12-06 11:41:03 +02:00
lasconic
1b6b420815
fix mtest
2017-12-05 12:30:50 +02:00
wschweer
ecb9c21f67
fix layout of hooks for tablature
2017-12-05 10:44:13 +02:00
lasconic
24b4aa2d0e
import vibrato from GP5 files
2017-12-01 17:43:52 +01:00
lasconic
1b6f415846
add style for vibrato
2017-11-30 22:14:56 +01:00
lasconic
e356a89e51
update for vibrato, it's now a first class Element. GPX import test for vibrato.
2017-11-30 13:25:25 +01:00
lasconic
c2c3cd4822
add back palm mute mtests for GP import
2017-11-29 13:36:23 +01:00
lasconic
b7d51c8d92
fix slurs import in GP6 and enable slurs tests. Honor text codec for GP3-5 and SubTitle in GP6
2017-11-28 18:19:27 +01:00
lasconic
1a606ca727
add let ring tests for GP import
2017-11-28 17:50:16 +01:00
Nicolas Froment
1c72c4f746
Merge pull request #3342 from lasconic/fix-gp6
...
fix GP6 import and more mtests
2017-11-27 18:03:15 +01:00
lasconic
c02a142f6e
fix mtest
2017-11-27 18:01:34 +01:00
lasconic
b39700c0e4
fix GP6 import and more mtests
2017-11-27 17:04:32 +01:00
Werner Schweer
0e4211e2d0
update let ring, palm mute
2017-11-27 16:55:52 +01:00
Werner Schweer
a8d0281255
update mtest
2017-11-27 10:51:34 +01:00
lasconic
6fccf3ddc1
follow up on #266162 , GTP and PTB import hide arpeggio on standard staff
2017-11-24 12:22:00 +01:00
lasconic
0d79c3bc80
fix more gp mtests
2017-11-24 12:16:40 +01:00
Werner Schweer
011320f63e
fixes for gp4 import
2017-11-17 13:41:43 +01:00
Werner Schweer
87e9471640
update gtp import and mtests
2017-11-17 12:27:20 +01:00
Werner Schweer
84a7ef93d3
updates for gtp import, fixes mtest testIrrTuplet.gp4
2017-11-16 17:28:43 +01:00
Werner Schweer
45c2d9136a
guitar pro import update; add power tab import
2017-11-16 10:59:35 +01:00
Leon Vinken
b609e87dc5
Musicxml import logging ( #3330 )
...
Create separate logger class for MusicXML import
2017-11-15 11:48:27 +01:00
lasconic
181c0b5b5e
uncomment and fix MusicXML tests
2017-11-01 09:00:33 +11:00
Werner Schweer
525c4b87a2
fix vertical position of chord names
2017-10-20 12:00:15 +02:00
Werner Schweer
7724169f97
fix for multi measure rest layout
2017-10-17 14:28:03 +02:00
Joachim Schmitz
70f3ca7e01
Fix #235526 : Update musicxml to 3.1
2017-09-27 09:24:47 +02:00
Joachim Schmitz
0ead5a3494
more frets for steel and 12 string guitars
...
and adjust professional
range to match the possible max. frets
2017-09-14 18:49:02 +02:00
Werner Schweer
00a69ae962
update mtest
2017-09-14 11:28:42 +02:00
lasconic
97b5aec8d5
fix let ring import, subtitle import in gp3
2017-08-30 15:30:13 +02:00
lasconic
6a85d228ea
Several fixes for GP6 import, see #247361 . Tuplets in voice > 1, freetext not duplicated, barre in multiple voices, better freetime support
2017-08-26 16:29:43 +02:00
lasconic
de4e6e086f
more fixes for #30336 : Palm mute are now spanners
2017-08-24 13:13:05 +02:00
lasconic
b8da9512ca
more fixes for #30336
2017-08-23 23:57:47 +02:00
lasconic
21078a5a35
misc. fixes for GP import, correct tempo, section name imports as rehearsal marks
2017-08-23 22:17:14 +02:00
lasconic
f44565cc35
fix partially #30336 : proper support for let ring in GP import
2017-08-23 22:08:33 +02:00
lasconic
05e8a9066f
fix #178761 : [GP] Slurs are not imported
2017-08-21 19:44:42 +02:00
Leon Vinken
345fc40e82
fix #239826 by ignoring lyrics on grace notes
2017-08-15 07:19:30 +02:00
Werner Schweer
9d42e920e8
fix regression: wrong stem direction
2017-08-10 14:35:18 +02:00
Werner Schweer
5cee6f8561
update mtest
2017-08-10 12:27:53 +02:00
Werner Schweer
f8340e1fd8
update mtest
2017-08-08 14:42:04 +02:00
mirabilos
490dc31d48
spelling fixes, from Debian’s lintian tool
...
update
2017-08-07 13:55:36 +02:00
Werner Schweer
b889608c30
fix #232551 : TAB clef is misplaced
2017-08-04 15:45:49 +02:00
IsaacWeiss
cee6fe54bf
Fix #235516 : support .musicxml file extension
2017-08-01 18:38:50 -04:00
Nicolas Froment
ac54591bed
Merge pull request #3229 from shoogle/74921-midi-pauses
...
fix #74921 : implement pauses for MIDI files (hack)
2017-07-20 18:13:58 +02:00
lasconic
b0b536d3b4
fix #233911 : [GP6] Standard notes and fret marks in Tabs don't match
2017-07-19 12:39:20 +02:00
lasconic
95ffd26403
fix #232851 further
2017-07-18 23:07:13 +02:00
lasconic
addd1de21f
fix #232841 : [GP6] Unexpected clefs after importing files for keyboards
2017-07-18 18:16:32 +02:00
lasconic
805214ce51
fix #232851 : [GP6] Guitar scores: fretboard diagrams are imported but not the corresponding chord symbols
2017-07-17 19:34:23 +02:00
lasconic
95ead6664f
fix #232776 : [GP6] Crash when scores for keyboards contain chord symbols
2017-07-17 17:00:01 +02:00
Peter Jonas
52a984e491
fix #74921 : implement pauses for MIDI files (hack)
2017-07-06 23:11:51 +01:00
Werner Schweer
6413ac13a8
update mtest
2017-07-06 13:47:41 +02:00
lasconic
5a79342c68
fix mtest
2017-07-05 23:54:20 +02:00
lasconic
0d6ff8c300
fix #230351 : Articulations and ornaments do not play at moderate to high tempos
2017-07-05 23:50:46 +02:00
Werner Schweer
3ab304d157
scripting update
2017-06-29 10:13:55 +02:00
lasconic
b3d613f17f
fix mtest
2017-06-23 22:16:33 +02:00
Werner Schweer
d9d738dd79
update for keysig
2017-06-23 13:53:45 +02:00
Werner Schweer
4241b93649
update scripting interface
2017-06-22 12:42:14 +02:00
Werner Schweer
f4c70e5bb7
fix for foto mode
2017-06-20 09:57:18 +02:00