Commit graph

670 commits

Author SHA1 Message Date
Joachim Schmitz
bf1ad8de5b fix #277501: support more individual text styles
esp. for importing MuseScore 2 scores using many such styles
2019-11-15 13:25:31 +01:00
Dmitri Ovodok
b8eba0fa81 fix #296566: erase invalid elements from CmdState
Prevents crashes if an element triggering layout has been deleted,
e.g. in case of an unsuccessful attempt to add a glissando to a score.
2019-11-11 09:27:42 +02:00
Howard-C
993d705a29 fix #283628: fermata "play" property does not work
Resolves: https://musescore.org/node/283628.
2019-11-01 13:35:50 +08:00
Dmitri Ovodok
0a39d0a593 Fix automatic viewport changes in scores with parts 2019-10-30 16:36:18 +02:00
Dmitri Ovodok
99c7b0d746 Add more information to setLayout() 2019-10-25 16:18:41 +02:00
anatoly-os
44d2b20c2d
Merge pull request #5376 from mattmcclinch/note-input-redesign
Redesign note input workflow based on Tantacrul's suggestions
2019-10-24 11:04:40 +02:00
anatoly-os
5ea06dc407
Merge pull request #5401 from dmitrio95/295792-change-duration-std-sort-crash
fix #295792: fix a crash on changing duration of multiple notes in some situations
2019-10-18 23:23:26 +02:00
Dmitri Ovodok
eb2da4cc0f fix #295792: fix a crash on changing duration of multiple notes in some situations 2019-10-18 16:17:13 +02:00
Dmitri Ovodok
c004c48906 fix #292830: fix copying lyrics to clipboard
Was broken after 1a6058f9a1.
Score::extractLyrics() depends on Measure::_playbackCount values which
are used internally by RepeatList. A quick way to fix the issue with
extracting lyrics (implemented in this commit) is to force repeat list
to be computed before resetting playbackCount variables inside
extractLyrics().
2019-10-18 11:39:37 +02:00
Matt McClinch
c07d2058bb Redesign note input workflow based on Tantacrul's suggestions.
See https://musescore.org/en/noteinput_redesign.

This implements most of the changes Tantacrul suggested in his document, except for the part on Tuplets.
2019-10-15 07:29:17 -04:00
anatoly-os
e2f3431e03 fix clang warnings
But the ones related to deprecations in third-party libs

* Remove unused variables
* Prevent calling non-virtual destructors
* Prevent the warning "Moving a temporary object prevents copy elision" by removing std::move call
* disable "`register` is deprecated" warning related to the 3rd party code
2019-10-14 19:01:59 +02:00
Dmitri Ovodok
cf17cf828d fix #281866: fix inability to correctly set loop markers in parts
As playback is currently always performed for MasterScore, it would be
logical to store the information about positions of playback cursor and
loop markers in MasterScore rather than individual excerpt scores.
This commit implements this approach and fixes the issue with
inability to set loop markers from parts. Strictly speaking, only
changing Seq::setLoopSelection is absolutely necessary to fix the
issue, the approach with moving _pos to MasterScore allows to naturally
avoid incorrect visual feedback due to markers positions information
being not synchronized across scores and ScoreViews.
2019-09-23 16:17:57 +02:00
James Thistlewood
3f40a56dd9 fix #293707: undo doesn't restore deleted frame immediately
Why do these changes fix this particular issue?

After adding any other element, we `setLayout` at the element's
location. However, for boxes, there is an early return, and this step is
missed, meaning the box won't appear until a relevant measure is layed out.
This fix adds the missing `setLayout`.
2019-09-04 17:50:37 +01:00
Dmitri Ovodok
f8718a8b42 Remove unused code
- Remove disabled and largely outdated continuous view layout code
 - Remove declarations of functions which have no definition
 - Remove unused global libmscore variables
 - Remove some excessive forward declarations
2019-08-03 15:52:09 +03:00
Joachim Schmitz
57af1fe2f8 fix compiler warnings on Mac 2019-07-12 10:53:42 +02:00
Dmitri Ovodok
1e04a9db59 fix #290997, pt.1: rebuild tempomap on adding/removing tempo text 2019-06-20 14:58:15 +02:00
Dmitri Ovodok
fc32f2726d fix #290997 pt.2: unify tempo/timesig map rebuilding in layout and fixTicks 2019-06-20 14:58:15 +02:00
Dmitri Ovodok
260a6db916
Merge pull request #5069 from mattmcclinch/164571-update-mixer
fix #164571: UNDO does not remove instrument from mixer
2019-06-17 09:48:30 +02:00
Dmitri Ovodok
a5a5255b0e
Merge pull request #5023 from mattmcclinch/75626-change-voice
fix #75626, fix #287520, restructure ChangeSpannerElements
2019-06-14 11:22:24 +02:00
Matt McClinch
ab62ba1ca0 fix #290415: crash when moving a formerly cross-system-break tied note 2019-06-07 11:56:36 -04:00
Matt McClinch
7c2eb81e71 fix #164571: UNDO does not remove instrument from mixer 2019-05-28 14:48:50 -04:00
anatoly-os
2a6369381c
Merge pull request #5059 from jthistle/289561-repeat-playback-broken
fix #289561: playback continues to repeat after end repeat barline has been deleted
2019-05-26 18:38:10 +02:00
James Thistlewood
5e5b3cd2e0 fix #289561: playback continues to repeat after end repeat barline has been deleted 2019-05-25 08:02:02 +01:00
Matt McClinch
67381c8df4 fix #289552: Crash splitting multimeasure rest 2019-05-23 09:10:56 -04:00
Matt McClinch
5aedd216de fix #75626: Cannot move tied note into another voice 2019-05-17 14:25:11 -04:00
Matt McClinch
be64d8c2a3 Removed "synthesizer/msynthesizer.h" dependency from libmscore. 2019-05-06 13:01:25 -04:00
Dmitri Ovodok
1ff6afe012 Refactor RepeatList, avoid extra updates of RepeatList 2019-05-02 13:08:11 +03:00
anatoly-os
36275efe2c
Merge pull request #4905 from dmitrio95/283542-vbox-remove-crash
fix #283542: fix a crash on removing vertical frame while linked score is in continuous view
2019-05-01 21:51:51 +02:00
anatoly-os
469616459e
Merge pull request #4932 from dmitrio95/change-duration-multiple
Allow changing duration of multiple notes
2019-05-01 14:00:45 +02:00
James Thistlewood
62b4559a14 fix #287701: Default synthesizer settings not applied to new or loaded score 2019-04-19 19:31:50 +01:00
James Thistlewood
121bf5c5b9 fix #287630: changing instrument doesn't switch patch to expressive 2019-04-19 11:22:13 +01:00
Dmitri Ovodok
a017d8e5a1 Allow changing duration of multiple notes 2019-04-17 14:41:05 +03:00
Dmitri Ovodok
b924de998f fix #283542: fix a crash on removing vertical frame while linked score is in continuous view 2019-04-12 11:42:04 +03:00
James Thistlewood
507866fdfb single-note dynamics: make some final fixes 2019-04-11 19:56:42 +01:00
Marc Sabatella
b8d0338fcd fix #286530: scaling of dot, lines, and more in parts 2019-04-01 15:04:50 -06:00
Marc Sabatella
f5abd23390 fix #286794: permanent courtesy time signatures after style change 2019-03-27 23:51:21 -06:00
anatoly-os
09ef1d4f8f
Merge pull request #4644 from velochy/linearize
Tool to unroll all repeats. Fix #283592
2019-03-23 11:11:15 +02:00
anatoly-os
cbcdb290ad
Merge pull request #4815 from dmitrio95/memory-leaks-load-close
Fix various memory leaks on loading/closing score
2019-03-22 09:41:38 +02:00
anatoly-os
745aee8c6a
Merge pull request #4792 from peterhieuvu/285781-part-save-reload
fix #285781: loading existing scores no longer applies default style, loading parts no longer inherits style from parent
2019-03-20 16:24:31 +02:00
Dmitri Ovodok
6aeb990ea0 Fix MM rests memory leak 2019-03-20 10:23:35 +02:00
Margus Niitsoo
62e85582e9 Tool to unroll repeats. Fix #283592
As a by-product, also Fix ##100246
2019-03-19 16:27:33 +02:00
Dmitri Ovodok
a38c3d3fd5 Fix spanners memory leak 2019-03-19 12:26:12 +02:00
Dmitri Ovodok
c88444aff8 fix imageStore memory leak 2019-03-19 12:25:33 +02:00
anatoly-os
8d4160f8c6
Merge pull request #4794 from mattmcclinch/285888-remove-horizontal-frame
fix #285888: Crash on removing a horizontal frame twice
2019-03-15 17:23:55 +02:00
anatoly-os
bce3db5923
Merge pull request #4786 from dmitrio95/283545-hbox-remove-undo
fix #283545: fix a crash on undoing HBox removal, fix boxes linking in parts
2019-03-15 17:21:42 +02:00
Joachim Schmitz
40f944c331 fix MSVC compiler warnings
and a MinGW warning too.
Don't cache (old) mingw dependencies on AppVeyor
2019-03-14 10:00:51 +01:00
Peter Hieu Vu
8e51cf2743 fix improper use of validScores 2019-03-13 08:51:17 -07:00
Matt McClinch
9d3b5e7a76 fix #285888: Crash on removing a horizontal frame twice 2019-03-13 09:40:22 -04:00
Dmitri Ovodok
90940d634a fix #283545: fix a crash on undoing HBox removal, fix boxes linking in parts 2019-03-12 14:19:29 +02:00
James Thistlewood
7bcdd135fc follow up single-note dynamics: add some forward declarations 2019-03-04 17:56:11 +00:00