Commit graph

26191 commits

Author SHA1 Message Date
Elnur Ismailzada
c50fd5c2f2
Merge pull request #12282 from HemantAntony/12052-add_fret_number_property
Fix #12052: Added Fret number to fret properties
2022-07-06 12:54:26 +03:00
Michele Spagnolo
f362f3ff06 utest fixes 2022-07-06 10:37:16 +02:00
Michele Spagnolo
1c32a01e97 fix stem side positioning of staccato and tenuto
refinement
2022-07-06 10:37:16 +02:00
Michele Spagnolo
bd6593165f changed default values
change default values


correction


correction


correction
2022-07-06 10:37:16 +02:00
Michele Spagnolo
a7561a297f positioning corrections
positioning corrections


correction


correction
2022-07-06 10:37:16 +02:00
Michele Spagnolo
e2423df9ac exposing additional option
renaming
2022-07-06 10:37:16 +02:00
Michele Spagnolo
ff5be66947 renaming/refactoring 2022-07-06 10:37:16 +02:00
RomanPudashkin
3a955b012d
Merge pull request #12274 from cbjeukendrup/text_dotted_lines2
More improvements for Text Lines
2022-07-06 10:45:47 +03:00
RomanPudashkin
9197462362
Merge pull request #11836 from asattely/tremolo-stem-direction
Tremolo stem direction fix
2022-07-06 10:39:51 +03:00
HemantAntony
586c0a53df Fix #12052: Added Fret number to fret properties 2022-07-06 11:23:46 +05:30
Aaron Sattely
b429eabc3b Add new utest for flipping of tremolos
This is included in beam tests, because eventually beams will be refactored such that all of the positioning logic for them will be extracted out for use in both trems and beams.

Thanks to @HemantAntony for noticing the problem with the utest! I elected to just change the test rather than the functionality of the production code. More info in the PR
2022-07-05 20:50:55 -04:00
Aaron Sattely
95e66ea117 fix a mistake regarding explicit stem direction and staffMove 2022-07-05 20:46:44 -04:00
Aaron Sattely
2ee7b5dea7 fix tremolo musicxml utests 2022-07-05 20:46:44 -04:00
Aaron Sattely
e39b5279e9 Tremolo stem direction fix 2022-07-05 20:46:43 -04:00
Casper Jeukendrup
2ac9f7f684
VTests: slightly increase resolution 2022-07-05 18:43:47 +02:00
Casper Jeukendrup
206da319dc
VTests: add GIF images for easy comparison 2022-07-05 18:43:47 +02:00
Casper Jeukendrup
65704b3cca
Update default alignment of ottava text 2022-07-05 18:43:47 +02:00
Casper Jeukendrup
7a24a6220d
Improve calculation of Shape of TextLineBase 2022-07-05 18:43:46 +02:00
Casper Jeukendrup
c57297c18f
Super smart drawing of hooks for dashed TextLines
For solid lines:
- we can just draw the line as a polyline, so that the corners will always look perfect (except for T-hooks, those need to be drawn separately)

For dashed lines:
- for each line piece individually, we want the dashes to be distributed over the length of that line piece, so we draw each piece individually.
- for the dashes themselves, we want to use FlatCaps (otherwise, the dashes take more space than specified relative to the gaps), but for the 90° and 45° hooks, the line needs to be extended (as happens with SquareCaps) for the corners to look neat. For non-acute angles, we can do make it look perfect by extending the lines slightly further based on the angle between them. For acute angles, such trick does not exist, so those will look as bad as in MU3. Fortunately, those are much less common (only occur when using crazy steep diagonal textlines).

For dotted lines:
- Again, we want to distribute the dots for each linepiece separately.
- The dots are drawn by drawing very short dashes with round caps. Thus, since we distribute the dots, the outer dots will be circles centered around the start and end points of the line.
- Because the end point of one linepiece will coincide with the start point of the next, we don't need to extend the lines.
2022-07-05 18:43:46 +02:00
DmitryArefiev
8bc7119988
Merge pull request #12266 from Eism/tootlips_crash_fix
fixed #12249: Correct parent setting for tooltips
2022-07-05 19:43:32 +03:00
RomanPudashkin
0bdb9db2c6
Merge pull request #11904 from cbjeukendrup/text_dotted_lines
Improvements for Text Lines
2022-07-05 19:33:29 +03:00
DmitryArefiev
b72554f8a2
Merge pull request #12267 from Eism/slur_destruction_crash_fix
fixed #12205: Correct parent for slur
2022-07-05 19:09:00 +03:00
RomanPudashkin
b78ce97196
Merge pull request #12272 from Eism/shortcuts_macos_fix
fixed #12271: Fixed shortcuts with Num modifiers
2022-07-05 16:19:00 +03:00
Alexander Pavlov
81910363e5
Merge pull request #12276 from alexpavlov96/linked_staff_assert_fix
fixing spanners cloning
2022-07-05 15:05:46 +03:00
Alexander Pavlov
bff0731516 fixing spanners clonning 2022-07-05 14:37:36 +03:00
Casper Jeukendrup
5507e67fc6
Fix issue where selecting pedal changes visibility of line
Due to a mistake in the code for loading the Inspector model, the element would be modified, instead of that just the Inspector was updated.
2022-07-05 11:55:32 +02:00
Casper Jeukendrup
9366558637
Fix cases where TextPlace properties were not initialized properly 2022-07-05 11:55:31 +02:00
Casper Jeukendrup
296fa19b9c
No need anymore to offset text for textlines by default by a fixed amount
Now that the text is aligned correctly with the line automatically
2022-07-05 11:55:31 +02:00
Casper Jeukendrup
d9c19c6207
Text lines: align baseline of text with bottom of line
instead of with center of line
2022-07-05 11:55:31 +02:00
Casper Jeukendrup
caf79fe8ea
Text lines: miscellaneous optimizations to layout code 2022-07-05 11:55:30 +02:00
Casper Jeukendrup
c3d956ca34
Optimize drawing hairpins
Avoid unnecessary calculations if there is no niente circle
2022-07-05 11:55:30 +02:00
Casper Jeukendrup
a004eb05a9
Don't show a pointless aperture grip for line crescendos
Only makes sense for hairpins
2022-07-05 11:55:29 +02:00
RomanPudashkin
8e1ff2744b
Merge pull request #12264 from cbjeukendrup/fix_autoplace_upward_hook
Fix autoplacing text lines with hooks pointing upward
2022-07-05 11:39:12 +03:00
Alexander Pavlov
5af38111e7
Merge pull request #12270 from alexpavlov96/linked_tab_creation
fixed creating of linked staff when importing from gp
2022-07-05 11:24:41 +03:00
Eism
0f8873345d fixed #12271: Fixed shortcuts with Num modifiers 2022-07-05 10:23:29 +03:00
Eism
fbaaff2788 fixed #12205: Correct parent for slur 2022-07-05 09:50:10 +03:00
Alexander Pavlov
8b21b5fde3 fixed creating of linked staff when importing from gp 2022-07-05 05:35:23 +03:00
RomanPudashkin
b70aa9b723
Merge pull request #12268 from cbjeukendrup/fix_palettes
Fix "More" popups in Palettes
2022-07-04 21:16:25 +03:00
Casper Jeukendrup
71fbc79044
Q_INVOKABLE and Q_PROPERTY types need to be fully qualified 2022-07-04 19:38:30 +02:00
Eism
8db7381a26 fixed #12249: Correct parent setting for tooltips
Button -> Loader -> popup
2022-07-04 19:36:54 +03:00
RomanPudashkin
c5006d5513
Merge pull request #11390 from Eism/change_workspace_fix
[MU4] Change workspace fix
2022-07-04 19:20:26 +03:00
Elnur Ismailzada
63392a52ac
Merge pull request #11858 from RomanPudashkin/parts_dialog_minor_tweaks
[MU4] Minor tweaks to Parts dialog
2022-07-04 18:04:05 +03:00
Casper Jeukendrup
b1ed77cb92
Fix autoplacing text lines with hooks pointing upward 2022-07-04 16:19:21 +02:00
RomanPudashkin
55b52ae626
Merge pull request #12103 from HemantAntony/12069-palette_rearrangement
Fix #12069: Co-location of palette elements
2022-07-04 16:51:40 +03:00
DmitryArefiev
eaef30cdb2
Merge pull request #12220 from cbjeukendrup/select_note_over_flag
Prefer selecting Note over Stem or Flag, and Stem over Flag
2022-07-04 15:28:35 +03:00
RomanPudashkin
f6d12d96eb
Merge pull request #12214 from asattely/beamlet-directions
Fix #10205: Beam groups calculation fix
2022-07-04 14:45:23 +03:00
Casper Jeukendrup
5a006a4f93
Merge pull request #10488 from sammik/key-sig-ledger-lines
Fix MS #314800 Add Ledger Lines to Key Signatures
2022-07-04 13:38:32 +02:00
Aaron Sattely
65956d2120 Fix issue with beamlets pointing the wrong way
This includes a bit of a change in the logic for determining beam groups in general. See PR for details
2022-07-04 07:07:50 -04:00
RomanPudashkin
88a5d41c5b
Merge pull request #10526 from njvdberg/issue-10034-automatic-bracketing
Automatic bracketing and instruments with multiple staves
2022-07-04 11:45:27 +03:00
RomanPudashkin
6f45ec9708
Merge pull request #12209 from HemantAntony/12188-disable_publish_to_musescore
Fix #11221: Make playhead cursor thinner
2022-07-04 11:25:58 +03:00