Commit graph

459 commits

Author SHA1 Message Date
Marc Sabatella
c7a85c05e2 fix #285811: don't make chord-based fingerings part of note shape 2019-05-09 22:46:58 -06:00
Marc Sabatella
6b7f33ec64 fix #278999, fix #288474: autoplace customization 2019-05-01 07:52:11 -06:00
Marc Sabatella
77c8f3de05 fix #283473: grace note after collides with accidental 2019-04-19 12:44:17 -06:00
Marc Sabatella
286a5285bb fix #282026: scale stem displacement 2019-04-11 06:36:32 -06:00
James Thistlewood
9b6bdd7a7f fix #282698: undoing timesig change with tremolo causes crash 2019-03-05 11:52:59 +00:00
Marc Sabatella
bda0dd2345 fix #280428: tab beams added to skyline 2019-02-19 15:48:14 -07:00
anatoly-os
9202c93aa8
Merge pull request #4658 from MarcSabatella/283732-grace-articulation
fix #283732: articulations not laid out on grace notes
2019-02-18 20:09:56 +02:00
ws
ec3be9a99a Replacd integer midi tick values by fractions.
- tick names a position on the time axis
- tick is always a Fraction()
- only Measure() and Segment() (and Tuplet?) have a tick value
- tick() for an generic element return only a sensible value if isMeasure() or isSegment() or isSegment(parent())

- "ticks" names a duration stored in a Fraction()
- the tick value for an Segment is relative to its measure

- rename "duration" to "ticks"
- rename afrac() to tick()
- rename rfrac() to rtick()
- rename some variables, changing "fraction" into "tick"
  (example: actualFraction() into actualTicks())

- Lyrics ticks are written as Fraction, on read if xmlreader sees a "/" it reads a fraction
  else midi ticks for backwards compatibility
2019-02-18 11:46:05 +01:00
Marc Sabatella
558bfe0b4d fix #283732: articulations not laid out on grace notes 2019-02-15 13:25:38 -07:00
Marc Sabatella
300cfac6ed fix #283157, fix #283180, fix #283323: fingering layout glitches 2019-02-06 21:56:18 -07:00
MarcSabatella
8942ed8a7b fix #280807: improve fingering layout (for piano & guitar) 2019-01-27 08:44:42 -07:00
Marc Sabatella
bbbe1f68e8 fix #280677, fix #279643: semantics of disable autoplace on stems et al 2019-01-11 18:26:22 -07:00
anatoly-os
806e4d94dc
Merge pull request #4444 from dmitrio95/tremolo-crash-and-copypaste
fix #278964: rework duration types handling with tremolo
2018-12-21 16:03:34 +02:00
ws
483740b42e fix #280095 Crash on part generation in the presence of tremolos 2018-12-19 14:53:07 +01:00
Dmitri Ovodok
62f5d132bf fix #280095, fix #278964: rework duration types hanling with tremolo 2018-12-19 15:42:47 +02:00
anatoly-os
2679d8639b
Merge pull request #4411 from MarcSabatella/279880-articulations-under-slurs
fix #279880: place articulations under slurs except at endpoints
2018-12-18 17:22:04 +02:00
MarcSabatella
aece90d578 fix #280160: images don't respect autoplace setting 2018-12-16 16:10:35 -07:00
MarcSabatella
0dd864d372 fix #279880: place articulations under slurs except at endpoints 2018-12-16 13:40:25 -07:00
Matt McClinch
9749d3a898 fix #279607: Place chord-anchored stem-side articulations at the end of the stem.
fix #279672: Staccato and tenuto overlap.
Do not center tenuto over the stem.
Only center staccato over the stem if it is the only articulation.
2018-12-13 08:41:55 -05:00
ws
fedb04b66e fix #279070 Measures with tremolo get wider and wider with each edit 2018-12-12 13:40:28 +01:00
Dmitri Ovodok
6e5de1926c fix #278940: restore chords spacing for glissando
This adds also a way to differentiate types of horizontal spacing.
The underlying implementation (zero-height shape elements) still
remains the same.
2018-12-05 16:34:35 +02:00
ws
6c5787c9b0 fix #278314 Tremolo positioned incorrectly for small chords 2018-12-03 12:41:51 +01:00
ws
a09bcb4bbb fix chord stem width for scaled staves 2018-12-03 12:41:51 +01:00
anatoly-os
751bd8a99e
Merge pull request #3968 from tobik/275706-articulations-at-voices
fix #275706: Place all articulations at stem side if direction and anchor is set to automatic
2018-11-24 18:12:26 +02:00
anatoly-os
7ca06db458
Merge pull request #4086 from mattmcclinch/277565-stem-length
fix #277565: Shortening notes too much leads to bad stem layout
2018-11-21 16:49:34 +02:00
ws
7077d96adb fix #275962 Stave distance widens if there is cross-arpeggio 2018-11-19 12:08:35 +01:00
Tobias Kretschmar
52ba935457 fix #275706 Place articulations at stem side if voices exists, else at note head but strong accents above staff. 2018-11-18 21:48:33 +01:00
Dmitri Ovodok
16507e6a5b fix #276378: fix Y layout of double articulations 2018-11-16 18:42:50 +02:00
anatoly-os
b95c4b7ef7
Merge pull request #4111 from mattmcclinch/277861-multiple-fermatas
fix #277861: Multiple fermatas added to chords
2018-11-14 23:05:50 +02:00
ws
d2e452040b fix #278099 Crash when inserting a symbol from master palette 2018-11-13 13:32:33 +01:00
Matt McClinch
992f322277 fix #277565: Shortening notes too much leads to bad stem layout 2018-11-11 16:05:02 -05:00
ws
1edd676aa7 fix #277699 Staff properties corrupted on MusicXML import after Master Palette opened
The problem is deep in the initialization of staff types in Staff.
This commit also tries to make handling of StaffType more "const correct" and adds some
assertions which may lead to crashes (and helps detecting bad code).
2018-11-08 15:50:00 +01:00
Matt McClinch
c8945379aa fix #277861: Multiple fermatas added to chords 2018-11-06 12:04:34 -05:00
ws
5540473361 Remove unused old code for ledger line collision detection.
Tune text offset on import from 2.x.
2018-10-30 16:57:26 +01:00
anatoly-os
77a86873bf Reverted afd4c432a5
Tests are broken because of changes in read206.
remove unused old code for ledger line collision detection
2018-10-30 16:49:13 +02:00
anatoly-os
e32ff8e44a
Merge pull request #3862 from dmitrio95/scorecmp_tool
GSoC 2018: Score comparison tool
2018-10-30 14:55:42 +02:00
ws
afd4c432a5 remove unused old code for ledger line collision detection 2018-10-30 12:18:24 +01:00
Dmitri Ovodok
c95dfd5a40 Make it possible to record elements written to MSCX 2018-10-29 16:30:19 +02:00
ws
c3a74f075e fix #275383; add ledger lines to chord shape 2018-10-27 20:53:31 +02:00
ws
96af32eee7 fix regressions: layout of misc. elements 2018-10-25 15:44:21 +02:00
ws
d77183b3bb refactoring of Element::userOff and TextBase::offset 2018-10-18 11:56:23 +02:00
Matt McClinch
7a9977123e fix #276441: Multiple articulations on a single note possible 2018-10-12 08:38:48 -04:00
anatoly-os
667aaffc76
Merge pull request #3995 from dmitrio95/convert-double-articulations
fix #276568 Convert double articulations
2018-10-11 21:31:07 -07:00
anatoly-os
5eaf97da89
Merge pull request #3958 from Jojo-Schmitz/MSVC-warnings
fix #275218: fix MSVC warnings
2018-10-11 21:29:43 -07:00
ws
88a789f83f remove manually placed articulations from skyline 2018-10-03 10:16:03 +02:00
Joachim Schmitz
fe50c85097 fix #275218: fix MSVC C4458 warnings
reg. a declaration shadowing a class member,
"Warning C4458: declaration of 'XXX' hides class member"
2018-09-27 17:38:20 +02:00
Dmitri Ovodok
41435b07bc fix #276568: Replace double articulations with proper SMuFL symbols for 2.X scores 2018-09-26 11:49:12 +02:00
ws
bb08200e10 fix autoplace for articulations 2018-09-12 10:51:08 +02:00
Joachim Schmitz
b27817fe19 fix more MSVC warnings
* The one C4100
* The one C4189
* The two C4457
* The two C4701
* The 475 C4267, changing to size_t were easily possible, casting to
int elsewhere
* Fix GCC warnings reg. wrong printf format for a size_t, reg. unused
variables and reg. ambigous else branch, seen on Travis CI
2018-09-11 16:56:50 +02:00
ws
b232149321 remove measure staff shapes, replace with skyline 2018-09-11 16:30:47 +02:00