Commit graph

76 commits

Author SHA1 Message Date
ws
33d1cd7fb4 rename StyleIdx -> Sid and P_ID -> Pid 2018-03-27 15:36:00 +02:00
Werner Schweer
f26ebf688f fix #268110 2018-01-04 12:41:42 +01:00
Werner Schweer
b46b55fa1e fix ties from/to grace notes; add 'final' to classes were appropriate 2017-12-21 14:08:44 +01:00
Werner Schweer
0e4211e2d0 update let ring, palm mute 2017-11-27 16:55:52 +01:00
Werner Schweer
8feb117936 change barline alignment & layout 2017-08-04 15:45:48 +02:00
divya-urs
28d4e39b05 accessibility: nextElement and prevElement 2017-07-13 23:52:00 +05:30
Werner Schweer
f80caadfe8 misc. layout fixes 2017-06-02 10:28:29 +02:00
Werner Schweer
131ffccb4a fix import of barline span 2017-05-29 14:59:26 +02:00
Werner Schweer
ac41fa396e update edit infrastructure 2017-03-31 13:03:30 +02:00
Werner Schweer
d435c3e5fc change barline alignment 2017-03-20 18:24:29 +01:00
Werner Schweer
297b66f6b6 barline fixes 2017-03-07 18:02:07 +01:00
Werner Schweer
90b1991912 replace Q_OBJECT with Q_GADGET for all Element based classes 2017-02-17 15:48:28 +01:00
Werner Schweer
73d097eec6 cleanup some header files 2017-01-19 09:17:21 +01:00
Werner Schweer
1d4c6b2f21 move Element::type() to ScoreElement 2017-01-18 14:16:33 +01:00
Werner Schweer
0b1aea952f layout for movements 2017-01-05 11:28:45 +01:00
Werner Schweer
9bbec943ad fix barlines in palette 2016-12-29 15:11:28 +01:00
Werner Schweer
62513977a0 misc. updates for barlines 2016-12-29 13:42:55 +01:00
Werner Schweer
22454df70e small fixes for save/restore barlines 2016-12-28 17:21:30 +01:00
Werner Schweer
1a52a38164 update BarLine, mtests 2016-12-28 16:36:59 +01:00
Werner Schweer
337e885896 barline changes, part-1 2016-12-28 16:36:59 +01:00
Werner Schweer
6e7e05aaec impl. staff type changes 2016-12-18 14:31:34 +01:00
Werner Schweer
c5f46bb208 rename Xml() -> XmlWriter() 2016-11-19 11:51:21 +01:00
Werner Schweer
f7d96502c3 update layout, change handling of clefs, system header and trailer 2016-10-25 17:35:55 +02:00
Nicolas Froment
c38fa998fc Merge pull request #2664 from heuchi/plugin-barlinetype-new
expose class BarLine with property barLineType to QML
2016-06-23 14:29:59 +02:00
werner
64034e6172 inspector update for barlines & clefs 2016-06-13 17:39:10 +02:00
heuchi
d876d2fc98 expose class BarLine with property barLineType to QML 2016-06-10 23:29:35 +02:00
werner
3b3b0d1dbb fix #110881 barline editing handled incorrectly 2016-06-10 10:30:34 +02:00
ws
84cf28089b fix some regressions, mtest 2016-04-13 11:38:08 +02:00
ws
dfe49b06ad barline cleanup 2016-04-13 11:18:15 +02:00
ws
492709f203 code cleanups 2016-04-13 11:10:17 +02:00
ws
3d8749ffe9 some regression fixes, code cleanups 2016-04-13 11:08:01 +02:00
ws
9f933d8503 Layout reorganization 2016-04-13 11:05:04 +02:00
lasconic
cebbef5cf5 fix barline translation in palette 2015-02-25 11:54:31 +01:00
ws
16764d4614 fix #44466: Crash extending volta over mmrest starting a new system + other cleanups 2015-01-19 12:41:16 +01:00
ws
729a788b44 fix #41591: mid bar barline spanning 2 staves doesn't stick accros save and crashes on delete 2014-12-18 13:21:29 +01:00
Werner Schweer
e4e377a36b Merge pull request #1316 from mgavioli/system_initial_barline_style
Style of the initial bar line of a system.
2014-12-08 13:03:03 +01:00
Joachim Schmitz
a6abbf7f92 add bar line subtypes to the selection dialog 2014-11-06 23:08:50 +01:00
Maurizio M. Gavioli
5621af1c2b Style of the initial bar line of a system.
In some engraving styles (mainly jazz), a double system initial bar line is used at structural articulations of the piece.

The PR supports this style, by adding a `_systemInitialBarLineStyle` variable to the `Measure` class which controls the style of the system bar line when the measure is the first of the system and by default it is set to NORMAL. This variable is not accessed directly; rather it is controlled by manipulating the system bar line. A system bar line can be edited:

- by dropping on it a bar line style from the palette (structural styles, like any repeat or END are ignored);
- by selecting it and double clicking a bar line style from the palette (same note as above).

It can be reset:

- by undo;
- by dropping on it (or selecting and double clicking) a NORMAL bar line style from the palette;
- by selecting and deleting it.

As the system bar line style is stored in the measure, if the first measure of a system changes (because of some other editing), the system bar line style will follow accordingly.
2014-09-16 13:20:15 +02:00
Maurizio M. Gavioli
210fe4c3d2 Add default value for BarLine::updateGenerated() 2014-09-07 21:08:37 +02:00
Maurizio M. Gavioli
91e88fe9fa Bar lines: fixing custom type and generated management
There are some inconsistencies in the current management of bar line `_generated` flag and user-modified type:

- Bar lines created by the New Score Wizard are flagged as non-generated, as well as bar lines of measures manually **appended** by the user, while bar lines of measures **inserted** are flagged as generated.
- If a generated bar line is individually changed of typed, it remains flagged as generated, it is not saved and the change is lost upon saving and re-loading.
- The management of the internal flag `BarLine::_customSubtype` is not always consistent.
- The `Measure::_endBarLineGenerated` flag was not always restored properly by undo.

This PR introduces the following fixes:

- The `_generated` flag is consistently used for bar lines whose type can be reconstructed from the context and then do not need to be saved to the output file.
- Normal bar lines are **always** created as generated: initially created by the Wizard, manually appended or inserted.
- Bar lines with custom type (i.e. different from the type which can be expected according to the bar line context) are always flagged as non-generated, ensuring the custom type is written to the output file.
- The `Measure::_endBarLineGenerated` flag is stored by `ChangeEndBarLineType()` and restore upon undo.
- Some test reference scores, based on the inconsistent bar line `_generated` flag, have been uniformed.

Notes:

- Tests about measure (and then bar line) appending, inserting and relative undo's are already included in the `tst_parts` test suite.
- Some inconsistencies remain in the management of custom bar line span and of system-initial bar lines: for the sake of simplicity, they will be dealt with in separate PR's.
2014-09-06 10:36:35 +02:00
Andrei Tuicu
6460485d3f Score accessibility system.
Provides screen-reader feedback for the selected element.
2014-08-19 00:09:13 +03:00
Andrei Tuicu
9caa98b130 Added 4 new navigation commands:
- next element
- previous element
- first element
- last element
2014-08-17 17:25:21 +03:00
ws
6d46589c56 fix #29431 2014-08-13 21:01:21 +02:00
Maurizio M. Gavioli
284d8b5ca8 Bar line inspector consistency for span data
- Selecting a built-in span type updates other span values
- Added a check function enforcing correctness and consistency of span data (Span, From, To); it also set spin box mins and maxes to avoid meaningless values (like From below To and so on)
- Removed array of built-in span type data; span type are different enough to make a table useless: ad-hoc code is needed for most of them.
- Removed legacy, commented-out code
- Set mins for span value spins in .ui
- A few typos here and there
2014-07-26 10:51:07 +02:00
Maurizio M. Gavioli
2ac9bf5a98 Improve bar line Inspector and Palette
**Inspector**
- Align span combo item names with palette names
- Add a [Custom] span item: it is informative only, cannot be selected and is set by the Inspector for spans which do not match any built-in span
- Implement proper selection of span combo item when a bar line is selected in the score
- Enable/disable type combo items according to bar line type (repeats cannot be turned on/off for individual bar lines)
- Implement spanTypeActivated() to set in the score the span selected in the Inspector

**Palette**
- Labels for styles and spans made clearer (hopefully...)
2014-07-20 00:56:14 +02:00
ws
b70f9b8766 partial fix for #23324 2014-06-27 14:03:17 +02:00
Joachim Schmitz
75623c53dc move ElementType to Element::Type
needed to make it available to the Plugin framework
2014-06-26 11:57:35 +02:00
Joachim Schmitz
931e837c5e convert enum ElementType into enum class 2014-05-23 10:35:27 +02:00
lasconic
ecd6222e20 fix #22917: Dragging bar lines to top or bottom staff lines requires extra precision 2014-04-08 10:42:25 +02:00
ws
6ea46108d9 more code for inspector+barlines 2014-03-24 11:51:03 +01:00