Commit graph

25082 commits

Author SHA1 Message Date
Casper Jeukendrup
9c9c4ec037 Simplify creating Promises
Less typing, less reading

We can now make this `auto` simplification because we give the compiler information about the expected type of the promise body.
2022-03-31 14:17:22 +06:00
Casper Jeukendrup
112d29d931 Enforce that Promise body resolves OR rejects exactly once
We now enforce that the body of a promise returns a "Result" struct. Such a struct can only be obtained by calling "resolve" or "reject".
Additionally, if you call "resolve" or "reject" without using its result, `Q_REQUIRED_RESULT` will kick in and give you a compiler warning. So you either have to return it (which you should do), or you use it in another way, which is impossible to do unconsciously.

The only disadvantage is that you now have to write `return resolve` etc. instead of just `resolve`, but the advantages are bigger.
2022-03-31 14:17:22 +06:00
Casper Jeukendrup
f57078bca1 Simplify getting single arg from NotifyData 2022-03-31 14:17:22 +06:00
RomanPudashkin
81e70ebc62
Merge pull request #10978 from cbjeukendrup/fix_more_tie_crashes
Fix more tie crashes
2022-03-31 10:07:30 +02:00
RomanPudashkin
ffcb7857f4
Merge pull request #10996 from cbjeukendrup/fix_error_messages
Fix some debug/error messages that were printed to the console
2022-03-31 10:04:36 +02:00
RomanPudashkin
2b93e8afca
Merge pull request #10988 from cbjeukendrup/select_nothing_on_start
Nothing should be selected on the score when a new score is created, or an existing score opened
2022-03-31 10:00:40 +02:00
RomanPudashkin
67639703a9
Merge pull request #11000 from cbjeukendrup/editstyle_fix_pages_order
Fixes for Edit Style dialog
2022-03-31 09:58:17 +02:00
Casper Jeukendrup
d78c6f9227
Fix keyboard shortcut for full screen
- Remove "Meta+Ctrl+F" for non-macOS platforms, where it is not common
- Make it the primary shortcut on macOS, where it is standard
2022-03-31 00:13:20 +02:00
Casper Jeukendrup
b1790a06e7
Fix drawing checked flat QPushButtons 2022-03-30 23:57:58 +02:00
Casper Jeukendrup
47f6b05774
Remove the ability to change the order of the pages in the Edit Style dialog
This feature is only confusing, and did not work reliably.

Fixes https://github.com/musescore/MuseScore/issues/10755
2022-03-30 22:56:02 +02:00
Casper Jeukendrup
91af9ebb76
Fix warnings like "QPainter::font: Painter not active" 2022-03-30 22:38:28 +02:00
Casper Jeukendrup
999bb0d38f
Fix error messages about invalid property of Dynamic 2022-03-30 22:03:06 +02:00
Casper Jeukendrup
74cdd015b5
Fix error messages about mismatching property types 2022-03-30 22:03:06 +02:00
Casper Jeukendrup
5c47b2c380
Fixed navigation focus border in NotationSwitchButton.qml 2022-03-30 20:00:35 +02:00
Casper Jeukendrup
58477d535f
Give the NotationView a navigation focus border 2022-03-30 20:00:14 +02:00
Casper Jeukendrup
42dd58d55b
Don't select any element when opening or creating a score 2022-03-30 19:59:48 +02:00
Roman Pudashkin
2c709d7936 fix #10973: fixed measures width in the linear mode 2022-03-30 17:56:22 +02:00
Casper Jeukendrup
0a8cd32c36
Fix crashes related to slur starting/ending on rest instead of chord 2022-03-30 16:00:08 +02:00
Casper Jeukendrup
8cce5a7fc3
Fix more tie crashes (typos) 2022-03-30 15:53:10 +02:00
RomanPudashkin
badec98f02
Merge pull request #10789 from cbjeukendrup/flat_button_size
Fix the size of FlatButton
2022-03-30 15:14:30 +02:00
RomanPudashkin
56544c8df7
Merge pull request #10960 from cbjeukendrup/fix_scrolling_instrumentspanel
Fix scrolling in the Instruments panel
2022-03-30 11:41:17 +02:00
Casper Jeukendrup
f0043ec222
Fix scrolling in the Instruments panel 2022-03-29 23:09:28 +02:00
RomanPudashkin
7a5c5ac8cd
Merge pull request #10944 from Jojo-Schmitz/default-user-dir
[MU4] Fix user dir default to "MuseScore4" or "MuseScore4Development"
2022-03-29 22:10:12 +02:00
RomanPudashkin
6bad5544c8
Merge pull request #10949 from cbjeukendrup/follow_system_theme_checkboxes
Fixes for "Follow system theme" checkboxes - again
2022-03-29 22:06:40 +02:00
Casper Jeukendrup
66b86a4996
Fixes for "Follow system theme" checkboxes - again
Fix spacing in Preferences dialog and bring back the one in the Getting Started dialog, also with improved spacing
2022-03-29 19:41:32 +02:00
Igor Korsukov
e92e3a18ba update timeserver for win on CI again 2022-03-29 22:28:45 +06:00
Igor Korsukov
cb67149eff Merge branch 'master' of github.com:musescore/MuseScore 2022-03-29 22:07:58 +06:00
Igor Korsukov
2794635b20 update timeserver for win on CI 2022-03-29 22:07:00 +06:00
Igor Korsukov
68bb73e32f updated win cert 2022-03-29 21:36:12 +06:00
pereverzev_v
97bd99cd8e Ensure that we're processing only active plugins 2022-03-29 16:54:43 +02:00
vpereverzev
0ec35cc02c Accessing next segment for fermata calculations, even if segment belongs to next measure 2022-03-29 16:42:51 +02:00
Joachim Schmitz
52ccb310aa Fix user dir default to "MuseScore4" or "MuseScore4Development"
or whatever the `applicationName()` is going to be,
for it to not collide with the default user dir of MuseScore 1.x
2022-03-29 16:23:06 +02:00
vpereverzev
58d41d3af9 Fixed an issue with wrong calculations of pauses duration 2022-03-29 15:09:22 +02:00
Igor Korsukov
a8db35f1c0 updated win cert on CI 2022-03-29 17:29:34 +06:00
RomanPudashkin
25dc4b79d1
Merge pull request #10824 from cbjeukendrup/solo_mute
Fix solo/mute interactions in Mixer
2022-03-29 11:20:09 +02:00
Casper Jeukendrup
4bf4b19067 Fix a crash with some scores containing ties 2022-03-29 10:43:28 +02:00
RomanPudashkin
15b03570e5
Merge pull request #10928 from Eism/open_popups_fix
fixed #9658: Resolve current screen for popups by parent item
2022-03-29 09:32:05 +02:00
Eism
4c36053469 fixed #10871: close popup if user clicked elsewhere on the UI than notation view 2022-03-28 21:34:13 +02:00
RomanPudashkin
691bac858a
Merge pull request #10937 from Eism/navigation_app_menu_fix
[MU4] Separated the handling of app menu navigation into shortcut override and key press
2022-03-28 21:02:38 +02:00
RomanPudashkin
9632eba372
Merge pull request #10936 from RomanPudashkin/not_checked_options
[MU4] Fix #10802: View>Toolbars: Playback Controls and Status bar items aren't checked when they are present in MU window
2022-03-28 20:15:28 +02:00
Michele Spagnolo
6cbe7cf6e1 utest fixes 2022-03-28 20:12:38 +02:00
Michele Spagnolo
07d99142dd Polyrythms improvement 2022-03-28 20:12:38 +02:00
Michele Spagnolo
c5d6b39622 Overall spacing improvement 2022-03-28 20:12:38 +02:00
Michele Spagnolo
75aba8fa27 Improved logic for controlling long notes spacing 2022-03-28 20:12:38 +02:00
Michele Spagnolo
79374d0349 Roll back acceptanceRange idea 2022-03-28 20:12:38 +02:00
pereverzev_v
108c46cc7c Properly release memory for vst plugin 2022-03-28 20:12:19 +02:00
Eism
4351d95224 Separated the handling of app menu navigation into shortcut override and key press 2022-03-28 20:04:26 +02:00
Roman Pudashkin
d6941195e0 fix #10802: fixed sending the notification about the opening status of some docks 2022-03-28 19:49:01 +02:00
Casper Jeukendrup
b899339d3f
Fix solo/mute interactions in Mixer 2022-03-28 19:48:32 +02:00
Eism
96ebdcc4f4 fixed #9658: Resolve current screen for popups by parent item 2022-03-28 19:20:57 +02:00