Commit graph

6477 commits

Author SHA1 Message Date
lasconic
cf9fc61f0a Fix #273963: Use slash rather than 'QDir::separator()' for pathnames 2018-07-10 15:27:01 +02:00
Nicolas Froment
5f9fde47a7
Merge pull request #3741 from lasconic/fix-extension-master
fix #273032: implement packages to install soundfont, templates, etc.
2018-07-10 15:08:14 +02:00
anatoly-os
d7c7ce0a57
Merge pull request #3284 from tomcucinotta/dockable-play-panel
Make Play Panel dockable and floatable.
2018-07-10 09:32:33 +02:00
anatoly-os
86fe6e860f fix #273837: unable to install MDL on linux
The reason is believed to be a missed delimiter in the tmp directory.
2018-07-09 18:59:09 +02:00
lasconic
02863effb4 add ability to not set soundfont as default when extension installed from command line 2018-07-09 18:59:09 +02:00
lasconic
47660d8daa add -E command line option to install extensions from the command line and quit 2018-07-09 18:59:09 +02:00
IsaacWeiss
f7f28ee0e4 Better text for extension update message 2018-07-09 18:59:09 +02:00
anatoly-os
6bbd9f1de8 Make extensions installation steps async
Blocking UI leads to "not responding" state of the application.

fix application hanging when loading sfs on startup
2018-07-09 18:59:09 +02:00
lasconic
fdf55e1a2f fix #273558: Add a way to uninstall extensions 2018-07-09 18:59:08 +02:00
anatoly-os
b8d0b9ebc3 Check extensions update daily, not each MuseScore startup 2018-07-09 18:59:08 +02:00
lasconic
5934f7f15f fix #273525: Crash on template search 2018-07-09 18:59:08 +02:00
anatoly-os
4ef682a60b Add more messages to identify the problem when installing packages
Show message while unpacking and loading sfzs
2018-07-09 18:59:08 +02:00
lasconic
94d5442272 fix #273032: Provide an easy way to install soundfont, templates, etc.
Add workspace support in extension.
Use constants instead of magic strings for extension directories
2018-07-09 18:59:08 +02:00
anatoly-os
9ed730e768 fix #273032: provide easy way to destribute soundfonts, templates, etc.
Continue implementing extensions.
Add installed extensions version check and update on MuseScore sturtup, add the
related setting in preferences.
2018-07-09 18:59:08 +02:00
lasconic
37223aaa8e fix #273032: Provide an easy way to install soundfont, templates, etc.
Add soundfonts automatically to default synth settings after
installation is complete
2018-07-09 18:59:08 +02:00
lasconic
f71c339094 fix #273032: Provide an easy way to install soundfont, templates and instruments.xml
Introduce extensions files aka .muxt. These files are archives with additional data to extend MuseScore with soundfonts, templates, custom workspaces, etc.

Update qzip to fix bug with symlink.
Add extensions management to resource manager.
2018-07-09 18:59:08 +02:00
alexandr
380e21241b fix #274026 Unable to save synth settings in two scores in the same session
Easy fix. Buttons 'save/load to Score' always become enable when user click on another score.
2018-07-07 14:22:38 +02:00
anatoly-os
d95727bfcf
Merge pull request #3780 from handrok/Augmentation-dot-issue
fix #273606: Augmentation dot button is not disabled
2018-07-07 11:06:42 +02:00
anatoly-os
c86296853d
Merge pull request #3785 from Jojo-Schmitz/QDir--separator()
Fix #273963: Use `"/"`  rather than `QDir::separator()` for pathnames
2018-07-07 11:04:53 +02:00
Matt McClinch
6c1836495e fix #273973: Playback cursor disappears after splitting then restoring the display 2018-07-05 08:59:57 -04:00
Joachim Schmitz
a96dfec86a Fix #273963: Use "/" rather than QDir::separator() for pathnames 2018-07-05 08:38:23 +02:00
ws
175d5aadb3 cleanup ElementFlags interface, use more Placement properties on mxml import/export 2018-07-04 12:41:14 +02:00
Unknown
41cb77a5f8 fix #273606: Augmentation dot issue
Remove excessive statement in MuseScore::changeState(ScoreState val)
2018-07-03 14:15:29 +02:00
Matt McClinch
daa4802f33 fix #89016: Disappearing dots
Use NoteDot for the dots after rests, instead of the rest drawing its own dots, which were drawn outside of the rest's bbox.
2018-06-29 17:22:24 -04:00
Joachim Schmitz
2b0dd1e6cc Fix #273660: MIDI Keyboard not responding when pressed before opening a score 2018-06-28 14:04:29 +02:00
ws
d639d7e4ea update 2.x import 2018-06-27 09:04:22 +02:00
anatoly-os
6f17e43ca6 avoid MuseScore update checking for packagers
See https://github.com/musescore/MuseScore/pull/3742
2018-06-25 20:02:18 +02:00
anatoly-os
d99b2a71b0 Merge pull request #3757 from Jojo-Schmitz/prefs-align
Right align "Double augmentation dot" in preferences dialog. See https://github.com/musescore/MuseScore/pull/3757
2018-06-25 09:46:43 +02:00
Joachim Schmitz
18b86cf23a Fix #271103: Add 7-string Guitar and Cavaquinho (4-string Guitar)
also tablature for both, the former needs a 7-string tablature type, so
appended that, also inserted missing 5-string types to the StaffTypes
enum and appended a 8-string tablature, as GuitarPro has that too.

See also https://musescore.org/en/node/271096

Don't show presets for more strings than the instrument is set up for

esp. counting only fretted strings, i.e. non-open strings
2018-06-24 10:32:44 +02:00
lasconic
4cfbc04ca2 fix crash in MusicXML import when drumset instrument has no midi-unpitched 2018-06-22 15:43:33 +02:00
ws
7321a3a7b5 fix #272377 Follow text is not applied to tempo text 2018-06-20 10:59:30 +02:00
lasconic
440b0a2ee8 pick language updates in resource manager from MuseScore 2.3 2018-06-20 09:33:39 +02:00
ws
01b96ac8ed fix #272362 New character starts in the middle of the underline in lyrics 2018-06-19 13:39:20 +02:00
ws
a70b7fd289 fix #272631 Incorrect text edit bounding box if missclick the lyrics block 2018-06-19 09:37:49 +02:00
ws
6134145db5 fix #273375 Editing/entering chord symbol leads to program crash 2018-06-18 10:51:26 +02:00
ws
be40742eed fix #272630 Entering '_' and '-' as symbols doesn't work in lyrics 2018-06-15 14:03:18 +02:00
ws
db8474cb32 fix harmony editing 2018-06-15 11:25:47 +02:00
ws
b43073c0c7 update for lyrics editing, harmony editing 2018-06-14 10:20:45 +02:00
anatoly-os
93a63c64b3
Merge pull request #3718 from mattmcclinch/273305-courtesy-clef
fix #273305: Courtesy clef hide/show issue
2018-06-14 09:22:45 +02:00
anatoly-os
e1657633fc
Merge pull request #3717 from Jojo-Schmitz/warning
Avoid compiler warning reg. unused parameter
2018-06-13 10:40:27 +02:00
Matt McClinch
6c2b78c0bc fix #273305: Courtesy clef hide/show issue 2018-06-12 13:27:44 -04:00
ws
652eb73895 another fix for #272632: Crash when advancing lyric 2018-06-12 09:39:21 +02:00
Joachim Schmitz
70a72098f4 Avoid compiler warning reg. unused parameter
introduced with 5c651e3
2018-06-12 09:37:46 +02:00
ws
5266235324 fix #272365 Selecting text with mouse doesn't work 2018-06-11 17:00:53 +02:00
ws
5c651e301b fix #272632 Crash when advancing lyric 2018-06-11 15:54:58 +02:00
ws
d1d6da2942 do not allow dragging of toplevel horizontal frames 2018-06-11 09:13:09 +02:00
ws
d5d51b2d81 fix support for input method event (CJK) 2018-06-09 16:24:03 +02:00
ws
7ddf9d66f1 fix typo in last commit 2018-06-08 18:31:36 +02:00
ws
2c012a23d4 fix #210116 Delete all and Undo duplicates the clef 2018-06-08 18:25:56 +02:00
anatoly-os
5182e97a6d follow up 335bd4ed08
el() is nullptr when starting MuseScore.
2018-06-06 16:49:08 +02:00
Nicolas Froment
5d15476730
Merge pull request #3705 from Soerboe/more.prefs.to.new.model
Move two more prefs to new preferences model
2018-06-05 23:12:36 +02:00
Nicolas Froment
335bd4ed08
Merge pull request #3707 from mattmcclinch/272595-update-inspector
fix #272595: Inspector not updating properly leads to crash
2018-06-05 22:55:58 +02:00
Nicolas Froment
f697bdb038
Merge pull request #3706 from Soerboe/273080
fix #273080 - Visible mixer with no score leads to instant crash on s…
2018-06-05 22:35:04 +02:00
Matt McClinch
e5aa1d3751 fix #272595: Inspector not updating properly leads to crash 2018-06-05 15:14:58 -04:00
Dag Henning Liodden Sørbø
c6fa1ea1f7 fix #273080 - Visible mixer with no score leads to instant crash on startup 2018-06-05 20:19:35 +02:00
Dag Henning Liodden Sørbø
eb7d112b52 Move two more prefs to new preferences model 2018-06-05 19:32:43 +02:00
Joachim Schmitz
ce936d608a Fix #273066: Crash in converter mode
after 064156c
2018-06-05 11:56:39 +02:00
anatoly-os
061a51b593
Merge pull request #3556 from mattmcclinch/270458-repitch-to-rest
fix #270458: Re-Pitch a note to a rest.
2018-06-02 18:20:38 +02:00
ws
6a4bcb2dd1 fix #272379 Incorrect empty rectangle for rehearsal marks 2018-06-01 12:22:39 +02:00
ws
b0c317c717 fix #270381 Crash after using F2 to insert ü 2018-06-01 10:38:14 +02:00
Matt McClinch
8f5e5ca462 Allow the 0 key to toggle the Rest toolbar button in Rhythm entry mode 2018-05-31 00:43:38 -04:00
Dag Henning Liodden Sørbø
064156c267 Adds an advanced preferences tab to prefsdialog
Adds logic and GUI to handle preferences without adding a separate widget to
prefsdialog. Changes within the application because of a preferences change still
needs to be handled separately in other parts of the code.

When adding a preferences there is the option whether to have the preference in
the advanced list or not. If not a separate widget must be added to prefsdialog.

Note: Enums are currently not supported (as there are no enums in the advanced
list as of now, but can be easily added.
2018-05-30 15:21:05 +02:00
ws
ec4964caee fix #272404 No text editing panel at the bottom when editing staff/system text 2018-05-30 14:24:28 +02:00
ws
973232d5bf fix #272845 crash on adding staff or system text 2018-05-30 11:30:27 +02:00
ws
1be45c2767 fix #272146 Ctrl+Arrow is not processed during text editing 2018-05-30 11:20:59 +02:00
ws
dc6624dbc7 fix #272374 Reset text to style crashes MuseScore 2018-05-29 09:45:09 +02:00
ws
6f6e86a03c fix #272366 There are no System Text properties 2018-05-28 14:20:53 +02:00
ws
2c612a8991 fix #272138 Incorrect symbol in text on undoing nothing 2018-05-25 11:59:29 +02:00
ws
24014b6b59 fix #232101 Inability to create new text lines in frames 2018-05-25 11:24:32 +02:00
ws
2c6b658729 change handling of undo/redo for text 2018-05-25 09:26:49 +02:00
lasconic
94b68b3588 fix #272687: Unable to select an SFZ playback for a drum instrument 2018-05-24 12:01:38 +02:00
Matt McClinch
24ccd3e355 fix #108201: Untick 'Show courtesy' for clefs does not work. 2018-05-22 07:25:48 -04:00
anatoly-os
e223087f45
Merge pull request #3681 from anatoly-os/NoteheadsDrumReview
follow up Custom Noteheads implementation

Place VDL symbols to the first place in custom comboboxes
Change design of the drumpalette a bit
Fix drumpalette show/hide logic
2018-05-21 16:34:01 +02:00
anatoly-os
83dda2337c Merge pull request #3684 from mirabilos/fix-debian-898757
fix crash when starting with piano open
Manually merged from 2.3, see https://github.com/musescore/MuseScore/pull/3684
2018-05-21 15:04:01 +02:00
Anatoly
fa17f01af0
Merge pull request #3685 from Soerboe/224121_crash_when_clearing_palette_when_filtered
fix #224121: Crash when clearing palette cell with filter active
2018-05-21 11:16:55 +02:00
anatoly-os
f707b96e93 follow up Custom Noteheads implementation
Place VDL symbols to the first place in custom comboboxes
Changed design of the drumpalette a bit
Fixed drawing stems in drumeditor preview and the palette
2018-05-21 10:53:02 +02:00
Dag Henning Liodden Sørbø
8498f907c2 fix #224121: Crash when clearing palette cell with filter active 2018-05-19 16:42:41 +02:00
anatoly-os
f440917ef5 fix #153691: drumtools palette not closing when switching between files
follow up acd86d5c50
2018-05-18 11:46:02 +02:00
Nicolas Froment
3e27b9554e
Merge pull request #3665 from Jojo-Schmitz/inspector_stem
Fix stem inspector's accessibility texts
2018-05-14 12:00:48 +02:00
Anatoly
762551066b
Merge pull request #3668 from anatoly-os/CustomNoteheadsFix
fix #271676: reading 2.3 files with custom noteheads
2018-05-14 10:25:40 +02:00
ws
94eaac8c67 fix #272058 Backward compatibility of previous versions files (1.2 and 1.3) 2018-05-14 10:07:56 +02:00
anatoly-os
c608f868b5 follow-up https://github.com/musescore/MuseScore/pull/3631
Fix read/write of drumset xml block
Fix inspector logic
2018-05-14 09:31:20 +02:00
Joachim Schmitz
9b8983ec2f Fix stem inspector's accessibility texts 2018-05-09 16:44:28 +02:00
Matt McClinch
2dda9403a1 fix #272153: Notes for transposing instrument are shown in concert pitch on piano control 2018-05-09 08:17:33 -04:00
ws
ef72a276e3 update Stem, inspector for Stem 2018-05-08 10:51:38 +02:00
Leon Vinken
124db5fd7e fix #272062 2018-05-07 21:57:27 +02:00
ws
d31cfd9885 add Stem to inspector 2018-05-07 19:05:49 +02:00
Nicolas Froment
d8797b930d
Merge pull request #3655 from Jojo-Schmitz/bitrate-master
Fix #272042: saved preferences override command line options
2018-05-07 11:52:42 +02:00
Nicolas Froment
3976fba585
Merge pull request #3656 from mattmcclinch/272066-canvas-position
fix #272066: Canvas improperly positioned when setting zoom level
2018-05-07 11:36:11 +02:00
Nicolas Froment
26e6cc5f8d
Merge pull request #3657 from Soerboe/268016-no-message-shortcut
Fix #268016 - No message on second keyboard shortcut already in use
2018-05-07 11:21:55 +02:00
Dag Henning Liodden Sørbø
4c417c1d86 Fix #268016 - No message on second keyboard shortcut already in use 2018-05-06 00:10:10 +02:00
anatoly-os
0214736c4c fix #271198: Add a more flexible way to choose noteheads in drumset for percussion instrument
Added "Custom" item to noteheads combobox, removed "invalid" item, set selection at the first tree element when opening the drumset editor, added interaction between custom noteheads group and notehead group combobox, fixed tab order.
Fixed drawing custom noteheads in preview window: Set cachedSymbol from current quarter note combobox value and added slot to update preview on chaning quarter value.
Fixed shadow note drawing: Apply specific notehead from drumset data.
2018-05-05 18:30:45 +02:00
Joachim Schmitz
7879427c77 Fix #272042: saved preferences override command line options
For master, here at least do the input check and update the usage
message.
2018-05-05 15:30:53 +02:00
Matt McClinch
f818c6fcd8 fix #272066: Canvas improperly positioned when setting zoom level 2018-05-05 06:30:19 -04:00
lasconic
6843d0a6ae fix #271198: Add a more flexible way to choose noteheads in drumset for percussion instrument 2018-05-05 12:22:08 +02:00
anatoly-os
4facafc468 fix #271529: incorrect stem position for some noteheads in layout
Implemented correct notehead bbox width and origin calculations. Fixed
note and chord stems, ledger lines, beams, dots, articulation, slur and chord positions.
2018-05-05 10:34:45 +02:00
ws
6c22a5dea1 fix #247761 Crash involving brackets and a font style change 2018-05-04 14:14:34 +02:00
ws
c47771b3e5 fix #260266 Crash in note entry mode when deleting a measure after toggle mmrests 2018-05-03 13:41:54 +02:00
ws
830eb65a8d fix #271828 Crash in note entry mode after undoing the removal of a linked staff 2018-05-03 11:27:10 +02:00
Matt McClinch
245a6aa13b fix #271935: Wrong voice button is highlighted after unsuccessful voice change 2018-05-02 07:55:38 -04:00
Nicolas Froment
636ff3f45a
Merge pull request #3647 from mattmcclinch/8808-limit-scroll-area-master
fix #8808: Add option to limit scroll area of the navigator and the score view
2018-04-30 16:25:45 +02:00
ws
af29311ec4 remove Element->_readPos 2018-04-30 16:08:25 +02:00
MarcSabatella
2f80f5f98b fix #117236: honor 'pan score' button during edits 2018-04-30 14:53:01 +02:00
MarcSabatella
6ea0b0e7bd more conservative canvas positioning when reaching margins in continuous view 2018-04-30 14:52:49 +02:00
MarcSabatella
90f28adf6d fix #271187: bad canvas position when operating near right margin with vertical stacking 2018-04-30 14:51:02 +02:00
JGreenlee
1c782ac34d fix #271717: Match the default tempo in New Score Wizard 2018-04-28 22:31:38 -04:00
Matt McClinch
375c91ca30 fix #8808: Add option to limit scroll area of the navigator and the score view 2018-04-27 11:31:00 -04:00
wschweer
903817537c remove code duplication: LinkedStaves 2018-04-27 13:29:39 +02:00
wschweer
9f3c2d69c4 fix #266011 Crash when editing bend after removal of a linked staff 2018-04-26 11:01:53 +02:00
lasconic
bbe8dace42 fix #271707: MusicXML export: crash when exporting hairpins 2018-04-26 10:06:01 +02:00
Nicolas Froment
31a7d6168f
Merge pull request #3641 from Jojo-Schmitz/xmlcrash
Fix #271606: xml file causes crash due to failed assertion
2018-04-26 10:02:38 +02:00
wschweer
6a1eb186bf fix #140016: Crash by selecting a time signature after splitting a measure 2018-04-25 17:02:52 +02:00
ws
10af232cb4 fix #149746 Undi actual duration change creates corruption 2018-04-23 11:46:25 +02:00
Joachim Schmitz
642b8d8be2 Fix #271606: xml file causes crash due to failed assertion 2018-04-21 15:20:54 +02:00
ws
b1a14fe7e0 small fix for editing linked staff text 2018-04-18 14:31:47 +02:00
Nicolas Froment
0603c9d393
Merge pull request #3627 from mattmcclinch/113846-shadow-note
fix #113846: Regression—shadow note appears in note entry with keyboard or piano keyboard
2018-04-18 11:00:37 +02:00
Nicolas Froment
91a313b3e3
Merge pull request #3628 from mattmcclinch/271325-piano-range
fix #271325: Adjusting a note outside the range of a piano causes a crash when the piano keyboard is visible.
2018-04-18 10:37:10 +02:00
ws
72950fca7a fix #251451 Crash when trying to add staff text to multimeasure rests 2018-04-18 09:45:20 +02:00
ws
27145ea9b3 fix #271258: Changing 9va-8vb for an Ottava in the Inspector leads to crash 2018-04-13 14:30:54 +02:00
ws
82699c7233 fix adjustment of system header gap in general style 2018-04-13 11:15:28 +02:00
Matt McClinch
915a9ecfc5 fix #271325: Adjusting a note outside the range of a piano causes a crash when the piano keyboard is visible. 2018-04-13 01:49:11 -04:00
Matt McClinch
85cd42e370 fix #113846: Regression—shadow note appears in note entry with keyboard or piano keyboard
fix #271147: Running playback from note input mode leaves phantom note in the score
2018-04-12 23:42:51 -04:00
ws
c88175f9b1 chordname/harmony fixes 2018-04-12 12:06:59 +02:00
ws
a819eb6ae9 fix #139271: some Radio buttons in General Style do not switch 2018-04-11 12:19:50 +02:00
ws
6d460f012b regression fixes for tuplet layout 2018-04-09 11:51:45 +02:00
Joachim Schmitz
8c4c22fd9f Workaround for corrupt clipboard in Windows no longer needed in Qt 5.9 2018-04-06 12:29:38 +02:00
Joachim Schmitz
550f6b948d Fix #271074: Image capture with transparent background empty when pasting into other programs on Windows
This reverts 9572faf374 (master) and bd068f7221 (2.2), the fix for issue
#209596, for Windows only, as Linux /and presumably(?) Mac) is not
affected by this.
2018-04-06 12:24:18 +02:00
Nicolas Froment
7281733dac
Merge pull request #3075 from ericfont/164151-UpdateExportPartsEnabled
fix #164151 Update enabled status of Export Parts upon add/remove parts
2018-04-05 14:47:21 +02:00
Nicolas Froment
ea4fde02be
Merge pull request #3602 from Jojo-Schmitz/play-panel-close-score
Fix #271039: crash when closing score after changing tempo in play panel
2018-04-04 20:07:54 +02:00
lasconic
62c6bbe497 fix display of part name in window title on Windows/Linux 2018-04-04 19:14:51 +02:00
lasconic
eaa7328ca3 use setWindowModified to display * in window title 2018-04-04 19:09:38 +02:00
lasconic
25410a15fa fix window title when displaying parts 2018-04-04 19:06:21 +02:00
Joachim Schmitz
22d6f438a2 Fix #271039: crash when closing score after changing tempo in play panel 2018-04-04 18:59:12 +02:00
Nicolas Froment
b48eab1c84
Merge pull request #3590 from rcombs/macos-title
Follow macOS platform conventions for window title and dirty state
2018-04-04 17:49:10 +02:00
Nicolas Froment
2cbc44ffdb
Merge pull request #3598 from mattmcclinch/234781-selection
fix #234781: Selection with Ctrl+click is broken by clicking on the canvas
2018-04-04 15:08:40 +02:00
Matt McClinch
d13fc57b20 fix #234781: Selection with Ctrl+click is broken by clicking on the canvas 2018-04-03 11:43:47 -04:00
Nicolas Froment
b7116220d2
Merge pull request #3593 from tomcucinotta/empty-build-type
tolerate empty CMAKE_BUILD_TYPE
2018-04-03 09:53:41 +02:00
Eric Fontaine
4d0b8c4211 help allow build without PortMidi 2018-04-03 09:51:59 +02:00
Tommaso Cucinotta
587296447d tolerate empty CMAKE_BUILD_TYPE 2018-04-02 23:27:00 +02:00
Rodger Combs
3aec04a0f3 Follow macOS platform conventions for window title and dirty state
This results in the window title displaying just the filename (including the
extension) and not the application name, as per platform convention.
To the left of the filename, an icon is displayed. This icon is draggable and
behaves as if you were dragging the file in Finder. It can also be right-
clicked to view the path hierarchy. This is not displayed when there is no
path for the current file (imported or created scores).

Additionally, the window's dirty state is kept synchronized with the current
tab. When the document is dirty, this results in a dot in the close button and
the window icon turning grey.
2018-03-31 00:23:13 -05:00
ws
33d1cd7fb4 rename StyleIdx -> Sid and P_ID -> Pid 2018-03-27 15:36:00 +02:00
ws
2580eb7a69 update for properties/styles 2018-03-27 14:40:45 +02:00
Nicolas Froment
0d5750685e
Merge pull request #3572 from shoogle/midi-pauses
fix #252201: playback holds during section break
2018-03-23 10:09:45 +01:00
ws
ee0b1b889d fix regressions 2018-03-22 13:17:22 +01:00
Peter Jonas
858cb5d852 fix #252201: playback holds during section break 2018-03-22 05:49:11 +00:00
ws
6969419cfc update subStyle implementation 2018-03-21 14:05:43 +01:00
ws
6c400f21dc add bendArrowWidth style 2018-03-21 14:05:43 +01:00
Peter Jonas
b33682292b Porting real-time bug fixes from 2.X into master branch. 2018-03-21 00:26:40 +00:00
Matt McClinch
80865845e8 fix #270458: Re-Pitch a note to a rest. 2018-03-19 10:51:57 -04:00
ws
c1be1e4ab5 bend: add stlye page, add lineWidth property + style 2018-03-19 10:58:33 +01:00
ws
974a388041 add LINE_WIDTH property to tuplet 2018-03-16 12:08:57 +01:00
ws
1a4bd0feb9 add tuplet shape to segment/measure shape; properties update 2018-03-16 10:58:31 +01:00
lasconic
4ad0dcbb14 fix #270360: [MusicXML import] Crash when trying to import tremolo on rest 2018-03-15 17:05:03 +01:00
ws
01da75509f update properties&styles 2018-03-15 11:52:34 +01:00
Leon Vinken
f18f6b9d2a prevent crash in MusicXMLParserPass2::notations() when cr is null 2018-03-12 21:49:11 +01:00
Leon Vinken
ba3d8adf9a fix #269948 - [MusicXML import] crash when importing single staff part referring to staff 2 2018-03-12 21:49:11 +01:00
Nicolas Froment
422efca1ad
Merge pull request #3530 from lvinken/255791-musicxml-relative-lyric-numbers-3
fix #255791 - [MusicXML import] use lyric number as relative instead …
2018-03-10 14:40:19 +01:00
Marc Sabatella
d541fbc173 fix double click with list selection 2018-03-10 12:52:01 +01:00
Leon Vinken
fdc0549cc9 fix #255791 - [MusicXML import] use lyric number as relative instead of as absolute line number 2018-03-10 11:02:03 +01:00
anatoly-os
cae320ecb0 Implemented caching signals to prevent not generated sound in case of framesBuff from PortAudio is too small
If we don't specify framesPerBuffer parameter in Pa_OpenStream, PortAudio will choose optimal value for particular callback call. It can vary from run to run even on the same hardware depending on available system resources.

While generating signal, interpolating and applying effects, we assume that framesBuffer contains more than minimal number of frames to generate envelope. BTW, it is not true. If framesBuffer is smaller, algos cannot generate correct sound and just keep silence.

I've implemented cache which keeps generated values from dsp algorithms and applies it step-by-step to buffer values from pa_callback. Cache is filled each time algos generate dsp values. If buffer frames are not enough to generate envelope, algos generate values for further calls and keep it in cache.

Required number of frames has been selected as a number of frames for one phase multiplying by number of phases. Actually, smaller numbers of this value generates good results, but it is better to keep it as max as possible to provide perfect sound.

Code changes:
 - Replaced C-like variables with std containers for comfortable debugging and better usage
 - Extracted similar code calls to separate methods
 - Implemented cache as std constainers, so also implemented convertion from std::vector to C-like float* to fill the pa buffer
 - Changed the logic of applying effects and interpolation, it is now possible to use them separately. This is required to fill effects several times after calculating the interpolation is finished.

Removed std::vector<float> to keep cache - process buff values on the fly. Performance is better, but still glitches on https://musescore.com/user/166080/scores/175421. BuffSize = 64 with my wired headphones.
2018-03-07 16:51:59 +02:00
Nicolas Froment
b097bf89ba
Merge pull request #3515 from jeetee/269603_unwind_RepeatList_followup
fix #269603, fix #148276 unwind followup especially with regards to DS having playRepeats enabled
2018-03-07 15:22:33 +01:00
Johan Temmerman
79d4227534 fix #148276 end Open Volta before next startRepeat as well
fix #269603 unwind followup especially with regards to DS having playRepeats enabled
2018-03-07 12:55:07 +01:00
Finley Lau
63e0492e4b fix #153691: drumtools palette not closing when switching between files 2018-03-06 18:37:56 -06:00
Nicolas Froment
4a9804ff2d
Merge pull request #3496 from finleylau/stringutils
fix #269467: added stringutils class
2018-03-02 15:24:53 +01:00
Finley Lau
6637bfaf39 Fix #269901: fixed segmentation fault within piano roll editor 2018-03-02 15:06:00 +01:00
anatoly-os
22237cdc7d Follow up for PR #3486
Optimized stateName method to avoid using local variable.
2018-02-28 12:30:25 +02:00
Nicolas Froment
f99613fe78
Merge pull request #3501 from lasconic/mp3-windows
Fix #208006: Add built-in MP3 support for Windows
2018-02-28 08:39:16 +01:00
Eric Fontaine
5507d256b3 fix #269845 Svg don't inheirt QPaintEnginePrivate
SvgPaintEnginePrivate class has always extended QPaintEnginePrivate.  But QPaintEnginePrivate was defined in a header file which was copy-and-pasted from Qt over 6 years ago in the initial git commit.  But with 5.10, Qt added another QRegion member to their definition of QPaintEnginePrivate to fix a bug, so the old copy-and-pasted header no longer correctly represents QPaintEnginePrivate.  This conflicting definition results in a segfault whenever I tried to run mscore 2.1, 2.2, or master at least on my armv7 arch linux machine when using Qt 5.10 (although worked with Qt 5.9).

Lasconic suggested maybe try removing the inheiritance all together.  Turns out SvgPaintEnginePrivate doesn't actually need to inheirit QPaintEnginePrivate.  So the fix here is to remove that inheiritance and complety remove the old copy-and-pasted private header file.
2018-02-28 08:37:32 +01:00
Finley Lau
5dd85bd5ab fix #269467: added stringutils class to support searching without accents, added tests in mtest 2018-02-27 15:15:34 -06:00
lasconic
bf3e438fb7 Fix #208006: Add built-in MP3 support for Windows 2018-02-27 17:35:11 +01:00
Joachim Schmitz
132c71e532 Fix #226416: Change both "Drumroll Editor" and "Pianoroll Editor" to "Piano Roll Editor" 2018-02-27 12:34:20 +01:00
Matt McClinch
357f1098d7 fix #269672: Show selected notes on the piano control 2018-02-26 15:45:26 +01:00
Nicolas Froment
3a46aa994c
Merge pull request #3494 from mattmcclinch/269508-figured-bass
fix #269508: The figured bass crashes if first the selected measure...
2018-02-26 11:39:02 +01:00
Leon Vinken
f41976550a fix spurious warnings on MusicXML import 2018-02-26 08:10:22 +01:00
Leon Vinken
03f1388627 fix #268009 - Crash on MusicXML Import caused by duplicate clef definition ... 2018-02-25 20:35:31 +01:00
Matt McClinch
372093aca8 fix #269508: The figured bass crashes if first the selected measure is empty 2018-02-24 13:33:00 -05:00
Nicolas Froment
eb79e1d97a
Merge pull request #3486 from anatoly-os/FixAppVeyorCompilationWarnings
Fixed AppVeyor's warnings
2018-02-23 14:27:24 +01:00
Anatoly-os
847bfaac35 Fixed AppVeyor's warnings
Initialized variables
Removed unused variables
Replaced char* local variable with std::string
Fixed unused variable check and adjusted Q_ASSERT usage
2018-02-22 14:31:39 +02:00
Joachim Schmitz
2b5f0ac7f9 Change "Measure Width" to "Layout stretch"
as per https://musescore.org/en/node/269655
2018-02-22 13:25:36 +01:00
anatoly-os
8915b35db2 Fixed clang warnings:
- removed obsolete Score* _score from XmlReader
- removed not used variables
- added braces for initializer list
- fixed using similar var names in one scope
2018-02-21 19:41:36 +01:00
Nicolas Froment
f995765cbd
Merge pull request #3466 from luzpaz/misc-typos-2
Misc. typos follow up
2018-02-21 19:36:53 +01:00
ws
d3d2bf682b fixes for slur creation and slur editing 2018-02-20 15:43:28 +01:00
luz.paz
dab3b5f056 Misc. typos follow up
Follow up to previous typo commit a8ac55c180
2018-02-19 19:30:12 -05:00
Joachim Schmitz
eb836b5068 fix compiler warnings introduced in d0c5ef5 and 0a395cf
last part only needed for 2.2, but shouldn't harm in master, we're using
double braces on other places too when initializing a std::array
2018-02-19 14:36:47 +01:00
Nicolas Froment
98b651472c
Merge pull request #3406 from lyrischesich/267721-span-preset-change-multi-selection
fix #267721, fix #268624: barline inspector - change span presets and reset span values on multiselection
2018-02-16 11:29:47 +01:00
Nicolas Froment
5ad359fba0
Merge pull request #3471 from Soerboe/partstyle.to.new.preference.model
Use new preference model for part style
2018-02-16 10:01:30 +01:00
Johan Temmerman
d5d7ac854d fix #269498 typo in instrumentMapping GP6 import of baritone 2018-02-16 03:00:41 +01:00
Dag Henning Liodden Sørbø
b1cb83acab Use new preference model for part style 2018-02-16 00:05:38 +01:00
Leon Vinken
d0c5ef59c2 refactor MusicXMLParserPass[12]::note(), MusicXMLParserPass2::notations() and ExportMusicXml::chord() 2018-02-14 19:24:07 +01:00
Nicolas Froment
a8ac55c180
Merge pull request #3462 from luzpaz/misc-typos
Misc. typos
2018-02-14 17:52:21 +01:00
luz.paz
443be63167 Misc. typos
Found via `codespell -i 3 -w --skip="./thirdparty,./share/locale,./fonts" -I ../musescore-whitelist.txt`
Whitelist:
```
clas
nd
ot
pres
strack
tage
te
```
2018-02-13 12:06:05 -05:00
ws
f924a38b7b fix #269370 crash dropping element while in edit mode 2018-02-13 09:39:52 +01:00
ws
f6e30ae35a fixes for foto mode 2018-02-12 16:34:33 +01:00
Nicolas Froment
902ae54ccb
Merge pull request #3452 from anatoly-os/240831_spacersEditCrash
fix #240831, fix #267689: crash on editing arpeggios, spacers, brackets and stems
2018-02-12 11:36:23 +01:00
mattmcclinch
e1ae0bfee6 fix #269212: "Tab bar" in View menu on macOS Sierra (#3457)
fix #269212: "Tab bar" in View menu on macOS Sierra
2018-02-12 11:34:54 +01:00
anatoly-os
f1c36a6ed9 fix #240831, fix #267689: crash on editing arpeggios, spacers, brackets and stems
Added required call to the super startEdit() method to initialize ElementEditData for further usage in startEditDrag.
Removed nullptr check since it is actually useful to have crashes on master to find incorrect program states, but not just avoid occasional crashes.
2018-02-09 15:14:44 +02:00
Matt McClinch
2e112abcff fix #175216, fix #269114: Crash with shortcut alt+arrow up/down if more than one element or nothing is selected
Fix other related issues with the up-chord/down-chord commands
Prevent crash when adjusting the grips of ties
2018-02-09 12:44:18 +01:00
Nicolas Froment
06cc782a11
Merge pull request #3438 from Jojo-Schmitz/metaTags-for-parts
Fix #269132: Score properties wiped when saving a generated part
2018-02-09 11:13:34 +01:00
Nicolas Froment
d7dc25e62e
Merge pull request #3441 from Jojo-Schmitz/24745-revision-+OS-version
fix #24745: Add OS info to revision
2018-02-08 17:44:55 +01:00
Dag Henning Liodden Sørbø
2b6cb8b432 Change to new preferences model
The old Preferences struct holding all preferences are removed in favor of a
new Preferences class which acts as a proxy for QSettings. The settings stored
in QSettings are accessed directly through access methods like getBool(key),
getInt(key), etc. and changed with setPreference(key, value).

Since we are using QSettings directly the preferences are stored automatically
without the need for a custom write() and read() method like before.

The preferences.cpp/.h and prefdialog.cpp/h are refactored to have fewer
responsibilities than before. The Preferences class are all about storing and
retrieving preferences - it should not contain any code to handle any other
aspect of MuseScore.

Testing:
The Preferences class can be used in tests. All preferences are initialized with
default values in mtest. If a test requires that a preference has a specific
value it can be changed using setPreference() for that single test. In the tests
the preferences are stored in memory only.

The Preference class is supposed to be used as a singleton. In preferences.h an
'extern Preferences preferences' is set and it is defined in preferences.cpp. All
files which includes preferences.h have access to the 'preferences' singleton
and should use this to get and set preferences.
2018-02-08 16:59:10 +01:00