Commit graph

412 commits

Author SHA1 Message Date
ws
e7591d1d63 fix regression in detecting multi measure rests 2015-02-18 12:26:26 +01:00
ws
ec8913a19b fix #45601 changing note value can lead to missing accidentals; simplify layout() 2015-02-17 20:22:38 +01:00
ws
50bc1b6dad fix undo of local time signature change 2015-02-16 09:44:39 +01:00
ws
c94d62d5a5 fix #23254 LAyout/undo issues with clef change after repeat barline 2015-02-14 16:24:52 +01:00
ws
8dacb7f27b fix #47141 Wrong results ion lined staves (Tab and standard) when dragging notes with mouse 2015-02-12 11:41:39 +01:00
ws
cf37ea318a fix #31696 Add Drumset checkbox to the Mixer 2015-02-11 13:17:06 +01:00
Marc Sabatella
d79bd3a502 fix #46401: breath segments placed too early 2015-02-06 22:32:34 -07:00
ws
8b747c1201 fix #22040 No impending save after making changes to Edit Drumset 2015-02-04 19:51:24 +01:00
Werner Schweer
e951b925e5 Merge pull request #1707 from MarcSabatella/section-pause
fix #37191: playback of breath & section break pauses
2015-02-02 10:30:45 +01:00
Werner Schweer
ac8c99ba2d Merge pull request #1692 from MarcSabatella/check-multi-voice
fix #9355: only offset rests / flip stems if multivoice visible
2015-02-02 10:10:46 +01:00
Marc Sabatella
4becc39ecb fix #37191: playback of breath & section break pauses 2015-01-29 14:57:36 -07:00
ws
3f5d291998 fix #6861: Changing from pitched to non-pitched instrument and undo retains note heads of the latter 2015-01-29 10:39:00 +01:00
Marc Sabatella
4b4ac70a78 fix #9355: only offset rests / flip stems if multivoice visible 2015-01-27 23:33:26 -07:00
ws
1634901bc9 fix #42466: Add a staff to an other which contains a local time signature causes a crash 2015-01-26 12:48:32 +01:00
Werner Schweer
69fcd6e94a Merge pull request #1677 from mgavioli/Fix_15022_29526_improve_graces_after_chord
Fix #15022 and #29526 - Improve layout of grace notes after chord
2015-01-26 10:36:59 +01:00
Werner Schweer
db768c4cbe Merge pull request #1671 from mgavioli/no_lyrics_syll_padding_in_measure
Do not expect padding for lyrics syllabic dashes in Measure layout
2015-01-26 10:32:41 +01:00
ws
898e4a3bc8 fix #45436: Multi-voice grace notes collide with bar line 2015-01-26 10:23:35 +01:00
Maurizio M. Gavioli
1d070a3e96 Fix #15022 and 29526 - Improve layout of grace notes after chord
An attempt to improve the layout of grace notes after chord. It probably does not cover all the possible interactions with other score elements, particularly in tight scores, but it should achieve reasonable results for common cases with a rather simple algorithm.

For some discussion and examples, see the original issue at http://musescore.org/en/node/15022 and the forum thread at http://musescore.org/en/node/45346
2015-01-25 23:00:59 +01:00
Maurizio M. Gavioli
a4a51787bb Do not expect padding for lyrics syllabi dashes in Measure layout
In `Measure::layoutX()` and in `Score::computeMinWidth()` there is code to add room for dash padding in lyrics syllables, with a reference to `System::layoutLyrics()`.

As `System_layoutLLyrics()` no longer exists and as `LyricsLineSegment::layout()` now adjusts (and occasionally skips) dash width to actual note distance, this is now redundant and may in some cases interfere with the `LyricsLineSegment::layout()` calculations.

Some tests with rather dense polyphonic scores did show that some space may be gained, without raising any evident 'crowding' problem.
2015-01-23 22:26:44 +01:00
Marc Sabatella
45b6bb4cf6 Merge pull request #1661 from MarcSabatella/44991-note-entry-accidental-state
fix #44991: wrong accidental for transposing instruments in note entry
2015-01-22 16:41:46 -07:00
Werner Schweer
de4961e10e Merge pull request #1663 from mgavioli/small_barlines_width_and_alignment_A
Bar Lines: Correct width and alignment in small staves NICE SOLUTION
2015-01-22 14:59:10 +01:00
Maurizio M. Gavioli
0ce91b6e4d Bar Lines: Correct width and alignment in small staves NICE SOLUTION
In small staves, some types of bar lines are drawn with small lines and some are not (mainly end bar lines). In addition all bar lines of a measure are left-aligned; when small and regular staves are mixed this looks untidy for mid-system bar lines and quite wrong for system-end bar lines. See http://musescore.org/en/node/44966 for a discussion and an example.

This patch tries to achieve the best-looking possible result:
- it lays out and draws all bar lines in small staves with small widths
- it right-aligns end bar lines, end-repeat bar lines and any bar line at system end
- it left-aligns start-repeat bar lines
- it centre-aligns any other bar line.
2015-01-22 02:18:49 +01:00
Marc Sabatella
e3181a8af6 fix #44991: wrong accidental for transposing instruments in note entry 2015-01-21 10:31:12 -07:00
ws
69febbce94 fix #44676: Change of duration of measures including grace notes (acciaccatura) causes a crash in tab staff 2015-01-21 11:57:57 +01:00
ws
16764d4614 fix #44466: Crash extending volta over mmrest starting a new system + other cleanups 2015-01-19 12:41:16 +01:00
ws
1b51e5832a Merge branch 'master' of github.com:musescore/MuseScore 2015-01-12 14:07:17 +01:00
ws
69dd28e7df preparations for changing division value 2015-01-12 14:07:05 +01:00
Maurizio M. Gavioli
c69d2a9262 Lyrics multi-system melisma and dashes
Implements melisma and dash lines for lyrics spanning several systems.

The melisma and dash line is based on the `SLine` class and its segments on the `LineSegment` class. Both the whole line and its segments are not selectable, marked as generated and not saved in the score file, which is not changed in any way.

For very wide dash segments, several dashes are drawn; the distance between the dashes is not configurable.

Lyrics layout code in `Measure` class and in `layout.cpp` file has been commented out as the lyrics line layout is all contained in the lyrics.cpp file

The line is registered with the `Score` (to have its layout delayed until all elements are positioned) with a mechanism similar to other `Spanner`'s, but in a different container (`_unmanagedSpanner`), as the owning `Lyrics` should decide when create, register, unregister and delete its line.

The line segments are registered with the `System` they belong to (to have them drawn), in the same way as other `Spanner`'s.

There is code for using the dash metrics of the lyrics font, but it is turned off via a conditional directive, as there does not seem to be a reliable way to determine the dash metrics; conventional values (determined by trials and errors and based on my taste!) are used when the conditional directive is off.
2015-01-11 10:16:19 +01:00
Werner Schweer
24e0c1ff6b Merge pull request #1587 from MarcSabatella/33476-scan-mmrest
fix #33476: select similar and other mmrest issues
2015-01-02 08:46:23 +01:00
Marc Sabatella
0b48254691 slightly more conservative hyphen padding 2014-12-31 17:01:17 -07:00
Marc Sabatella
77e3a87ebf fix #42261: add space before melisma 2014-12-30 23:45:35 -07:00
Marc Sabatella
a03cd4bfd0 fix #33476: select similar and other mmrest issues 2014-12-29 16:59:01 -07:00
lasconic
b1040d8588 fix #41516: Voltas & repeat text do not migrate to top when instrument raised to top of the score 2014-12-20 20:56:40 +01:00
Marc Sabatella
9d7185d89a fix #32231: width of initial measure & other measures with key signatures in continuous view 2014-12-13 17:43:17 -07:00
Nicolas Froment
3fca04120b Merge pull request #1510 from MarcSabatella/40846-ctrl-barline
fix #40846: require Ctrl+drag to create staff-only barline change
2014-12-10 19:44:19 +00:00
ws
8ff4a8f95e fix #29931: Custom key signatures do not show 2014-12-08 18:02:29 +01:00
ws
e835aa54f1 make systemBarLineType a property 2014-12-08 13:36:52 +01:00
Werner Schweer
e4e377a36b Merge pull request #1316 from mgavioli/system_initial_barline_style
Style of the initial bar line of a system.
2014-12-08 13:03:03 +01:00
Marc Sabatella
d3b8157be6 fix #40846: require Ctrl+drag to create staff-only barline change 2014-12-06 16:11:50 -07:00
ws
f3071ac9d0 fix #29931: Custom key signatures do not show 2014-12-04 14:40:26 +01:00
lasconic
8c179655c5 fix mtest 2014-11-28 22:35:25 +01:00
lasconic
c61c9aee68 fix #40036: Tremolo through stem on grace note all eighths in 1.3 score 2014-11-28 19:56:09 +01:00
Marc Sabatella
ff6f2016b9 fix #35661: bad breath position if no tick tag 2014-11-26 16:40:51 -07:00
lasconic
edcaa098a3 fix #31221 2014-11-25 16:53:43 +01:00
Marc Sabatella
58e5a74588 fix #8924: native support for slash notation 2014-11-17 22:02:12 -07:00
ws
666ea12d00 fix #38486 2014-11-12 15:01:36 +01:00
Nicolas Froment
1e8c3a35c9 Merge pull request #1439 from MarcSabatella/38501-cross-staff-gliss
fix #38501: cheap partial fix for cross-staff and cross-system gliss
2014-11-11 13:33:51 +00:00
lasconic
0f3c18d850 fix #38736: take 2 2014-11-10 12:33:32 +00:00
lasconic
8f3c1d3b7b fix #38736: joining some scores via album feature leads to crash 2014-11-10 11:27:08 +00:00
Marc Sabatella
98235e52b2 fix #38501: cheap partial fix for start position of cross-staff and cross-system gliss 2014-11-07 13:23:07 -07:00