Commit graph

206 commits

Author SHA1 Message Date
James Thistlewood
9340d6823c fix #286207: single-note dynamics: fortepianos that last longer than a segment play incorrectly 2019-03-17 17:59:36 +00:00
Joachim Schmitz
40f944c331 fix MSVC compiler warnings
and a MinGW warning too.
Don't cache (old) mingw dependencies on AppVeyor
2019-03-14 10:00:51 +01:00
Michael Froelich
94caa9fd9f fix #68456: fixes pitch bends 2019-03-10 18:50:45 +11:00
James Thistlewood
0058408870 post-fraction fixes 2019-03-02 18:18:12 +00:00
James Thistlewood
459049b5c4 Add single-note dynamics 2019-03-02 18:18:12 +00:00
ws
ec3be9a99a Replacd integer midi tick values by fractions.
- tick names a position on the time axis
- tick is always a Fraction()
- only Measure() and Segment() (and Tuplet?) have a tick value
- tick() for an generic element return only a sensible value if isMeasure() or isSegment() or isSegment(parent())

- "ticks" names a duration stored in a Fraction()
- the tick value for an Segment is relative to its measure

- rename "duration" to "ticks"
- rename afrac() to tick()
- rename rfrac() to rtick()
- rename some variables, changing "fraction" into "tick"
  (example: actualFraction() into actualTicks())

- Lyrics ticks are written as Fraction, on read if xmlreader sees a "/" it reads a fraction
  else midi ticks for backwards compatibility
2019-02-18 11:46:05 +01:00
anatoly-os
da65043414
Merge pull request #4604 from jthistle/282249-guitar-trembar
fix #282249: guitar vibratos play earlier than they should after repeated measures
2019-02-05 23:37:07 +02:00
James Thistlewood
02d241edcb fix #282249: guitar vibratos play earlier than they should after repeated measures 2019-02-05 18:55:50 +00:00
James Thistlewood
4197fd682f fix #282186: importing tremolo from 1.3 causes crash 2019-01-19 09:22:45 +00:00
mirabilos
77983234c8
some spelling fixes
most from the spell checker built into Debian’s automated
package checking tool lintian, two from me during applying
those lintian-suggested fixes
2018-11-27 22:49:18 +01:00
anatoly-os
b0b77ba185
Merge pull request #4145 from dmitrio95/tied-trill-playback
fix #77376: don't render those tied notes which are handled on rendering previous notes
2018-11-16 18:09:08 +02:00
Dmitri Ovodok
cf73f527b6 fix #77376: don't render those tied notes which are handled on rendering previous notes.
This helps to fix playback of tied trills for which extra note play
events were created.
2018-11-15 13:00:50 +02:00
mirabilos
0a0ce26b33
fix #270408, #270878: merge the restriking patches
This brings master to the same state as v2.3.2 wrt. the MIDI issues;
*this* commit can later easily be reverted once we switch away from
restriking again as @lasconic indicated in:
https://musescore.org/en/node/270562#comment-826020
2018-11-14 17:11:58 +01:00
mirabilos
d741d5055f
fix #12971, #270408, #270783: note collisions in playback
Also adjust MIDI testcases: the reference output did
hardcode the old behaviour of not refcounting.
2018-11-14 17:11:45 +01:00
Mark McKay
fdeb795e34 fix #275313: rework mixer ui 2
Moving PartEditBase into separate file.  Creating new files for
building mixer.

Creating art assets/UI design for new components.

Styling the track control.

Adding track area.

Separating out score from update.

Creating instances of mixer UI.

Creating part per voice now.

Can click on tracks to select them now.

Can now switch bwtewwn tracks.

Setting patch channel now.

Setting enabled off when no track selected.

Improving slider ui.

Turning Channel into a class and adding listener to it.

Somewhat stabalized sharing track objects between interfaces.

Can now apply volume changes to both expanded and collapsed tracks.

Pan knob is now working.

Encapsulating the rest of the fields in Channel.

Mute and solo now working.

Reverb and chorus now working.

Drumkit checkbox now working.  Port and channel somewhat working.

Adding support for colors per track.

Part name change now working.

Separating out MixerTrackItem

Finishing moving MixerTrackItem to new file.

Cleaning up code.

Moving PartEditBase into separate file.  Creating new files for
building mixer.

Creating art assets/UI design for new components.

Styling the track control.

Adding track area.

Separating out score from update.

Creating instances of mixer UI.

Creating part per voice now.

Can click on tracks to select them now.

Can now switch bwtewwn tracks.

Setting patch channel now.

Setting enabled off when no track selected.

Improving slider ui.

Turning Channel into a class and adding listener to it.

Somewhat stabalized sharing track objects between interfaces.

Can now apply volume changes to both expanded and collapsed tracks.

Pan knob is now working.

Encapsulating the rest of the fields in Channel.

Mute and solo now working.

Reverb and chorus now working.

Drumkit checkbox now working.  Port and channel somewhat working.

Adding support for colors per track.

Part name change now working.

Separating out MixerTrackItem

Finishing moving MixerTrackItem to new file.

Cleaning up code.

Setting color in collapsed mode now affects all channels.

Using shared_ptr to track MixerTrackItem.  Part changes now affect
all instruments.

Creating new track UI object to handle parts.

Using shard_ptr to track MixerTrackItem objects.

setting port and channel data now.

Changing to horizontal layout.

Fixing knob display.  Chaning track control appearance.

Setting init slider window size.

Switchong back to vertical orientation.  Fixing a few UI bugs in
the slider.

Tracks now left aligned.

Moving details panel above mixer.  Now changing track selection when
user clicks on sliders.

Pan and volume controls now reflect track color.

Showing volume and pan values in tooltips.

Creating a new slider control for mixer.

Switching Channel's volume, pan, reverb and chorus and chaning them
to doubles with a decimal range.

No longer writing out vol, pan, chor, reverb when at default values.

Nolonger writing vol, pan, chorus, reverb as controler values in
output file.

Now testing against default values on write.

More export fixes.

Manually editing test files to reflect new channel parameters.

Manually editing more test files to reflect new channel parameters.

Manually editing more test files to reflect new channel parameters.

More test changes to make Travis happy.

More test changes to make Travis happy.

Importing MusicXML now matches new volume, pan ranges.

Changing range of pan.  Fixing a few bugs with calculating MIDI.
Altering test files for Travis.

fix #275313: rework-mixer-ui-2

Moving PartEditBase into separate file. Creating new files for
building mixer.

Creating art assets/UI design for new components.

Styling the track control.

Adding track area.

Separating out score from update.

Creating instances of mixer UI.

Creating part per voice now.

Can click on tracks to select them now.

Can now switch bwtewwn tracks.

Setting patch channel now.

Setting enabled off when no track selected.

Improving slider ui.

Turning Channel into a class and adding listener to it.

Somewhat stabalized sharing track objects between interfaces.

Can now apply volume changes to both expanded and collapsed tracks.

Pan knob is now working.

Encapsulating the rest of the fields in Channel.

Mute and solo now working.

Reverb and chorus now working.

Drumkit checkbox now working.  Port and channel somewhat working.

Adding support for colors per track.

Part name change now working.

Separating out MixerTrackItem

Finishing moving MixerTrackItem to new file.

Cleaning up code.

Moving PartEditBase into separate file.  Creating new files for
building mixer.

Creating art assets/UI design for new components.

Styling the track control.

Adding track area.

Separating out score from update.

Creating instances of mixer UI.

Creating part per voice now.

Can click on tracks to select them now.

Can now switch bwtewwn tracks.

Setting patch channel now.

Setting enabled off when no track selected.

Improving slider ui.

Turning Channel into a class and adding listener to it.

Somewhat stabalized sharing track objects between interfaces.

Can now apply volume changes to both expanded and collapsed tracks.

Pan knob is now working.

Encapsulating the rest of the fields in Channel.

Mute and solo now working.

Reverb and chorus now working.

Drumkit checkbox now working.  Port and channel somewhat working.

Adding support for colors per track.

Part name change now working.

Separating out MixerTrackItem

Finishing moving MixerTrackItem to new file.

Cleaning up code.

Setting color in collapsed mode now affects all channels.

Using shared_ptr to track MixerTrackItem.  Part changes now affect
all instruments.

Creating new track UI object to handle parts.

Using shard_ptr to track MixerTrackItem objects.

setting port and channel data now.

Changing to horizontal layout.

Fixing knob display.  Chaning track control appearance.

Setting init slider window size.

Switchong back to vertical orientation.  Fixing a few UI bugs in
the slider.

Tracks now left aligned.

Moving details panel above mixer.  Now changing track selection when
user clicks on sliders.

Pan and volume controls now reflect track color.

Showing volume and pan values in tooltips.

Creating a new slider control for mixer.

Switching Channel's volume, pan, reverb and chorus and chaning them
to doubles with a decimal range.

No longer writing out vol, pan, chor, reverb when at default values.

Nolonger writing vol, pan, chorus, reverb as controler values in
output file.

Now testing against default values on write.

More export fixes.

Manually editing test files to reflect new channel parameters.

Manually editing more test files to reflect new channel parameters.

Manually editing more test files to reflect new channel parameters.

More test changes to make Travis happy.

More test changes to make Travis happy.

Importing MusicXML now matches new volume, pan ranges.

Changing range of pan.  Fixing a few bugs with calculating MIDI.
Altering test files for Travis.

Restoring the volume, pan, chorus, reverb to original char data type
& range.  UI now shows different 'user friendly' ranges.

Overwriting tests with versions from master.

mtest/libmscore/compat114/clef_missing_first-ref.mscx
mtest/libmscore/compat114/hor_frame_and_mmrest-ref.mscx
mtest/musicxml/io/testInstrumentChangeMIDIportExport_ref.xml
mtest/musicxml/io/testUninitializedDivisions_ref.xml

Restoring test files to original state.

Restoring test files to original state.

Restoring old values for importing files.

Restoring part methods.

mtest/importmidi/simplify_8th_dotted_no_staccato.mscx
mtest/libmscore/compat114/clef_missing_first-ref.mscx
mtest/libmscore/compat114/hor_frame_and_mmrest-ref.mscx
mtest/musicxml/io/testInstrumentChangeMIDIportExport_ref.xml
mtest/musicxml/io/testUninitializedDivisions_ref.xml

Rearranging UI components for better feel.

Improving UI.  Fixed crash when changing part name.

Adding support for two lighting modes.  Showing part name over
channel expansion.

Adding master gain control to mixer.

Changing color of gain slider.

Adapting to latest source in main.

Changing master gain slider to use decibel calculation.

CSS now set on tracks whenever a Paint event received.

Restoring mixer slider values to refect MIDI ranges.  Fixing crash when drumkit checked.

Fixing crash when closing score.

Fixing alignment in mixer details.

Tweaking UI for better appearance.
2018-11-13 12:43:19 -05:00
alexandr
b736b8c8ab fix #231711: Tempo, staff text and other text honored in skipped volta
Volta stores tempo, velocity and channel at the tick before volta and sets it at the last tick of volta

velosity and channel is set inside Score::renderMidi. But tempo is set inside volta::layoutSystem because we need set tempo here because all tempos of score are set in layout. So fermata in  seconda volta works correct because fermata apply itself tempo during layouting
2018-11-10 13:05:28 +02:00
anatoly-os
de93ba1bd4
Merge pull request #4052 from dmitrio95/fix-trills-ottava-playback
fix #274247, fix #110181: use effective pitches of notes when calculating playback of trills and ornaments
2018-10-26 08:57:06 +02:00
anatoly-os
6e0df6a83b
Merge pull request #3882 from jthistle/274839-add-capo-setting-to-staff-text
Fix #274839: Add capo setting to staff text
2018-10-25 16:22:29 +02:00
Dmitri Ovodok
3cef1c4870 fix #274247, fix #110181: use effective pitches of notes when calculating playback of trills and ornaments 2018-10-23 15:54:29 +03:00
alexandr
d464b009de fix #113051: Arpeggio playback should not depend on tempo
1) Add timeStratch field to arpeggio inspector to manipulate velocity of arpeggio. Now arpeggio with timeStretch which equal 1, doesn't depend on applying tempo. Arpeggio sounds the same.
2) Add unit test to midi tests.

1


2


3
2018-10-20 11:51:00 +02:00
James Thistlewood
e8aeacee39 fix #274839: Add capo setting to staff text properties 2018-10-14 08:03:37 +01:00
Joachim Schmitz
474e8152cd fix #275218: fix MSVC C4456 warnings
reg. a declaration shadowing a previously declared local
variable,
"Warning C4456: declaration of 'XXX' hides previous local
declaration"
2018-09-27 17:38:19 +02:00
Joachim Schmitz
b27817fe19 fix more MSVC warnings
* The one C4100
* The one C4189
* The two C4457
* The two C4701
* The 475 C4267, changing to size_t were easily possible, casting to
int elsewhere
* Fix GCC warnings reg. wrong printf format for a size_t, reg. unused
variables and reg. ambigous else branch, seen on Travis CI
2018-09-11 16:56:50 +02:00
Joachim Schmitz
632f830f5f Fix #275218: fix MSVC compiler warnings
* Warnings C4304, C4804 and C4838.
* Warnings C4065 and most C4702 (all but two).
* Warnings C4701.
* Warnings C4244.
* Warnings C4457.
* Warnings C4459.
* Some warnings C4456, due to nested `foreach` loops.
2018-08-14 10:03:49 +02:00
ws
10ebbb9080 update text style implementation 2018-08-01 11:46:35 +02:00
anatoly-os
0c43b22820 implement flams
Set constant length for grace notes for unpiched percussion.
The distance between the grace note and the main note still exists.
2018-07-11 15:10:57 +02:00
lasconic
f589b81e3f fix #273225 fix #273500: buzzroll not displayed in PDF export and not highlighted when selected 2018-06-20 20:12:03 +02:00
lasconic
2e7f03e907 fix #256021: Add buzz roll tremolo stem. Simplify 1.3 compatibility for tremolo 2018-05-17 23:10:16 +02:00
lasconic
b8138c1629 fix #272276: Add ability to have a different MIDI pitch for drum instrument based on articulation or tremolo 2018-05-11 23:14:49 +02:00
Johan Temmerman
79d4227534 fix #148276 end Open Volta before next startRepeat as well
fix #269603 unwind followup especially with regards to DS having playRepeats enabled
2018-03-07 12:55:07 +01:00
luz.paz
dab3b5f056 Misc. typos follow up
Follow up to previous typo commit a8ac55c180
2018-02-19 19:30:12 -05:00
Nicolas Froment
84339e3f80
Merge pull request #3360 from lasconic/Jojo-Schmitz-static-code-analysis
Fixing issues found in static code analysis by PVS-Studio
2017-12-20 17:10:13 +01:00
Werner Schweer
1943bd1ff1 replace most static_cast in libmscore 2017-12-20 16:49:58 +01:00
Joachim Schmitz
5e116fe595 Fixing issues found in static code analysis by PVS-Studion
See https://musescore.org/en/node/255156
2017-12-20 16:26:23 +01:00
Werner Schweer
8c67df20ab fix visual test emmentaler-4, wrong articulation 2017-12-19 09:18:22 +01:00
Werner Schweer
020f7b1c08 fix vtst 'chord-space-1' 2017-12-11 12:35:23 +01:00
lasconic
be27e9454e new let ring playback 2017-12-01 13:52:21 +01:00
lasconic
e356a89e51 update for vibrato, it's now a first class Element. GPX import test for vibrato. 2017-11-30 13:25:25 +01:00
lasconic
2a1a3525b7 2nd try for vibrato playback 2017-11-22 12:44:59 +01:00
lasconic
374f9b176c first implementation of vibrato playback 2017-11-20 21:26:59 +01:00
lasconic
c41fc1656e fix potential endless loop when generating midi with arpeggio 2017-11-13 09:50:37 +01:00
lasconic
0d6ff8c300 fix #230351: Articulations and ornaments do not play at moderate to high tempos 2017-07-05 23:50:46 +02:00
lasconic
54c05a7178 fix #192236: Freeze when opening file with very large glissando 2017-04-24 11:36:15 +02:00
Werner Schweer
867f2582f6 move Segment::Type into SegmentType 2017-03-08 13:12:26 +01:00
lasconic
7a8ba0706d fix #175341: [GP6] Crash on a file involving arpeggios, ties and capo feature 2017-02-20 17:16:45 +01:00
Werner Schweer
251c298821 more complete SystemText impl. 2017-01-23 10:54:57 +01:00
Werner Schweer
1d4c6b2f21 move Element::type() to ScoreElement 2017-01-18 14:16:33 +01:00
Werner Schweer
660b393b98 change StaffType interface 2016-12-14 15:44:24 +01:00
Werner Schweer
4850088bdb fix midi rendering of articulations so mtests now pass 2016-10-06 17:03:51 +02:00
Werner Schweer
2f7a007140 fix midi rendering of articulations 2016-10-06 16:36:50 +02:00