Commit graph

4845 commits

Author SHA1 Message Date
Roman Pudashkin
f4b4e73315 fix #11106: fixed adding key signatures for new staves.
score()->keyList() depends on the current staff list, so it should be called before adding new staves
2022-04-08 13:33:57 +02:00
RomanPudashkin
82084226e7
Merge pull request #11049 from cbjeukendrup/vst_list_sort
Sort the list of available (VST) plugins
2022-04-06 18:00:20 +02:00
RomanPudashkin
dc30f48753
Merge pull request #10873 from cbjeukendrup/engraving_debug_actions
Bring back some engraving debug painting tools from MU3
2022-04-06 17:57:58 +02:00
RomanPudashkin
b3cf72b788
Merge pull request #11072 from duanjr/9381-Brackets-palette-does-switch-to-display-dark-mode
Fix 9381: set correct color for brackets in dark mode
2022-04-06 17:36:10 +02:00
RomanPudashkin
5020d1dd67
Merge pull request #11105 from RomanPudashkin/score_marked_as_dirty_after_opening
[MU4] MU marks recent score dirty after opening even if no changes were made
2022-04-06 15:37:53 +02:00
Elnur Ismailzada
90e11c61e5
Merge pull request #11095 from RomanPudashkin/volta_crash
[MU4] Fix #11079: Create a new part and opening it crashes with a specific score
2022-04-06 13:48:35 +03:00
RomanPudashkin
8a0e2dc1d9
Merge pull request #10938 from Eism/inspector_popups_fix
fixed #10871: Fixed closing popups in inspector
2022-04-06 12:03:02 +02:00
Elnur Ismailzada
42aa10c0f7
Merge pull request #11104 from Eism/backend_highlight_fix
[MU4] Backend. Applying color not only for notes, also for rests
2022-04-06 10:52:32 +03:00
Eism
ccb78c654f Set color for beats instead of notes 2022-04-06 10:11:53 +03:00
Igor Korsukov
5e05e4825d replaced QHash to std unordered_map 2022-04-06 10:05:48 +03:00
Roman Pudashkin
fd6912b181 fix #10950: we need to adjust the muted value for the metronome before saving since it may contain the value from the configuration 2022-04-05 21:32:08 +02:00
Roman Pudashkin
addd1f9cc5 fix #11079: fixed crash after creating an empty part containing a volta line 2022-04-05 20:46:51 +02:00
RomanPudashkin
b9ab412a08
Merge pull request #11091 from asattely/enable-vertical-spread-default
[MU4] Change default for enableVerticalSpread to be in line with 3.6
2022-04-05 17:15:15 +02:00
RomanPudashkin
65eb0cf318
Merge pull request #11087 from RomanPudashkin/loading_long_scores_optimization
[MU4] MS4 struggles to open long scores which open easily in MS3
2022-04-05 17:12:31 +02:00
RomanPudashkin
342b3ce2b9
Merge pull request #11081 from Jojo-Schmitz/compiler-warnings
[MU4] Fix (MSCV) compiler warning
2022-04-05 11:58:44 +02:00
RomanPudashkin
2c33943f4f
Merge pull request #10862 from RomanPudashkin/inspector_dropdown
[MU4] Fix #9644: Text options are not showing indeterminate states
2022-04-05 10:00:06 +02:00
Peter Jonas
21659853cf instruments.xml: Rename dropdownName to traitName to match C++ code
The online instrument spreadsheet has been updated to use the terms
"traitName" and "traitType" to match the C++ code. This commit makes
the corresponding change in update_instruments_xml.py so now we say
"traitName" everywhere rather than "dropdownName" or "ddName", and
we say "traitType" instead of "meaning" or "ddMeaning".

Where do these terms come from?

In PR #8432 we adopted "trait" as an abstract term in the C++ code to
represent a defining characteristic, such as tuning or transposition,
that enables us to distinguish between instruments that have the same
name. For example:

| INSTRUMENT  | TRAIT NAMES        | TRAIT TYPE            |
|-------------|--------------------|-----------------------|
| Piccolo     | E♭, D♭, C          | Tranposition          |
| Tin Whistle | D, C, B♭           | Tuning                |
| Bouzouki    | 3-course, 4-course | Course (i.e. strings) |

However, in PR #8403 we had already used "dropdownName" as a way to
refer to the trait property within instruments.xml because the purpose
of this data was to populate dropdown lists in the New Score Wizard.

Why choose "trait" over "dropdown"?

It is desirable to use the same term everywhere. I picked "trait"
because instruments.xml contains model data, so I believe it is
preferable to use an abstract term. "Dropdown" is a UI term and it
refers to just one of many possible ways to view the data.
2022-04-05 01:23:27 +01:00
Aaron Sattely
c45eb2ad51 Change default for enableVerticalSpread to be in line with 3.6 2022-04-04 17:37:48 -04:00
Roman Pudashkin
cd277f3b4f fix #9644: fixed the 'indeterminate state' for text elements 2022-04-04 22:14:22 +02:00
Roman Pudashkin
28b00194b6 fix #10259: changed the behavior of the dropdown component globally. Now it won't change currentIndex on its own, so it won't break bindings on currentIndex 2022-04-04 22:14:19 +02:00
Roman Pudashkin
1ed2b9b193 fixed the implicit change of the currentValue type from int to string 2022-04-04 21:57:25 +02:00
Roman Pudashkin
3001618673 optimized Score::resetDefaults() 2022-04-04 21:56:35 +02:00
Roman Pudashkin
c22199ad49 added more TRACEFUNC 2022-04-04 21:56:35 +02:00
Roman Pudashkin
9e4d9f897e optimized rendering of spanners 2022-04-04 21:56:35 +02:00
Casper Jeukendrup
1380e80120
Sort the list of available (VST) plugins 2022-04-04 21:09:47 +02:00
RomanPudashkin
aabf09ee4f
Merge pull request #11085 from cbjeukendrup/vst_no_WindowContextHelpButtonHint
Remove WindowContextHelpButton from VST editor windows
2022-04-04 19:10:06 +02:00
Casper Jeukendrup
f1cd48e368
Merge pull request #11084 from duanjr/10953-change-edited-reminder
Fix 10953: add asterisk at the beginning of the name
2022-04-04 17:03:21 +02:00
Casper Jeukendrup
c1e664770c
Extract shapes test into real unit tests instead of putting it in #ifndef NDEBUG 2022-04-04 16:54:44 +02:00
Casper Jeukendrup
c2b5231685
Remove WindowContextHelpButton from VST editor windows 2022-04-04 16:46:15 +02:00
Casper Jeukendrup
34883b2bec
Added UI actions for setting engraving debugging options 2022-04-04 16:21:34 +02:00
Casper Jeukendrup
12cce665e0
Moved engraving debugging options from MScore to EngravingConfiguration 2022-04-04 16:21:34 +02:00
Casper Jeukendrup
881b9942df
Bring back some engraving debug painting tools from MU3
Only accessible by editing MScore::showSkylines etc., not through UI.
2022-04-04 16:16:00 +02:00
Justin Duan
0ec932ce9c Fix 10953: add asterisk at the beginning of the name 2022-04-04 21:42:45 +08:00
Joachim Schmitz
862d27589f Fix (MSCV) compiler warning
reg. local variable shadowing function parameter
2022-04-04 13:10:36 +02:00
RomanPudashkin
ce7c1171f9
Merge pull request #11041 from cbjeukendrup/fix_palette_icons_scaling
Make ActionIcons in Palettes scalable
2022-04-04 11:12:34 +02:00
RomanPudashkin
4e8b1e9fa4
Merge pull request #10898 from cbjeukendrup/fix_10848
Fix #10848: Onboarding process no longer starts in the main 'Score' tab. Rewording of Tutorial description needed. App should start maximised.
2022-04-04 10:58:33 +02:00
RomanPudashkin
7d9592d0a8
Merge pull request #11052 from cbjeukendrup/update_palette_widget
Repaint PaletteWidget when adding element
2022-04-04 10:13:02 +02:00
RomanPudashkin
368a8c604f
Merge pull request #11070 from HemantAntony/9284-update_spacer_height
Fix #9284: Update spacer height
2022-04-04 10:11:53 +02:00
Justin Duan
b909609383 Fix 9381: set correct color for brackets in dark mode 2022-04-03 23:46:02 +08:00
HemantAntony
78f003cd61 Fix #9284: Update spacer height 2022-04-03 15:46:31 +05:30
HemantAntony
e34745ffaa Fix #10994: Added tooltip to 'Customise toolbar'
Added tooltip to 'Customise toolbar' button in the note input bar
2022-04-02 08:37:58 +05:30
Casper Jeukendrup
4a8e53a23e
Repaint PaletteWidget when adding element
Also, quite unrelated, use new style signal/slot connect in DrumsetPalette.
2022-04-01 21:35:45 +02:00
RomanPudashkin
1baa77dd3e
Merge pull request #11043 from cbjeukendrup/recent_files_with_comma
Fix storing list of recent files if a filename contains commas
2022-04-01 10:49:40 +02:00
RomanPudashkin
ed83f5ebb4
Merge pull request #11045 from cbjeukendrup/fix_pitch_names_with_negative_octave
Fix MIDI Pitch Names
2022-04-01 10:47:25 +02:00
RomanPudashkin
43245f9be7
Merge pull request #11046 from cbjeukendrup/optimize_styled_text_label
StyledTextLabel: only create MouseArea if really necessary
2022-04-01 10:45:41 +02:00
RomanPudashkin
c7f3002eca
Merge pull request #11025 from mike-spa/correctContinuousViewSpacing
Fix spacing in continuous view
2022-04-01 10:34:58 +02:00
Casper Jeukendrup
9394f6361e
StyledTextLabel: only create MouseArea if really necessary
Only needed when a link is hovered
2022-03-31 23:54:59 +02:00
Casper Jeukendrup
12c88d386f
Fix MIDI Pitch Names
Seen in Preferences > MIDI device mapping > Assign.
2022-03-31 23:43:49 +02:00
Casper Jeukendrup
f17e9ea16f
Fix storing list of recent files if a filename contains commas
Store them as JSON, not as comma-separated list of unencoded paths.
2022-03-31 23:14:25 +02:00
RomanPudashkin
59feb1e1d5
Merge pull request #11030 from RomanPudashkin/empty_inspector
[MU4] Empty inspector
2022-03-31 22:54:05 +02:00