Commit graph

8314 commits

Author SHA1 Message Date
Dmitri Ovodok
fc532ab27b moveLeft/Right anchor code style fixes 2020-04-17 00:05:35 +03:00
pereverzev_v
6b42294919 Added possibility to rebase line anchors during the drag 2020-04-17 00:05:35 +03:00
Dmitri Ovodok
9c1ca67389 Basic implementation of changing line anchors when dragging 2020-04-17 00:05:33 +03:00
Dmitri Ovodok
ed03bd6440 Fix wrong hairpin length if score ends with MM rest 2020-04-17 00:05:32 +03:00
Dmitri Ovodok
265b5f9b2b Extract searchSegment function to search a segment by its x coordinate 2020-04-17 00:05:32 +03:00
Dmitri Ovodok
60169a6082 Extract searchStaff function to search a staff by its y coordinate 2020-04-17 00:05:31 +03:00
anatoly-os
a5c92e2040
Merge pull request #5643 from dmitrio95/mscx-read-crash
Fix a crash on MSCZ reading, add a way of handling such errors
2020-04-16 13:34:06 +03:00
anatoly-os
613a4e39fe
Merge pull request #5738 from dmitrio95/anchors_drawing
Rework anchor lines drawing
2020-04-16 13:33:03 +03:00
anatoly-os
09aeb75dfb
Merge pull request #5915 from Jojo-Schmitz/spacer-crash
fix #303611: Adding fixed spacer can clash with vertical frame below, causing a crash.
2020-04-15 13:04:54 +03:00
anatoly-os
887f745b20
Merge pull request #5332 from mattmcclinch/294542-notehead-scheme
fix #294542: Allow setting notehead scheme on a note-by-note basis in the Inspector
2020-04-15 00:15:52 +03:00
Matt McClinch
4c0db9b19b fix #294542: Allow setting notehead scheme on a note-by-note basis in the Inspector
Resolves: https://musescore.org/en/node/294542.

Up until now, notehead scheme has only been a StaffType property. If a Note is going to have its own notehead scheme, it seems fitting to do a bit of reorganization. Here is a summary of the changes made:
- Moved enum class NoteHeadScheme to NoteHead::Scheme, alongside NoteHead::Group and NoteHead::Type.
- Added HEAD_AUTO as a possible value for NoteHead::Scheme.
- Moved scheme2userName(), scheme2name(), and name2scheme() from class StaffType to class NoteHead.
- Renamed Pid::STAFF_NOTEHEAD_SCHEME to Pid::HEAD_SCHEME. This change is reflected in the Plugin API, with Element property staffNoteheadScheme being renamed to headScheme. This should not break too many existing plugins, because the NoteHeadScheme enum values have never been exposed until now. Speaking of which,
- Exposed the NoteHead::Scheme enum values to the Plugin API as NoteHeadScheme.HEAD_AUTO, etc. And finally, (and the main point of all of this):
- Added a property of type NoteHead::Scheme to class Note, and exposed it via the Inspector. If set to HEAD_AUTO (the default), the StaffType’s noteHeadScheme will be used. Otherwise, this will override the StaffType’s noteHeadScheme.
2020-04-14 10:26:09 -04:00
anatoly-os
a59f72e05f
Merge pull request #5619 from Howard-C/tremolo-layout
More beautiful default layout related to tremolos (fix #20390) (+ collect_artifacts)
2020-04-14 16:35:27 +03:00
anatoly-os
8198aeb93c
Merge pull request #5849 from Jojo-Schmitz/compiler-warnings
fix compiler warnings
2020-04-14 15:39:16 +03:00
Joachim Schmitz
17a978ad8c fix compiler warnings 2020-04-14 14:29:17 +02:00
J. Edward Sanchez
f363220a1b Fix #297426: The playback cursor is not repositioned when selecting items other than notes, rests or measures
Improved the functionality of the playhead (a.k.a. the playback cursor) so that whenever the user selects an element, the playhead is automatically repositioned to the element's time position. Previously, this worked only for noteheads and rests, but it now works for note stems, beams, augmentation dots, accidentals, ties, slurs, articulations, time signatures, key signatures, clefs, tempo changes, dynamics, lines, barlines, breaks, spacers, measure numbers, text, and so on.

Special cases handled:

* Barlines. The playhead is moved to the start of the measure to the right of the barline, unless it's the last barline in either the entire score or the system, in which case the playhead is moved to the start of the measure to the left of the barline.

* Brackets always have a time position of zero, so the playhead is moved to the start of the first measure in the system that the bracket belongs to.

* Instrument names always have a time position of zero, so the playhead is moved to the start of the first measure in the system that the instrument name belongs to.
2020-04-14 05:15:05 -07:00
anatoly-os
b2640e0ab6
Merge pull request #5788 from agusterol/master
fix #153656: Added advanced preference key io/midi/pedalEventsMinTicks for tweaking the amount of ticks between a pedal off event and a pedal on event
2020-04-14 14:13:13 +03:00
Howard-C
9e4e4ac8d2 Make the improvements work with tremolos with non-default beam style 2020-04-14 19:07:35 +08:00
Joachim Schmitz
fd24a190c3 assert 2020-04-14 12:51:33 +02:00
Joachim Schmitz
58c12c8623 fix #303611: Adding fixed spacer can clash with vertical frame below, causing a crash. 2020-04-14 12:51:33 +02:00
Howard-C
dc08f911ce Address review 2020-04-14 18:11:17 +08:00
Howard-C
0769d8932b Update vtests
+ fix one bug regarding `_spatium` not considerated
2020-04-14 18:11:17 +08:00
Howard-C
0162361c1e Turn QPair to std::pair 2020-04-14 18:11:16 +08:00
Howard-C
b817afe89f Make the tremolo strokes less steep in any case except crossStaffBeamBetween() (+ collect_artifacts)
The case of two chords having the same `up()` value is already taken care of in the usage of `extendedStemLenWithTwoNoteTremolo()`.
2020-04-14 18:11:15 +08:00
Howard-C
8e5b82db33 Move extendedStemLenWithTwoNoteTremolo() to layout.cpp to avoid calling it in a Chord member function
+ provide a commented-out part of adjusting stem lengths for cross-staff two-note tremolos that currently isn't working in some cases
2020-04-14 18:11:06 +08:00
Howard-C
bcad104d73 Improve layout of two-note tremolos of chords without stem 2020-04-14 18:04:00 +08:00
Howard-C
7450cbff16 Improve layout related to two-note tremolos 2020-04-14 18:03:59 +08:00
Howard-C
43ab590066 Improve layout related to single-note tremolos
fix #20390: tremolo through stem collide with ledger lines
2020-04-14 18:03:58 +08:00
anatoly-os
db7c5560ce
Merge pull request #5612 from Howard-C/minim-tremolo
Support "all lines attached to stem" beam style of tremolo (partially fix #18897)
2020-04-14 12:45:06 +03:00
Howard-C
70e41448a9 Address review 2020-04-14 16:54:21 +08:00
Howard-C
10ccdaa9ce Fix not able to change layout of dotted minim tremolos 2020-04-14 16:54:21 +08:00
Howard-C
d3f9f6baa9 Restrict "all lines attached to stem" tremolo beam style to non-tab staves 2020-04-14 16:54:20 +08:00
Howard-C
9cde80bd56 Initial implementation of "all lines attached to stem" beam style of tremolo 2020-04-14 16:54:19 +08:00
anatoly-os
8659ae072e
Merge pull request #5456 from Howard-C/backup-import
[Backup File] fix #295701: able to open backup files as an import
2020-04-14 11:02:24 +03:00
AntonioBL
78d9a2978c fix #285434 : Certain 2.x frame texts imported with no style 2020-04-13 22:57:19 +02:00
Joachim Schmitz
f8a0429c50 fix #303712: Crash when extending note into "let ring" and "Palm Mute" 2020-04-12 14:36:37 +02:00
AntonioBL
bda740ff66 fix #294298 : Diagonal line: End hook can disappear or elongate when Begin hook is set to None 2020-04-09 16:59:54 +02:00
anatoly-os
96c03195e3
Merge pull request #5745 from dmitrio95/layout-opt
Layout optimizations
2020-04-09 17:39:23 +03:00
anatoly-os
409aa87dad
Merge pull request #5893 from Jojo-Schmitz/stemles-crash
fix #303189: Staff/Part properties > Advanced Style Properties > Stemless crashes MuseScore
2020-04-09 17:37:29 +03:00
anatoly-os
13a302f1af
Merge pull request #5877 from igorkorsukov/pvs_fixes_step6
Fixed some issues from PVS-Studio report (step6)
2020-04-09 13:15:02 +03:00
Howard-C
ea3e44f6f6 fix #295701: able to open backup files as an import
Resolves: https://musescore.org/node/295701.

A few improvements are made along the way to make sure the backup file ".name.mscz,/mscx," is saved (saved as/saved as copy) correctly as "name.mscz/mscx".
2020-04-09 10:06:27 +08:00
anatoly-os
8537770c35
Merge pull request #5380 from Howard-C/backup-folder
[Backup File] fix #125656: put the backup file in a separate folder
2020-04-07 14:50:24 +02:00
anatoly-os
38f73a7c59
Merge pull request #5851 from mattmcclinch/302603-turned-accidentals
fix #302603: Changing "Direction" has no effect on bowing symbols
2020-04-07 14:28:57 +02:00
anatoly-os
c43b54c184
Merge pull request #5852 from Jojo-Schmitz/texts
fix #302711: chord symbol playback channel in Mixer is shown as "harmony"
2020-04-07 14:14:49 +02:00
Joachim Schmitz
152796e1d7 closing file once no longer needed 2020-04-07 11:54:40 +02:00
anatoly-os
c13dba11c4
Merge pull request #5879 from igorkorsukov/sentry/N4K_text_endedit
Try fix crash on TextBase::endEdit (from CrashReporter)
2020-04-07 10:47:30 +02:00
anatoly-os
7710ce7510
Merge pull request #5818 from emfomy/patch-1
Fix #302281: Wrong default beaming of 32nd notes in 9/8 and 12/8
2020-04-07 10:11:13 +02:00
anatoly-os
dc654503fa
Merge pull request #5878 from igorkorsukov/tracker_299788_localtimesig
fix #299788 Crash when deleting a local Time Signature (removed assert)
2020-04-07 09:52:38 +02:00
anatoly-os
9916086f6b
Merge pull request #5874 from igorkorsukov/tracker_292631_glissandos
fix #292631 fixed crash on spanners (glissandos) layout
2020-04-07 09:50:53 +02:00
anatoly-os
d57183493e
Merge pull request #5866 from igorkorsukov/sentry_corrupt_editdata
fixed collision between drag and cmds next*, prev*
2020-04-07 09:50:07 +02:00
Igor Korsukov
4a41f16082 fixed crash on text endedit 2020-04-07 09:36:50 +02:00