Commit graph

356 commits

Author SHA1 Message Date
Eism 43ffd030f8 fixed #13364: Fixed crash when ending the drag copy
On some platforms, canceling a drag removes the drag object. For example see QXcbDrag::cancel()
2022-12-08 14:07:49 +02:00
Eism 001cdb13be reverted #8174: lasso list selection
Element-by-element selection operations (Ctrl+click and Ctrl+drag) don't work very well. Let's reduce their number.
2022-12-07 15:26:51 +02:00
pereverzev+v 4a878c4d60
Merge pull request #14601 from cbjeukendrup/mscore_errors
Add missing error dialogs that should be the result of MScore errors
2022-12-02 18:37:15 +02:00
Casper Jeukendrup b89f0f26b6
Move the MScoreErrorToString method out of the way 2022-12-02 15:54:58 +01:00
Casper Jeukendrup 4228108cd3
Add missing cases
(now that the commit to remove these errors has been dropped)
2022-12-02 15:38:43 +01:00
Casper Jeukendrup f96d155e8c
Check and show MScore error in various places
Note: this is not complete! This just catches a few cases, but in fact literally every interaction with the libmscore code could cause a mscore error that would require a message box.
2022-12-02 15:38:42 +01:00
Casper Jeukendrup 77a2be3708
Add "Don't show again" checkbox to MScore error dialogs 2022-12-02 15:09:53 +01:00
Casper Jeukendrup fd0270eb58
Add general method for handling errors from Libmscore 2022-12-02 15:09:53 +01:00
dylan.nicholson bd35bc1999 fix #13200 - allow using space to remove hyphen 2022-12-02 12:58:37 +02:00
Casper Jeukendrup 9a3a2c71eb
Play Harmony when finished editing 2022-12-01 12:29:46 +01:00
Casper Jeukendrup 7cd704fc61
End editing Harmony when pressing Enter/Return 2022-12-01 12:29:08 +01:00
Roman Pudashkin 0ccac3742b fix #14769: added missing SelectType::ADD 2022-11-26 09:51:17 +02:00
Roman Pudashkin 50ccc2fdc8 more optimizations 2022-11-24 09:34:48 +02:00
Casper Jeukendrup e720e4749c
Re-add MS3 hack for dragging barlines with Ctrl pressed 2022-11-18 23:03:00 +01:00
Casper Jeukendrup c34b148387
Respect shift/ctrl modifiers when dragging grip (rather than whole element) 2022-11-18 22:40:43 +01:00
Marc Sabatella 5b86e0e759
Fix go to location for pages & individual elements 2022-11-11 17:00:37 -07:00
Michele Spagnolo 07943c09d0 Ensure list selection results in the same endSegment as range selection 2022-11-09 08:41:25 +00:00
Aaron Sattely 0b2d52a06e Allow dotted durations to be added via note input mode 2022-10-25 12:49:32 -04:00
Casper Jeukendrup 0d51cc0c5b
Fix crash when pressing 'repeat selection' shortcut for non-ChordRest selection 2022-10-10 01:50:43 +02:00
Roman Pudashkin a5586a647a fix #12598: when we call endEditText, we cannot change any properties of the previously edited text, because it may be marked as "deleted" (see TextBase::endEdit and TextEditData::~TextEditData) and cannot be added to UndoStack 2022-09-23 19:02:47 +03:00
RomanPudashkin 7d7c7c0ecd
Merge pull request #13287 from wizofaus/prevent-empty-error-message
fix #13286 - ensure no empty error message shown when adding text and nothing selected
2022-09-23 12:19:28 +03:00
Casper Jeukendrup 0b6375a034
Merge pull request #13406 from HemantAntony/13342-multiple_stacked_tempo_warning
Fix #13342: Multiple tempo markings get added
2022-09-19 20:03:15 +02:00
Hemant Antony fdd516d402 Fix #13342: Multiple tempo markings get added 2022-09-18 12:48:50 +05:30
Casper Jeukendrup 438bc3a987
Merge pull request #12306 from mike-spa/multipleGlissandi
Allow adding glissando to all notes when range selected
2022-09-17 20:54:30 +02:00
dylan.nicholson daf26a0bff fix #13286 - ensure no empty error message shown when adding text and
nothing selected
2022-09-13 12:23:00 +10:00
Elnur Ismailzada 78f35b8d9a
Merge pull request #13136 from RomanPudashkin/start_edit_element_fix
[MU4] When line (hairpin, slur etc.) is located within a range selection, after single selection the grips are disappear
2022-09-06 10:05:30 +02:00
Roman Pudashkin f86ff31367 code clean-up 2022-09-02 16:40:12 +03:00
Elnur Ismailzada 15c0b1e616
Merge pull request #13103 from RomanPudashkin/multiple_clicks_in_text_fields
[MU4] Fix #10242: double and triple-click in text fields do not highlight the word or paragraph
2022-09-02 10:19:26 +02:00
Elnur Ismailzada f521b5720c
Merge pull request #13116 from RomanPudashkin/show_options_fix
[MU4] Fix #12777: View - Show checkmarks are wrong in Parts tabs
2022-09-02 10:17:07 +02:00
Michele Spagnolo 854efa9163 TextLines list-selection fix 2022-09-01 17:50:30 +02:00
Roman Pudashkin d5a47c0b95 optimization 2022-09-01 13:38:08 +03:00
Roman Pudashkin ea805692b6 fix #10242: fixed the ability to select a word/all text after double/triple clicking on it 2022-08-31 17:31:04 +03:00
Casper Jeukendrup bf75128e43
Allow creating layout break under more circumstances 2022-08-28 04:26:12 +02:00
RomanPudashkin ae653bb9ab
Merge pull request #13018 from RomanPudashkin/drag_copy_objects
[MU4] Fix #8512: CTRL+SHIFT+drag to duplicate elements not working
2022-08-26 10:46:39 +03:00
Roman Pudashkin 68cffb5478 ported from MU3 the ability to copy elements by dragging them 2022-08-25 23:05:37 +03:00
RomanPudashkin 0ebb3edfc7
Merge pull request #12931 from asattely/dots-in-tuplets
Fix #12546: Correct ratios for tuplets
2022-08-25 17:07:53 +03:00
RomanPudashkin 2ac1fde87d
Merge pull request #12892 from cbjeukendrup/fix_includes_engraving
[cleanup] Fix #includes in Engraving module
2022-08-23 21:05:58 +03:00
Aaron Sattely f29dd79713 Only automatically determine ratio denom when custom tuplet isnt entered 2022-08-23 11:53:21 -04:00
Aaron Sattely 069e861258 Prevent dotted durations in tuplets by correctly setting tuplet ratio 2022-08-23 11:53:20 -04:00
RomanPudashkin bf55378310
Merge pull request #12910 from RomanPudashkin/drag_images_fix
[MU4] Fix #12587: Images cannot be moved via drag or keyboard
2022-08-23 13:29:40 +03:00
Roman Pudashkin bfc8ebcfef fixed regression #10525: start editing the default grip point immediately after pressing the arrows (as it was in MU3) 2022-08-22 18:37:00 +03:00
Roman Pudashkin c0604bbf2c reset the current grip point if the user clicks on the edited element 2022-08-22 12:08:40 +03:00
Roman Pudashkin 133b2c9254 do not show grip points when dragging an element 2022-08-22 12:08:40 +03:00
Roman Pudashkin 8d864e3b2a fix #12587: will only start editing grip points in the following scenarios:
1. the user explicitly clicks on one of the points 
2. the user selects an element using navigation 
3. after selecting an element, the user activates one of the points using the shortcuts
2022-08-22 12:08:40 +03:00
Casper Jeukendrup 3f07eb32b6
Fix #includes - notation (where necessary) 2022-08-19 01:14:41 +02:00
Roman Pudashkin 8a467cb226 implemented the Add menu for the HBOX elements 2022-08-16 13:54:03 +03:00
Elnur Ismailzada c9f4ea3472
Merge pull request #12824 from RomanPudashkin/note_input_position
[MU4] Fix #11494: Note input can start at location not on screen
2022-08-15 11:16:11 +03:00
Roman Pudashkin 698a6ca168 fix #11494: ported missing functionality from MU3 2022-08-13 13:34:43 +03:00
Eism 7986c6e01a fixed #11214: Update ui context after ending text editing 2022-08-08 14:28:31 +03:00
Casper Jeukendrup bd6b4d0c44
Fix crash when applying TextBase-derived element to empty segment 2022-08-02 01:16:39 +02:00