LoweBowe/MuseScore
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
MuseScore/mtest/guitarpro
History
Maurizio M. Gavioli 93e31dc04c Fix #18869 : restore original clef on ChangeStaffType undo 
When a staff type change is undone, the previous staff clef is not restored, if it has been changed to suit the new staff type.

Fixed by storing the original initial clef and restoring it on undo. Should fix the following issues: #18869, #23374, #24294 and, possibly others too.

- Added to ChangeStaffType class an initialClef member variable to hold the original staff initial clef type list.
- ChangeStaffType::flip() split into undo() and redo(), as the managing the clef and setting the staff type must be applied in reversed order in the two cases.
- Clef::layout() now hides a clef not compatible with the staff group, if the clef is not generated or changes it to the same clef as the staff initial clef if generated
- TAB ad-hoc code in Clef::layout() to check for compatibility between the clef type and the staff group generalized to all groups removed.
- Fixed GuitarPro test reference scores, which all contained wrong clefs for the TAB staves.

Tested with a few 2.0 and 1.3 scores; more tests are probably necessary.
2014-05-27 01:47:30 +02:00
..
arpeggio_up_down.gp4 fix #22164: Guitar pro arpeggios import feature 2014-03-15 18:37:10 +05:00
arpeggio_up_down.gp4-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
basic-bend.gp5 Tests for bends 2014-05-20 14:03:57 +01:00
basic-bend.gp5-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
bend.gp3 Tests for bends 2014-05-20 14:03:57 +01:00
bend.gp3-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
bend.gp4 Tests for bends 2014-05-20 14:03:57 +01:00
bend.gp4-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
bend.gp5 Tests for bends 2014-05-20 14:03:57 +01:00
bend.gp5-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
CMakeLists.txt add guitar pro test 2013-08-01 08:17:21 +02:00
copyright.gp3 Added tests for importing copyright statements 2014-04-29 10:48:12 +01:00
copyright.gp3-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
copyright.gp4 Added tests for importing copyright statements 2014-04-29 10:48:12 +01:00
copyright.gp4-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
copyright.gp5 Added tests for importing copyright statements 2014-04-29 10:48:12 +01:00
copyright.gp5-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
dynamic.gp5 fix #23056: Dynamics can be imported 2014-03-15 18:37:10 +05:00
dynamic.gp5-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
ghost_note.gp3 fix #23177: Importing ghost notes & test update 2014-03-15 18:37:10 +05:00
ghost_note.gp3-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
grace.gp5 fix #21734: Import grace notes in gtp3-5 2014-03-25 19:30:24 +05:00
grace.gp5-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
heavy-accent.gp5 Added support for heavily accented notes in the GP5 format. 2014-03-12 17:36:12 +00:00
heavy-accent.gp5-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
sforzato.gp4 Fix #23059: Accented notes in guitar pro files now displayed. 2014-03-12 17:34:53 +00:00
sforzato.gp4-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
slur.gp4 fix #22128: slurs in guitar pro 2013-10-15 12:22:11 +02:00
slur.gp4-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
tempo.gp3 Fix #21732- Support for changing tempo in GP4 and GP5 files 2014-04-29 16:01:38 +01:00
tempo.gp3-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
tempo.gp4 Fix #21732- Support for changing tempo in GP4 and GP5 files 2014-04-29 16:01:38 +01:00
tempo.gp4-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
tempo.gp5 Fix #21732- Support for changing tempo in GP4 and GP5 files 2014-04-29 16:01:38 +01:00
tempo.gp5-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
testIrrTuplet.gp4 add guitar pro test 2013-08-01 08:17:21 +02:00
testIrrTuplet.gp4-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
tremolos.gp5 Fix #23055: Support for tremolos in GP4 and GP5 file formats. 2014-03-12 17:36:43 +00:00
tremolos.gp5-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
trill.gp4 Trills in GP4 and GP5 files are now displayed. 2014-03-12 17:37:14 +00:00
trill.gp4-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
tst_guitarpro.cpp Tests for bends 2014-05-20 14:03:57 +01:00
updateReference Tests for bends 2014-05-20 14:03:57 +01:00
volta.gp3 fix #22898 - tests to verify voltas are being imported correctly in Guitar Pro files 2014-04-27 15:26:04 +01:00
volta.gp3-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
volta.gp4 fix #22898 - tests to verify voltas are being imported correctly in Guitar Pro files 2014-04-27 15:26:04 +01:00
volta.gp4-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00
volta.gp5 Support for voltas in GP5 files 2014-04-19 14:13:54 +01:00
volta.gp5-ref.mscx Fix #18869 : restore original clef on ChangeStaffType undo 2014-05-27 01:47:30 +02:00