MuseScore/libmscore/tremolobar.cpp
Maurizio M. Gavioli a79abf7445 Fix #35136 : Tremolo bar always on top staff + crash on delete
A) A tremolo bar is always displayed on the top staff, regardless of the staff is it applied to

corrected by adding the ON_STAFF flag to a new `TremoloBar` object

B) Deleting a tremolo bar crashes the programme

corrected by adding the relevant case to the `Segment::remove()` method
2014-10-13 18:06:51 +02:00

152 lines
4.5 KiB
C++

//=============================================================================
// MuseScore
// Music Composition & Notation
//
// Copyright (C) 2010-2011 Werner Schweer
//
// This program is free software; you can redistribute it and/or modify
// it under the terms of the GNU General Public License version 2
// as published by the Free Software Foundation and appearing in
// the file LICENCE.GPL
//=============================================================================
#include "tremolobar.h"
#include "score.h"
#include "undo.h"
#include "staff.h"
#include "chord.h"
#include "note.h"
#include "xml.h"
namespace Ms {
//---------------------------------------------------------
// TremoloBar
//---------------------------------------------------------
TremoloBar::TremoloBar(Score* s)
: Element(s)
{
setFlag(ElementFlag::ON_STAFF, true);
}
//---------------------------------------------------------
// layout
//---------------------------------------------------------
void TremoloBar::layout()
{
qreal _spatium = spatium();
if (staff() && !staff()->isTabStaff()) {
setbbox(QRectF());
if (!parent()) {
noteWidth = -_spatium*2;
notePos = QPointF(0.0, _spatium*3);
}
return;
}
_lw = _spatium * 0.1;
Note* note = 0;
if (note == 0) {
noteWidth = 0.0;
notePos = QPointF();
}
else {
noteWidth = note->width();
notePos = note->pos();
}
// int n = _points.size();
// int pt = 0;
// qreal x = noteWidth * .5;
// qreal y = notePos.y() - _spatium;
// qreal x2, y2;
QRectF bb (0, 0, _spatium, -_spatium * 5);
#if 0
for (int pt = 0; pt < n; ++pt) {
if (pt == (n-1))
break;
x = x2;
y = y2;
}
#endif
bb.adjust(-_lw, -_lw, _lw, _lw);
setbbox(bb);
}
//---------------------------------------------------------
// draw
//---------------------------------------------------------
void TremoloBar::draw(QPainter* painter) const
{
if (staff() && !staff()->isTabStaff())
return;
QPen pen(curColor(), _lw, Qt::SolidLine, Qt::RoundCap, Qt::RoundJoin);
painter->setPen(pen);
painter->setBrush(QBrush(Qt::black));
qreal _spatium = spatium();
const TextStyle* st = &score()->textStyle(TextStyleType::BENCH);
QFont f = st->fontPx(_spatium);
painter->setFont(f);
int n = _points.size();
int previousTime = _points[0].time;
int previousPitch = _points[0].pitch;
/* we place the tremolo bars starting slightly before the
* notehead, and end it slightly after, drawing above the
* note. The values specified in Guitar Pro are very large, too
* large for the scale used in Musescore. We used the
* timeFactor and pitchFactor below to reduce these values down
* consistently to values that make sense to draw with the
* Musescore scale. */
int timeFactor = 10;
int pitchFactor = 25;
for (int pt = 1; pt < n; ++pt) {
painter->drawLine(QLineF(previousTime/timeFactor, -previousPitch/pitchFactor-_spatium*3,
_points[pt].time/timeFactor, -_points[pt].pitch/pitchFactor-_spatium*3));
previousTime = _points[pt].time;
previousPitch = _points[pt].pitch;
}
}
//---------------------------------------------------------
// write
//---------------------------------------------------------
void TremoloBar::write(Xml& xml) const
{
xml.stag("TremoloBar");
foreach(const PitchValue& v, _points) {
xml.tagE(QString("point time=\"%1\" pitch=\"%2\" vibrato=\"%3\"")
.arg(v.time).arg(v.pitch).arg(v.vibrato));
}
xml.etag();
}
//---------------------------------------------------------
// read
//---------------------------------------------------------
void TremoloBar::read(XmlReader& e)
{
while (e.readNextStartElement()) {
if (e.name() == "point") {
PitchValue pv;
pv.time = e.intAttribute("time");
pv.pitch = e.intAttribute("pitch");
pv.vibrato = e.intAttribute("vibrato");
_points.append(pv);
e.readNext();
}
else
e.unknown();
}
}
}