Linearize a nested-error-message-generation (#7040)

Merge pull request #7040 from pradyunsg/cleanup/nicer-error-message-creation
This commit is contained in:
Pradyun Gedam 2019-09-19 20:06:54 +05:30 committed by GitHub
commit 13ab7a2bce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 5 deletions

View File

@ -37,11 +37,19 @@ class SourceDistribution(AbstractDistribution):
def _setup_isolation(self, finder):
def _raise_conflicts(conflicting_with, conflicting_reqs):
raise InstallationError(
"Some build dependencies for %s conflict with %s: %s." % (
self.req, conflicting_with, ', '.join(
'%s is incompatible with %s' % (installed, wanted)
for installed, wanted in sorted(conflicting))))
format_string = (
"Some build dependencies for {requirement} "
"conflict with {conflicting_with}: {description}."
)
error_message = format_string.format(
requirement=self.req,
conflicting_with=conflicting_with,
description=', '.join(
'%s is incompatible with %s' % (installed, wanted)
for installed, wanted in sorted(conflicting)
)
)
raise InstallationError(error_message)
# Isolate in a BuildEnvironment and install the build-time
# requirements.