Merge pull request #9372 from jdufresne/devnull

Prefer subprocess.DEVNULL over open(os.devnull, 'w')
This commit is contained in:
Xavier Fernandez 2021-01-07 11:58:08 +01:00 committed by GitHub
commit 14830ae837
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 9 deletions

View File

@ -22,15 +22,12 @@ def _create_svn_initools_repo(initools_dir):
'http://bitbucket.org/hltbra/pip-initools-dump/raw/8b55c908a320/'
'INITools_modified.dump'
)
devnull = open(os.devnull, 'w')
dump = open(filename)
subprocess.check_call(
['svnadmin', 'load', initools_dir],
stdin=dump,
stdout=devnull,
)
dump.close()
devnull.close()
with open(filename) as dump:
subprocess.check_call(
['svnadmin', 'load', initools_dir],
stdin=dump,
stdout=subprocess.DEVNULL,
)
os.remove(filename)