From 50517b2171d3080f0d32b4a0360f3fadaf8da6e4 Mon Sep 17 00:00:00 2001 From: Jon Dufresne Date: Sat, 26 Dec 2020 07:17:39 -0800 Subject: [PATCH] Prefer subprocess.DEVNULL over open(os.devnull, 'w') Available since Python 3.3. https://docs.python.org/3/library/subprocess.html#subprocess.DEVNULL Use a context manager for the other opened file, dump. --- ...e2240e-e268-4519-bee7-6f79bc4cf489.trivial.rst | 0 tests/lib/local_repos.py | 15 ++++++--------- 2 files changed, 6 insertions(+), 9 deletions(-) create mode 100644 news/30e2240e-e268-4519-bee7-6f79bc4cf489.trivial.rst diff --git a/news/30e2240e-e268-4519-bee7-6f79bc4cf489.trivial.rst b/news/30e2240e-e268-4519-bee7-6f79bc4cf489.trivial.rst new file mode 100644 index 000000000..e69de29bb diff --git a/tests/lib/local_repos.py b/tests/lib/local_repos.py index 222f13220..63ec50ccb 100644 --- a/tests/lib/local_repos.py +++ b/tests/lib/local_repos.py @@ -22,15 +22,12 @@ def _create_svn_initools_repo(initools_dir): 'http://bitbucket.org/hltbra/pip-initools-dump/raw/8b55c908a320/' 'INITools_modified.dump' ) - devnull = open(os.devnull, 'w') - dump = open(filename) - subprocess.check_call( - ['svnadmin', 'load', initools_dir], - stdin=dump, - stdout=devnull, - ) - dump.close() - devnull.close() + with open(filename) as dump: + subprocess.check_call( + ['svnadmin', 'load', initools_dir], + stdin=dump, + stdout=subprocess.DEVNULL, + ) os.remove(filename)