mirror of
https://github.com/pypa/pip
synced 2023-12-13 21:30:23 +01:00
Move compute_best_candidate() to the end of CandidateEvaluator.
This commit is contained in:
parent
6554273fe5
commit
1a8dc9cda1
|
@ -646,24 +646,6 @@ class CandidateEvaluator(object):
|
||||||
project_name=self._project_name,
|
project_name=self._project_name,
|
||||||
)
|
)
|
||||||
|
|
||||||
def compute_best_candidate(
|
|
||||||
self,
|
|
||||||
candidates, # type: List[InstallationCandidate]
|
|
||||||
):
|
|
||||||
# type: (...) -> BestCandidateResult
|
|
||||||
"""
|
|
||||||
Compute and return a `BestCandidateResult` instance.
|
|
||||||
"""
|
|
||||||
applicable_candidates = self.get_applicable_candidates(candidates)
|
|
||||||
|
|
||||||
best_candidate = self.sort_best_candidate(applicable_candidates)
|
|
||||||
|
|
||||||
return BestCandidateResult(
|
|
||||||
candidates,
|
|
||||||
applicable_candidates=applicable_candidates,
|
|
||||||
best_candidate=best_candidate,
|
|
||||||
)
|
|
||||||
|
|
||||||
def _sort_key(self, candidate):
|
def _sort_key(self, candidate):
|
||||||
# type: (InstallationCandidate) -> CandidateSortingKey
|
# type: (InstallationCandidate) -> CandidateSortingKey
|
||||||
"""
|
"""
|
||||||
|
@ -754,6 +736,24 @@ class CandidateEvaluator(object):
|
||||||
|
|
||||||
return best_candidate
|
return best_candidate
|
||||||
|
|
||||||
|
def compute_best_candidate(
|
||||||
|
self,
|
||||||
|
candidates, # type: List[InstallationCandidate]
|
||||||
|
):
|
||||||
|
# type: (...) -> BestCandidateResult
|
||||||
|
"""
|
||||||
|
Compute and return a `BestCandidateResult` instance.
|
||||||
|
"""
|
||||||
|
applicable_candidates = self.get_applicable_candidates(candidates)
|
||||||
|
|
||||||
|
best_candidate = self.sort_best_candidate(applicable_candidates)
|
||||||
|
|
||||||
|
return BestCandidateResult(
|
||||||
|
candidates,
|
||||||
|
applicable_candidates=applicable_candidates,
|
||||||
|
best_candidate=best_candidate,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
class BestCandidateResult(object):
|
class BestCandidateResult(object):
|
||||||
"""A collection of candidates, returned by `PackageFinder.find_best_candidate`.
|
"""A collection of candidates, returned by `PackageFinder.find_best_candidate`.
|
||||||
|
|
Loading…
Reference in a new issue