McSinyx/pip
1
1
Fork 0
mirror of https://github.com/pypa/pip synced 2023-12-13 21:30:23 +01:00
Code Issues Releases Activity

Ignore failing git submodule test for now

Browse source 
Git 2.38.1 patched CVE-2022-39253 by disaling automated fetch against a
file: repository. This breaks git submodule, which is used by a pip
test. Information on how projects relying on automated fetch should
configure git correctly after this change is lacking, so the test is
disabled for now until someone can come up with a better solution.
This commit is contained in:
Tzu-ping Chung 2022-10-28 00:12:03 +08:00
parent 36a9b36523
commit 1e236f4c84
2 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
news/B5BABEE8-4FFA-4D62-87AB-FE7450141ECF.trivial.rst Normal file
View file

@ -0,0 +1,5 @@
Git 2.38.1 patched CVE-2022-39253 by disaling automated fetch against a
``file:`` repository. This breaks git submodule, which is used by a pip test.
Information on how projects relying on automated fetch should configure git
correctly after this change is lacking, so the test is disabled for now until
someone can come up with a better solution.

5
tests/functional/test_install_vcs_git.py
View file

@ -544,6 +544,11 @@ def test_reinstalling_works_with_editable_non_master_branch(
# TODO(pnasrat) fix all helpers to do right things with paths on windows.
@pytest.mark.skipif("sys.platform == 'win32'")
@pytest.mark.xfail(
condition=True,
reason="Git submodule against file: is not working; waiting for a good solution",
run=True,
)
def test_check_submodule_addition(script: PipTestEnvironment) -> None:
"""
Submodules are pulled in on install and updated on upgrade.