Error handling upon `uninstall` invalid parameter (#10171)

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
This commit is contained in:
Guy Tuval 2021-07-24 16:24:30 +03:00 committed by GitHub
parent 5e86264b5a
commit 239a307372
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 23 additions and 0 deletions

1
news/4958.feature.rst Normal file
View File

@ -0,0 +1 @@
Add a warning when passing an invalid requirement to ``pip uninstall``.

View File

@ -1,3 +1,4 @@
import logging
from optparse import Values
from typing import List
@ -14,6 +15,8 @@ from pip._internal.req.constructors import (
)
from pip._internal.utils.misc import protect_pip_from_modification_on_windows
logger = logging.getLogger(__name__)
class UninstallCommand(Command, SessionCommandMixin):
"""
@ -58,6 +61,13 @@ class UninstallCommand(Command, SessionCommandMixin):
)
if req.name:
reqs_to_uninstall[canonicalize_name(req.name)] = req
else:
logger.warning(
"Invalid requirement: %r ignored -"
" the uninstall command expects named"
" requirements.",
name,
)
for filename in options.requirements:
for parsed_req in parse_requirements(
filename,

View File

@ -76,6 +76,18 @@ def test_basic_uninstall_with_scripts(script):
)
@pytest.mark.parametrize("name",
["GTrolls.tar.gz",
"https://guyto.com/archives/"])
def test_uninstall_invalid_parameter(script, caplog, name):
result = script.pip("uninstall", name, "-y", expect_error=True)
expected_message = (
f"Invalid requirement: '{name}' ignored -"
f" the uninstall command expects named requirements."
)
assert expected_message in result.stderr
@pytest.mark.network
def test_uninstall_easy_install_after_import(script):
"""