McSinyx/pip
1
1
Fork 0
mirror of https://github.com/pypa/pip synced 2023-12-13 21:30:23 +01:00
Code Issues Releases Activity

models/link: make egg fragment evaluation eager

Browse source 
This should prevent us from accepting malformed egg fragments
that are shadowed by other parts of the requirement specifier.

Signed-off-by: William Woodruff <william@trailofbits.com>
This commit is contained in:
William Woodruff 2022-11-22 17:26:40 -05:00
parent e26712616e
commit 3c337a98cc
No known key found for this signature in database
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/pip/_internal/models/link.py
View file

@ -171,6 +171,7 @@ class Link(KeyBasedCompareMixin):
"dist_info_metadata",
"link_hash",
"cache_link_parsing",
"egg_fragment",
]
def __init__(
@ -234,6 +235,7 @@ class Link(KeyBasedCompareMixin):
super().__init__(key=url, defining_class=Link)
self.cache_link_parsing = cache_link_parsing
self.egg_fragment = self._egg_fragment()
@classmethod
def from_json(
@ -365,8 +367,7 @@ class Link(KeyBasedCompareMixin):
_fragment_parser = stringStart + NAME + Maybe(EXTRAS) + stringEnd
@property
def egg_fragment(self) -> Optional[str]:
def _egg_fragment(self) -> Optional[str]:
match = self._egg_fragment_re.search(self._url)
if not match:
return None