McSinyx
/
pip
mirror of https://github.com/pypa/pip
1
1
Fork 0
Code Issues Releases Activity

Patch __init__.py instead of __main__.py 

The standalone pip doesn't have a correct sys.path when __main__.py
is invoked, and we'd be patching the wrong certifi at that point.
The sys.path is guaranteed to be correct when __init__.py is loaded
(otherwise we wouldn't be able to import it in the first place).
This commit is contained in:
Tzu-ping Chung 2021-03-06 17:35:34 +08:00
parent 0d183d3ee3
commit 40d0529ee3
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/pip/_internal/build_env.py
View File

@ -47,8 +47,8 @@ certifi.where = lambda: {pem!r}
"""
def _format_main_py(source: pathlib.Path) -> bytes:
"""Create a patched pip/__main__.py for the standalone pip.
def _format_init_py(source: pathlib.Path) -> bytes:
"""Create a patched pip/__init__.py for the standalone pip.
The default ``certifi.where()`` relies on the certificate bundle being a
real physical file on-disk, so we monkey-patch it to return the one used
@ -76,8 +76,8 @@ def _create_standalone_pip() -> Iterator[str]:
with zipfile.ZipFile(pip_zip, "w") as zf:
for child in source.rglob("*"):
arcname = child.relative_to(source.parent).as_posix()
if arcname == "pip/__main__.py":
zf.writestr(arcname, _format_main_py(child))
if arcname == "pip/__init__.py":
zf.writestr(arcname, _format_init_py(child))
else:
zf.write(child, arcname)
yield os.path.join(pip_zip, "pip")