McSinyx/pip
1
1
Fork 0
mirror of https://github.com/pypa/pip synced 2023-12-13 21:30:23 +01:00
Code Issues Releases Activity

Merge pull request #7532 from uranusjr/pip-upgrade-prompt-message

Browse source 
Use sys.executable to format upgrade message
This commit is contained in:
Pradyun Gedam 2020-01-07 12:34:54 +00:00 committed by GitHub
parent ea27521359 6c2ffcd0ce
commit 52309f98d1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
news/7376.feature Normal file
View file

@ -0,0 +1,2 @@
Suggest a more robust command to upgrade pip itself to avoid confusion when the
current pip command is not available as ``pip``.

12
src/pip/_internal/self_outdated_check.py
View file

@ -18,7 +18,6 @@ from pip._internal.index.collector import LinkCollector
from pip._internal.index.package_finder import PackageFinder
from pip._internal.models.search_scope import SearchScope
from pip._internal.models.selection_prefs import SelectionPreferences
from pip._internal.utils.compat import WINDOWS
from pip._internal.utils.filesystem import (
adjacent_tmp_file,
check_path_owner,
@ -225,12 +224,11 @@ def pip_self_version_check(session, options):
if not local_version_is_older:
return
# Advise "python -m pip" on Windows to avoid issues
# with overwriting pip.exe.
if WINDOWS:
pip_cmd = "python -m pip"
else:
pip_cmd = "pip"
# We cannot tell how the current pip is available in the current
# command context, so be pragmatic here and suggest the command
# that's always available. This does not accommodate spaces in
# `sys.executable`.
pip_cmd = "{} -m pip".format(sys.executable)
logger.warning(
"You are using pip version %s; however, version %s is "
"available.\nYou should consider upgrading via the "