McSinyx/pip
1
1
Fork 0
mirror of https://github.com/pypa/pip synced 2023-12-13 21:30:23 +01:00
Code Issues Releases Activity

Register req_to_install for cleanup sooner (#4201)

Browse source 
If the install is aborted while parsing the dist's metadata (like in the
case of check_dist_requires_python() ), we want to clean req_to_install
This commit is contained in:
Xavier Fernandez 2016-12-23 14:57:09 +01:00 committed by GitHub
parent 8f9a48e806
commit 5e242adee5
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pip/req/req_set.py
View file

@ -659,9 +659,13 @@ class RequirementSet(object):
req_to_install,
)
# register tmp src for cleanup in case something goes wrong
self.reqs_to_cleanup.append(req_to_install)
# ###################### #
# # parse dependencies # #
# ###################### #
dist = abstract_dist.dist(finder)
try:
check_dist_requires_python(dist)
@ -669,7 +673,6 @@ class RequirementSet(object):
if self.ignore_requires_python:
logger.warning(e.args[0])
else:
req_to_install.remove_temporary_source()
raise
more_reqs = []
@ -711,9 +714,6 @@ class RequirementSet(object):
for subreq in dist.requires(available_requested):
add_req(subreq, extras_requested=available_requested)
# cleanup tmp src
self.reqs_to_cleanup.append(req_to_install)
if not req_to_install.editable and not req_to_install.satisfied_by:
# XXX: --no-install leads this to report 'Successfully
# downloaded' for only non-editable reqs, even though we took