McSinyx/pip
1
1
Fork 0
mirror of https://github.com/pypa/pip synced 2023-12-13 21:30:23 +01:00
Code Issues Releases Activity

Improve code flow of _generate_metadata_legacy

Browse source 
Because it was a little difficult to follow.
Because the comments weren't helpful unless you've built enough context.
This commit is contained in:
Pradyun Gedam 2019-09-21 11:30:49 +05:30
parent 8a144447d7
commit 7ad5670c4e
No known key found for this signature in database
GPG key ID: DA17C4B29CB32E4B
1 changed files with 19 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
src/pip/_internal/operations/generate_metadata.py
View file

@ -25,35 +25,34 @@ def get_metadata_generator(install_req):
def _generate_metadata_legacy(install_req):
# type: (InstallRequirement) -> None
if install_req.name:
logger.debug(
'Running setup.py (path:%s) egg_info for package %s',
install_req.setup_py_path, install_req.name,
)
else:
logger.debug(
'Running setup.py (path:%s) egg_info for package from %s',
install_req.setup_py_path, install_req.link,
)
req_details_str = install_req.name or "from {}".format(install_req.link)
logger.debug(
'Running setup.py (path:%s) egg_info for package %s',
install_req.setup_py_path, req_details_str,
)
# Compose arguments for subprocess call
base_cmd = make_setuptools_shim_args(install_req.setup_py_path)
if install_req.isolated:
base_cmd += ["--no-user-cfg"]
egg_info_cmd = base_cmd + ['egg_info']
# We can't put the .egg-info files at the root, because then the
# source code will be mistaken for an installed egg, causing
# problems
if install_req.editable:
egg_base_option = [] # type: List[str]
else:
# For non-editable installed, don't put the .egg-info files at the root,
# to avoid confusion due to the source code being considered an installed
# egg.
egg_base_option = [] # type: List[str]
if not install_req.editable:
egg_info_dir = os.path.join(install_req.setup_py_dir, 'pip-egg-info')
egg_base_option = ['--egg-base', egg_info_dir]
# setuptools complains if the target directory does not exist.
ensure_dir(egg_info_dir)
egg_base_option = ['--egg-base', 'pip-egg-info']
with install_req.build_env:
call_subprocess(
egg_info_cmd + egg_base_option,
base_cmd + ["egg_info"] + egg_base_option,
cwd=install_req.setup_py_dir,
command_desc='python setup.py egg_info')
command_desc='python setup.py egg_info',
)
def _generate_metadata(install_req):