mirror of
https://github.com/pypa/pip
synced 2023-12-13 21:30:23 +01:00
Improve code flow of _generate_metadata_legacy
Because it was a little difficult to follow. Because the comments weren't helpful unless you've built enough context.
This commit is contained in:
parent
8a144447d7
commit
7ad5670c4e
|
@ -25,35 +25,34 @@ def get_metadata_generator(install_req):
|
||||||
|
|
||||||
def _generate_metadata_legacy(install_req):
|
def _generate_metadata_legacy(install_req):
|
||||||
# type: (InstallRequirement) -> None
|
# type: (InstallRequirement) -> None
|
||||||
if install_req.name:
|
req_details_str = install_req.name or "from {}".format(install_req.link)
|
||||||
logger.debug(
|
logger.debug(
|
||||||
'Running setup.py (path:%s) egg_info for package %s',
|
'Running setup.py (path:%s) egg_info for package %s',
|
||||||
install_req.setup_py_path, install_req.name,
|
install_req.setup_py_path, req_details_str,
|
||||||
)
|
)
|
||||||
else:
|
|
||||||
logger.debug(
|
|
||||||
'Running setup.py (path:%s) egg_info for package from %s',
|
|
||||||
install_req.setup_py_path, install_req.link,
|
|
||||||
)
|
|
||||||
|
|
||||||
|
# Compose arguments for subprocess call
|
||||||
base_cmd = make_setuptools_shim_args(install_req.setup_py_path)
|
base_cmd = make_setuptools_shim_args(install_req.setup_py_path)
|
||||||
if install_req.isolated:
|
if install_req.isolated:
|
||||||
base_cmd += ["--no-user-cfg"]
|
base_cmd += ["--no-user-cfg"]
|
||||||
egg_info_cmd = base_cmd + ['egg_info']
|
|
||||||
# We can't put the .egg-info files at the root, because then the
|
# For non-editable installed, don't put the .egg-info files at the root,
|
||||||
# source code will be mistaken for an installed egg, causing
|
# to avoid confusion due to the source code being considered an installed
|
||||||
# problems
|
# egg.
|
||||||
if install_req.editable:
|
egg_base_option = [] # type: List[str]
|
||||||
egg_base_option = [] # type: List[str]
|
if not install_req.editable:
|
||||||
else:
|
|
||||||
egg_info_dir = os.path.join(install_req.setup_py_dir, 'pip-egg-info')
|
egg_info_dir = os.path.join(install_req.setup_py_dir, 'pip-egg-info')
|
||||||
|
egg_base_option = ['--egg-base', egg_info_dir]
|
||||||
|
|
||||||
|
# setuptools complains if the target directory does not exist.
|
||||||
ensure_dir(egg_info_dir)
|
ensure_dir(egg_info_dir)
|
||||||
egg_base_option = ['--egg-base', 'pip-egg-info']
|
|
||||||
with install_req.build_env:
|
with install_req.build_env:
|
||||||
call_subprocess(
|
call_subprocess(
|
||||||
egg_info_cmd + egg_base_option,
|
base_cmd + ["egg_info"] + egg_base_option,
|
||||||
cwd=install_req.setup_py_dir,
|
cwd=install_req.setup_py_dir,
|
||||||
command_desc='python setup.py egg_info')
|
command_desc='python setup.py egg_info',
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
def _generate_metadata(install_req):
|
def _generate_metadata(install_req):
|
||||||
|
|
Loading…
Reference in a new issue