1
1
Fork 0
mirror of https://github.com/pypa/pip synced 2023-12-13 21:30:23 +01:00

Cleanup existing PEP 518 logic

This commit is contained in:
Pradyun Gedam 2018-07-21 13:09:54 +05:30
parent 9a076e73ab
commit 7fe759bdb1
No known key found for this signature in database
GPG key ID: DA17C4B29CB32E4B

View file

@ -564,35 +564,29 @@ class InstallRequirement(object):
specified as per PEP 518 within the package. If `pyproject.toml` is not
present, returns None to signify not using the same.
"""
# If pyproject.toml does not exist, don't do anything.
if not os.path.isfile(self.pyproject_toml):
return None
error_template = (
"{package} has a pyproject.toml file that does not comply "
"with PEP 518: {reason}"
)
with io.open(self.pyproject_toml, encoding="utf-8") as f:
pp_toml = pytoml.load(f)
# Extract the build requirements
requires = pp_toml.get("build-system", {}).get("requires", None)
if requires is None:
# We isolate on the presence of the pyproject.toml file.
# If build-system.requires is not specified, treat it as if it was
# specified as ["setuptools", "wheel"]
# If there is no build-system table, just use setuptools and wheel.
if "build-system" not in pp_toml:
return ["setuptools", "wheel"]
else:
# Error out if it's not a list of strings
is_list_of_str = isinstance(requires, list) and all(
isinstance(req, six.string_types) for req in requires
)
if not is_list_of_str:
template = (
"{} does not comply with PEP 518 since pyproject.toml "
"does not contain a valid build-system.requires key: {}"
)
raise InstallationError(
template.format(self, "it is not a list of strings.")
)
# If control flow reaches here, we're good to go.
# Error out if it's not a list of strings
requires = build_system.get("requires", [])
if not _is_list_of_str(requires):
raise InstallationError(error_template.format(
self, "'build-system.requires' is not a list of strings."
))
return requires
def run_egg_info(self):
@ -1128,3 +1122,10 @@ def deduce_helpful_msg(req):
else:
msg += " File '%s' does not exist." % (req)
return msg
def _is_list_of_str(obj):
return (
isinstance(obj, list) and
all(isinstance(item, six.string_types) for item in obj)
)