Merge pull request #2311 from dstufft/fix-windows-more

Remove some other places we called os.geteuid()
(cherry picked from commit 40ef6da47a)

CHANGES.txt

@@ -1,5 +1,7 @@
 **6.0.6 (2015-01-03)**
 
+* Continue the regression fix from 6.0.5 which was not a complete fix.
+
 
 **6.0.5 (2015-01-03)**
 

pip/basecommand.py

@@ -119,7 +119,7 @@ class Command(object):
 
         # Ensure that the path for our debug log is owned by the current user
         # and if it is not, disable the debug log.
-        write_debug_log = check_path_owner(debug_log_path, os.geteuid())
+        write_debug_log = check_path_owner(debug_log_path)
 
         logging_dictConfig({
             "version": 1,

pip/download.py

@@ -234,7 +234,7 @@ class SafeFileCache(FileCache):
         # we will check the parent directory until we find one that does exist.
         # If it is not owned by the user executing pip then we will disable
         # the cache and log a warning.
-        if not check_path_owner(self.directory, os.geteuid()):
+        if not check_path_owner(self.directory):
             logger.warning(
                 "The directory '%s' or its parent directory is not owned by "
                 "the current user and the cache has been disabled. Please "

pip/utils/filesystem.py

@@ -4,7 +4,7 @@ import os.path
 from pip.compat import get_path_uid
 
 
-def check_path_owner(path, uid):
+def check_path_owner(path):
     # If we don't have a way to check the effective uid of this process, then
     # we'll just assume that we own the directory.
     if not hasattr(os, "geteuid"):

pip/utils/outdated.py

@@ -60,8 +60,7 @@ class GlobalSelfCheckState(object):
 
     def save(self, pypi_version, current_time):
         # Check to make sure that we own the directory
-        if not check_path_owner(
-                os.path.dirname(self.statefile_path), os.geteuid()):
+        if not check_path_owner(os.path.dirname(self.statefile_path)):
             return
 
         # Now that we've ensured the directory is owned by this user, we'll go

tests/unit/test_unit_outdated.py

@@ -128,7 +128,7 @@ def test_global_state(monkeypatch):
     def fake_lock(filename):
         yield
 
-    monkeypatch.setattr(outdated, "check_path_owner", lambda p, u: True)
+    monkeypatch.setattr(outdated, "check_path_owner", lambda p: True)
 
     monkeypatch.setattr(lockfile, 'LockFile', fake_lock)