1
1
Fork 0
mirror of https://github.com/pypa/pip synced 2023-12-13 21:30:23 +01:00

Add helper to create a DirectUrl from a Link

This commit is contained in:
Stéphane Bidoul 2020-02-01 13:40:11 +01:00
parent 6f689f61db
commit 88582c2564
No known key found for this signature in database
GPG key ID: BCAB2555446B5B92
2 changed files with 154 additions and 0 deletions

View file

@ -4,6 +4,11 @@ from pip._internal.models.direct_url import (
DirInfo,
VcsInfo,
)
from pip._internal.utils.typing import MYPY_CHECK_RUNNING
from pip._internal.vcs import vcs
if MYPY_CHECK_RUNNING:
from pip._internal.models.link import Link
def direct_url_as_pep440_direct_reference(direct_url, name):
@ -32,3 +37,53 @@ def direct_url_as_pep440_direct_reference(direct_url, name):
if fragments:
requirement += "#" + "&".join(fragments)
return requirement
def direct_url_from_link(link, source_dir=None, link_is_in_wheel_cache=False):
# type: (Link, Optional[str], bool) -> DirectUrl
if link.is_vcs:
vcs_backend = vcs.get_backend_for_scheme(link.scheme)
assert vcs_backend
url, requested_revision, _ = (
vcs_backend.get_url_rev_and_auth(link.url_without_fragment)
)
# For VCS links, we need to find out and add commit_id.
if link_is_in_wheel_cache:
# If the requested VCS link corresponds to a cached
# wheel, it means the requested revision was an
# immutable commit hash, otherwise it would not have
# been cached. In that case we don't have a source_dir
# with the VCS checkout.
assert requested_revision
commit_id = requested_revision
else:
# If the wheel was not in cache, it means we have
# had to checkout from VCS to build and we have a source_dir
# which we can inspect to find out the commit id.
assert source_dir
commit_id = vcs_backend.get_revision(source_dir)
return DirectUrl(
url=url,
info=VcsInfo(
vcs=vcs_backend.name,
commit_id=commit_id,
requested_revision=requested_revision,
),
subdirectory=link.subdirectory_fragment,
)
elif link.is_existing_dir():
return DirectUrl(
url=link.url_without_fragment,
info=DirInfo(),
subdirectory=link.subdirectory_fragment,
)
else:
hash = None
hash_name = link.hash_name
if hash_name:
hash = "{}={}".format(hash_name, link.hash)
return DirectUrl(
url=link.url_without_fragment,
info=ArchiveInfo(hash=hash),
subdirectory=link.subdirectory_fragment,
)

View file

@ -1,12 +1,19 @@
from functools import partial
from mock import patch
from pip._internal.models.direct_url import (
ArchiveInfo,
DirectUrl,
DirInfo,
VcsInfo,
)
from pip._internal.models.link import Link
from pip._internal.utils.direct_url_helpers import (
direct_url_as_pep440_direct_reference,
direct_url_from_link,
)
from pip._internal.utils.urls import path_to_url
def test_as_pep440_requirement_archive():
@ -66,3 +73,95 @@ def test_as_pep440_requirement_vcs():
"pkg @ git+https:///g.c/u/p.git"
"@1b8c5bc61a86f377fea47b4276c8c8a5842d2220#subdirectory=subdir"
)
@patch("pip._internal.vcs.git.Git.get_revision")
def test_from_link_vcs(mock_get_backend_for_scheme):
_direct_url_from_link = partial(direct_url_from_link, source_dir="...")
direct_url = _direct_url_from_link(Link("git+https://g.c/u/p.git"))
assert direct_url.url == "https://g.c/u/p.git"
assert isinstance(direct_url.info, VcsInfo)
assert direct_url.info.vcs == "git"
direct_url = _direct_url_from_link(Link("git+https://g.c/u/p.git#egg=pkg"))
assert direct_url.url == "https://g.c/u/p.git"
direct_url = _direct_url_from_link(
Link("git+https://g.c/u/p.git#egg=pkg&subdirectory=subdir")
)
assert direct_url.url == "https://g.c/u/p.git"
assert direct_url.subdirectory == "subdir"
direct_url = _direct_url_from_link(Link("git+https://g.c/u/p.git@branch"))
assert direct_url.url == "https://g.c/u/p.git"
assert direct_url.info.requested_revision == "branch"
direct_url = _direct_url_from_link(
Link("git+https://g.c/u/p.git@branch#egg=pkg")
)
assert direct_url.url == "https://g.c/u/p.git"
assert direct_url.info.requested_revision == "branch"
direct_url = _direct_url_from_link(
Link("git+https://token@g.c/u/p.git")
)
assert direct_url.to_dict()["url"] == "https://g.c/u/p.git"
def test_from_link_vcs_with_source_dir_obtains_commit_id(script, tmpdir):
repo_path = tmpdir / 'test-repo'
repo_path.mkdir()
repo_dir = str(repo_path)
script.run('git', 'init', cwd=repo_dir)
(repo_path / "somefile").touch()
script.run('git', 'add', '.', cwd=repo_dir)
script.run('git', 'commit', '-m', 'commit msg', cwd=repo_dir)
commit_id = script.run(
'git', 'rev-parse', 'HEAD', cwd=repo_dir
).stdout.strip()
direct_url = direct_url_from_link(
Link("git+https://g.c/u/p.git"), source_dir=repo_dir
)
assert direct_url.url == "https://g.c/u/p.git"
assert direct_url.info.commit_id == commit_id
def test_from_link_vcs_without_source_dir(script, tmpdir):
direct_url = direct_url_from_link(
Link("git+https://g.c/u/p.git@1"), link_is_in_wheel_cache=True
)
assert direct_url.url == "https://g.c/u/p.git"
assert direct_url.info.commit_id == "1"
def test_from_link_archive():
direct_url = direct_url_from_link(Link("https://g.c/archive.tgz"))
assert direct_url.url == "https://g.c/archive.tgz"
assert isinstance(direct_url.info, ArchiveInfo)
direct_url = direct_url_from_link(
Link(
"https://g.c/archive.tgz"
"#sha1=1b8c5bc61a86f377fea47b4276c8c8a5842d2220"
)
)
assert isinstance(direct_url.info, ArchiveInfo)
assert (
direct_url.info.hash == "sha1=1b8c5bc61a86f377fea47b4276c8c8a5842d2220"
)
def test_from_link_dir(tmpdir):
dir_url = path_to_url(tmpdir)
direct_url = direct_url_from_link(Link(dir_url))
assert direct_url.url == dir_url
assert isinstance(direct_url.info, DirInfo)
def test_from_link_hide_user_password():
# Basic test only here, other variants are covered by
# direct_url.redact_url tests.
direct_url = direct_url_from_link(
Link("git+https://user:password@g.c/u/p.git@branch#egg=pkg"),
link_is_in_wheel_cache=True,
)
assert direct_url.to_dict()["url"] == "https://g.c/u/p.git"
direct_url = direct_url_from_link(
Link("git+ssh://git@g.c/u/p.git@branch#egg=pkg"),
link_is_in_wheel_cache=True,
)
assert direct_url.to_dict()["url"] == "ssh://git@g.c/u/p.git"