From 894f6558f16ee67a6f171387806a97107fbbca54 Mon Sep 17 00:00:00 2001 From: Tzu-ping Chung Date: Thu, 27 Sep 2018 15:41:02 +0800 Subject: [PATCH] Remove skip_archives argument --- src/pip/_internal/index.py | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/src/pip/_internal/index.py b/src/pip/_internal/index.py index fd6609734..c0091aced 100644 --- a/src/pip/_internal/index.py +++ b/src/pip/_internal/index.py @@ -731,7 +731,7 @@ class HTMLPage(object): return self.url @classmethod - def get_page(cls, link, skip_archives=True, session=None): + def get_page(cls, link, session=None): if session is None: raise TypeError( "get_page() missing 1 required keyword argument: 'session'" @@ -748,22 +748,21 @@ class HTMLPage(object): return None try: - if skip_archives: - filename = link.filename - for bad_ext in ARCHIVE_EXTENSIONS: - if filename.endswith(bad_ext): - content_type = cls._get_content_type( - url, session=session, + filename = link.filename + for bad_ext in ARCHIVE_EXTENSIONS: + if filename.endswith(bad_ext): + content_type = cls._get_content_type( + url, session=session, + ) + if content_type.lower().startswith('text/html'): + break + else: + logger.debug( + 'Skipping page %s because of Content-Type: %s', + link, + content_type, ) - if content_type.lower().startswith('text/html'): - break - else: - logger.debug( - 'Skipping page %s because of Content-Type: %s', - link, - content_type, - ) - return + return logger.debug('Getting page %s', url)