From 8dac3a046b11fa304e65b6ce04a0693ec230133f Mon Sep 17 00:00:00 2001 From: Pradyun Gedam Date: Thu, 19 Sep 2019 15:05:31 +0530 Subject: [PATCH] Move isolation setup code into a helper method --- src/pip/_internal/distributions/source/legacy.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/pip/_internal/distributions/source/legacy.py b/src/pip/_internal/distributions/source/legacy.py index e5d9fd4bf..a29f3d76a 100644 --- a/src/pip/_internal/distributions/source/legacy.py +++ b/src/pip/_internal/distributions/source/legacy.py @@ -29,7 +29,12 @@ class SourceDistribution(AbstractDistribution): self.req.load_pyproject_toml() should_isolate = self.req.use_pep517 and build_isolation + self._setup_isolation(should_isolate, finder) + self.req.prepare_metadata() + self.req.assert_source_matches_version() + + def _setup_isolation(self, should_isolate, finder): def _raise_conflicts(conflicting_with, conflicting_reqs): raise InstallationError( "Some build dependencies for %s conflict with %s: %s." % ( @@ -75,6 +80,3 @@ class SourceDistribution(AbstractDistribution): finder, missing, 'normal', "Installing backend dependencies" ) - - self.req.prepare_metadata() - self.req.assert_source_matches_version()