McSinyx
/
pip
mirror of https://github.com/pypa/pip
1
1
Fork 0
Code Issues Releases Activity

Merge pull request #9408 from jdufresne/setup-no-remote 

Handle ._get_svn_url_rev() returning None in .get_remote_url()
This commit is contained in:
Stéphane Bidoul 2021-01-01 19:32:21 +01:00 committed by GitHub
parent 7369ac2ee8 ca053fbe88
commit a61cb200b5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

0
news/0dd6ac6d-b127-4551-a404-404b0ee8dcd3.trivial.rst Normal file
View File

6
src/pip/_internal/vcs/subversion.py
View File

@ -128,7 +128,11 @@ class Subversion(VersionControl):
)
raise RemoteNotFoundError
return cls._get_svn_url_rev(location)[0]
url, _rev = cls._get_svn_url_rev(location)
if url is None:
raise RemoteNotFoundError
return url
@classmethod
def _get_svn_url_rev(cls, location):

14
tests/functional/test_vcs_subversion.py
View File

@ -15,3 +15,17 @@ def test_get_remote_url__no_remote(script, tmpdir):
with pytest.raises(RemoteNotFoundError):
Subversion().get_remote_url(repo_dir)
@need_svn
def test_get_remote_url__no_remote_with_setup(script, tmpdir):
repo_dir = tmpdir / 'temp-repo'
repo_dir.mkdir()
setup = repo_dir / "setup.py"
setup.touch()
repo_dir = str(repo_dir)
_create_svn_repo(script, repo_dir)
with pytest.raises(RemoteNotFoundError):
Subversion().get_remote_url(repo_dir)