Add a news file

news/5743.feature

@@ -0,0 +1 @@
+Implement PEP 517 (allow projects to specify a build backend via pyproject.toml).

src/pip/_internal/wheel.py

@@ -699,7 +699,7 @@ class WheelBuilder(object):
 
     def _build_one_pep517(self, req, tempd, python_tag=None):
         # TODO: Cannot support python_tag
-        spin_message = 'Running PEP 517 build_wheel for %s' % (req.name,)
+        spin_message = 'Building wheel for %s (PEP 517)' % (req.name,)
         with open_spinner(spin_message) as spinner:
             logger.debug('Destination directory: %s', tempd)
             assert req.metadata_directory is not None
@@ -726,7 +726,7 @@ class WheelBuilder(object):
     def _build_one_legacy(self, req, tempd, python_tag=None):
         base_args = self._base_setup_args(req)
 
-        spin_message = 'Running setup.py bdist_wheel for %s' % (req.name,)
+        spin_message = 'Building wheel for %s (setup.py)' % (req.name,)
         with open_spinner(spin_message) as spinner:
             logger.debug('Destination directory: %s', tempd)
             wheel_args = base_args + ['bdist_wheel', '-d', tempd] \

tests/functional/test_install.py

@@ -1117,7 +1117,6 @@ def test_install_wheel_broken(script, with_wheel):
     assert "Successfully installed wheelbroken-0.1" in str(res), str(res)
 
 
-@pytest.mark.xfail(reason="Test depends on exact output from setuptools")
 def test_cleanup_after_failed_wheel(script, with_wheel):
     res = script.pip_install_local('wheelbrokenafter', expect_stderr=True)
     # One of the effects of not cleaning up is broken scripts:
@@ -1129,7 +1128,6 @@ def test_cleanup_after_failed_wheel(script, with_wheel):
     assert "Running setup.py clean for wheelbrokenafter" in str(res), str(res)
 
 
-@pytest.mark.xfail(reason="Test depends on exact output from setuptools")
 def test_install_builds_wheels(script, data, with_wheel):
     # We need to use a subprocess to get the right value on Windows.
     res = script.run('python', '-c', (
@@ -1152,10 +1150,10 @@ def test_install_builds_wheels(script, data, with_wheel):
     for top, dirs, files in os.walk(wheels_cache):
         wheels.extend(files)
     # and built wheels for upper and wheelbroken
-    assert "Running setup.py bdist_wheel for upper" in str(res), str(res)
-    assert "Running setup.py bdist_wheel for wheelb" in str(res), str(res)
+    assert "Building wheel for upper" in str(res), str(res)
+    assert "Building wheel for wheelb" in str(res), str(res)
     # Wheels are built for local directories, but not cached.
-    assert "Running setup.py bdist_wheel for requir" in str(res), str(res)
+    assert "Building wheel for requir" in str(res), str(res)
     # wheelbroken has to run install
     # into the cache
     assert wheels != [], str(res)
@@ -1171,7 +1169,6 @@ def test_install_builds_wheels(script, data, with_wheel):
     ]
 
 
-@pytest.mark.xfail(reason="Test depends on exact output from setuptools")
 def test_install_no_binary_disables_building_wheels(script, data, with_wheel):
     to_install = data.packages.join('requires_wheelbroken_upper')
     res = script.pip(
@@ -1182,16 +1179,16 @@ def test_install_no_binary_disables_building_wheels(script, data, with_wheel):
     # Must have installed it all
     assert expected in str(res), str(res)
     # and built wheels for wheelbroken only
-    assert "Running setup.py bdist_wheel for wheelb" in str(res), str(res)
+    assert "Building wheel for wheelb" in str(res), str(res)
     # Wheels are built for local directories, but not cached across runs
-    assert "Running setup.py bdist_wheel for requir" in str(res), str(res)
+    assert "Building wheel for requir" in str(res), str(res)
     # Don't build wheel for upper which was blacklisted
-    assert "Running setup.py bdist_wheel for upper" not in str(res), str(res)
+    assert "Building wheel for upper" not in str(res), str(res)
     # Wheels are built for local directories, but not cached across runs
-    assert "Running setup.py install for requir" not in str(res), str(res)
+    assert "Building wheel for requir" not in str(res), str(res)
     # And these two fell back to sdist based installed.
-    assert "Running setup.py install for wheelb" in str(res), str(res)
-    assert "Running setup.py install for upper" in str(res), str(res)
+    assert "Building wheel for wheelb" in str(res), str(res)
+    assert "Building wheel for upper" in str(res), str(res)
 
 
 def test_install_no_binary_disables_cached_wheels(script, data, with_wheel):
@@ -1205,7 +1202,7 @@ def test_install_no_binary_disables_cached_wheels(script, data, with_wheel):
         'upper', expect_stderr=True)
     assert "Successfully installed upper-2.0" in str(res), str(res)
     # No wheel building for upper, which was blacklisted
-    assert "Running setup.py bdist_wheel for upper" not in str(res), str(res)
+    assert "Building wheel for upper" not in str(res), str(res)
     # Must have used source, not a cached wheel to install upper.
     assert "Running setup.py install for upper" in str(res), str(res)
 

tests/functional/test_install_reqs.py

@@ -223,7 +223,6 @@ def test_install_local_with_subdirectory(script):
     result.assert_installed('version_subpkg.py', editable=False)
 
 
-@pytest.mark.xfail(reason="Test depends on exact output from setuptools")
 def test_wheel_user_with_prefix_in_pydistutils_cfg(
         script, data, with_wheel):
     if os.name == 'posix':

tests/functional/test_install_user.py

@@ -75,7 +75,7 @@ class Tests_UserSite:
         dist_info_folder = (
             script.user_site / 'FSPkg-0.1.dev0.dist-info'
         )
-        assert dist_info_folder in result.files_created, result.files_created
+        assert dist_info_folder in result.files_created
 
     @pytest.mark.incompatible_with_test_venv
     def test_install_user_venv_nositepkgs_fails(self, virtualenv,