McSinyx
/
pip
mirror of https://github.com/pypa/pip
1
1
Fork 0
Code Issues Releases Activity

remove support for setup.cfg only projects 

Per the discussion in #9945.

Signed-off-by: Filipe Laíns <lains@riseup.net>
This commit is contained in:
Filipe Laíns 2021-05-29 16:11:31 +01:00 committed by Stéphane Bidoul
parent 363e90b62c
commit c141edc5c9
No known key found for this signature in database
GPG Key ID: BCAB2555446B5B92
2 changed files with 3 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
news/10031.bugfix.rst Normal file
View File

@ -0,0 +1 @@
Require ``setup.cfg``-only projects to be built via PEP 517, by requiring an explicit dependency on setuptools declared in pyproject.toml.

18
src/pip/_internal/req/req_install.py
View File

@ -509,19 +509,6 @@ class InstallRequirement:
self.unpacked_source_directory, backend, backend_path=backend_path,
)
def _check_setup_py_or_cfg_exists(self) -> bool:
"""Check if the requirement actually has a setuptools build file.
If setup.py does not exist, we also check setup.cfg in the same
directory and allow the directory if that exists.
"""
if os.path.exists(self.setup_py_path):
return True
stem, ext = os.path.splitext(self.setup_py_path)
if ext == ".py" and os.path.exists(f"{stem}.cfg"):
return True
return False
def _generate_metadata(self):
# type: () -> str
"""Invokes metadata generator functions, with the required arguments.
@ -529,10 +516,9 @@ class InstallRequirement:
if not self.use_pep517:
assert self.unpacked_source_directory
if not self._check_setup_py_or_cfg_exists():
if not os.path.exists(self.setup_py_path):
raise InstallationError(
f'File "setup.py" or "setup.cfg" not found for legacy '
f'project {self}.'
f'File "setup.py" not found for legacy project {self}.'
)
return generate_metadata_legacy(