From c33cf49381ff9212bffcaed7517ce38171ad634c Mon Sep 17 00:00:00 2001 From: Xavier Fernandez Date: Fri, 30 Oct 2020 10:06:18 +0100 Subject: [PATCH] freeze: deprecate option --find-links --- news/9069.removal.rst | 1 + src/pip/_internal/commands/freeze.py | 9 +++++++++ tests/functional/test_freeze.py | 3 ++- 3 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 news/9069.removal.rst diff --git a/news/9069.removal.rst b/news/9069.removal.rst new file mode 100644 index 000000000..a7fae08da --- /dev/null +++ b/news/9069.removal.rst @@ -0,0 +1 @@ +Deprecate ``--find-links`` option in ``pip freeze`` diff --git a/src/pip/_internal/commands/freeze.py b/src/pip/_internal/commands/freeze.py index 2071fbabd..20084a498 100644 --- a/src/pip/_internal/commands/freeze.py +++ b/src/pip/_internal/commands/freeze.py @@ -9,6 +9,7 @@ from pip._internal.cli.status_codes import SUCCESS from pip._internal.models.format_control import FormatControl from pip._internal.operations.freeze import freeze from pip._internal.utils.compat import stdlib_pkgs +from pip._internal.utils.deprecation import deprecated from pip._internal.utils.typing import MYPY_CHECK_RUNNING DEV_PKGS = {'pip', 'setuptools', 'distribute', 'wheel'} @@ -86,6 +87,14 @@ class FreezeCommand(Command): cmdoptions.check_list_path_option(options) + if options.find_links: + deprecated( + "--find-links option in pip freeze is deprecated.", + replacement=None, + gone_in="21.2", + issue=9069, + ) + freeze_kwargs = dict( requirement=options.requirements, find_links=options.find_links, diff --git a/tests/functional/test_freeze.py b/tests/functional/test_freeze.py index ef2216986..74d676aed 100644 --- a/tests/functional/test_freeze.py +++ b/tests/functional/test_freeze.py @@ -358,7 +358,8 @@ def test_freeze_mercurial_clone_srcdir(script, tmpdir): _check_output(result.stdout, expected) result = script.pip( - 'freeze', '-f', '{repo_dir}#egg=pip_test_package'.format(**locals()) + 'freeze', '-f', '{repo_dir}#egg=pip_test_package'.format(**locals()), + expect_stderr=True, ) expected = textwrap.dedent( """