From c6bf7acc976cf093c269fcda1b58ee34ad916b8f Mon Sep 17 00:00:00 2001 From: Nitesh Sharma Date: Tue, 28 Aug 2018 22:05:18 +0530 Subject: [PATCH] fix linting errors --- src/pip/_internal/cli/cmdoptions.py | 2 ++ src/pip/_internal/commands/download.py | 2 -- tests/unit/test_format_control.py | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/pip/_internal/cli/cmdoptions.py b/src/pip/_internal/cli/cmdoptions.py index 9fd76bbf2..839b9dd20 100644 --- a/src/pip/_internal/cli/cmdoptions.py +++ b/src/pip/_internal/cli/cmdoptions.py @@ -403,12 +403,14 @@ def handle_cli_no_binary(option, opt_str, value, parser): value, existing.no_binary, existing.only_binary, ) + def handle_cli_only_binary(option, opt_str, value, parser): existing = getattr(parser.values, option.dest) FormatControl.handle_mutual_excludes( value, existing.only_binary, existing.no_binary, ) + def no_binary(): format_control = FormatControl(set(), set()) return Option( diff --git a/src/pip/_internal/commands/download.py b/src/pip/_internal/commands/download.py index 4353cade1..b3f3c6ec7 100644 --- a/src/pip/_internal/commands/download.py +++ b/src/pip/_internal/commands/download.py @@ -5,8 +5,6 @@ import os from pip._internal.cli import cmdoptions from pip._internal.cli.base_command import RequirementCommand -from pip._internal.exceptions import CommandError -from pip._internal.format_control import FormatControl from pip._internal.operations.prepare import RequirementPreparer from pip._internal.req import RequirementSet from pip._internal.req.req_tracker import RequirementTracker diff --git a/tests/unit/test_format_control.py b/tests/unit/test_format_control.py index 0cb517aad..81910cdbb 100644 --- a/tests/unit/test_format_control.py +++ b/tests/unit/test_format_control.py @@ -57,6 +57,7 @@ def test_comma_separated_values(): assert cmd.options.format_control.only_binary == expected.only_binary assert cmd.options.format_control.no_binary == expected.no_binary + def test_fmt_ctl_matches(): fmt = FormatControl(set(), set()) assert fmt.get_allowed_formats("fred") == frozenset(["source", "binary"])