McSinyx/pip
1
1
Fork 0
mirror of https://github.com/pypa/pip synced 2023-12-13 21:30:23 +01:00
Code Issues Releases Activity

Merge pull request #2088 from qwcode/false_positive

Browse source 
fix false positive tests due to assert tuple syntax
This commit is contained in:
Marcus Smith 2014-10-09 17:37:22 -07:00
parent f720d3d706 9d01010672
commit c72668f125
3 changed files with 8 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/functional/test_install_user.py
View file

@ -280,5 +280,5 @@ class Tests_UserSite:
assert ( assert (
"Will not install to the user site because it will lack sys.path " "Will not install to the user site because it will lack sys.path "
"precedence to %s in %s" % "precedence to %s in %s" %
('INITools', dist_location) in result2.stdout, result2.stdout ('INITools', dist_location) in result2.stdout
) ), result2.stdout

4
tests/unit/test_finder.py
View file

@ -163,8 +163,8 @@ class TestWheel:
) )
found = finder.find_requirement(req, True) found = finder.find_requirement(req, True)
assert ( assert (
found.url.endswith("simple.dist-0.1-py2.py3-none-any.whl"), found found.url.endswith("simple.dist-0.1-py2.py3-none-any.whl")
) ), found
def test_wheel_over_sdist_priority(self, data): def test_wheel_over_sdist_priority(self, data):
""" """

11
tests/unit/test_utils.py
View file

@ -294,9 +294,8 @@ def test_find_command_trys_all_pathext(mock_isfile, getpath_mock):
find_command("foo", "path_one") find_command("foo", "path_one")
assert ( assert (
mock_isfile.call_args_list == expected, "Actual: %s\nExpected %s" % mock_isfile.call_args_list == expected
(mock_isfile.call_args_list, expected) ), "Actual: %s\nExpected %s" % (mock_isfile.call_args_list, expected)
)
assert getpath_mock.called, "Should call get_pathext" assert getpath_mock.called, "Should call get_pathext"
@ -320,11 +319,9 @@ def test_find_command_trys_supplied_pathext(mock_isfile, getpath_mock):
with pytest.raises(BadCommand): with pytest.raises(BadCommand):
find_command("foo", "path_one", pathext) find_command("foo", "path_one", pathext)
assert ( assert (
mock_isfile.call_args_list == expected, "Actual: %s\nExpected %s" % mock_isfile.call_args_list == expected
(mock_isfile.call_args_list, expected) ), "Actual: %s\nExpected %s" % (mock_isfile.call_args_list, expected)
)
assert not getpath_mock.called, "Should not call get_pathext" assert not getpath_mock.called, "Should not call get_pathext"