McSinyx
/
pip
mirror of https://github.com/pypa/pip
1
1
Fork 0
Code Issues Releases Activity

Merge pull request #8180 from sbidoul/wheel-absent-warning-sbi

This commit is contained in:
Pradyun Gedam 2020-05-05 16:08:54 +05:30 committed by GitHub
parent cbfbc29b63 55d6022989
commit c74128c424
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
news/8178.bugfix Normal file
View File

@ -0,0 +1,2 @@
Avoid unnecessary message about the wheel package not being installed
when a wheel would not have been built. Additionally, clarify the message.

16
src/pip/_internal/wheel_builder.py
View File

@ -69,14 +69,6 @@ def _should_build(
# From this point, this concerns the pip install command only
# (need_wheel=False).
if not req.use_pep517 and not is_wheel_installed():
# we don't build legacy requirements if wheel is not installed
logger.info(
"Could not build wheels for %s, "
"since package 'wheel' is not installed.", req.name,
)
return False
if req.editable or not req.source_dir:
return False
@ -87,6 +79,14 @@ def _should_build(
)
return False
if not req.use_pep517 and not is_wheel_installed():
# we don't build legacy requirements if wheel is not installed
logger.info(
"Using legacy setup.py install for %s, "
"since package 'wheel' is not installed.", req.name,
)
return False
return True