From c88da892dba52d3f8f90982ea2aea889fcde933d Mon Sep 17 00:00:00 2001 From: Pradyun Gedam Date: Sun, 20 Oct 2019 14:39:01 +0530 Subject: [PATCH] Reduce indentation in warn_on_mismatching_name Why: Makes it easier to read IMO. --- src/pip/_internal/req/req_install.py | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/src/pip/_internal/req/req_install.py b/src/pip/_internal/req/req_install.py index a2a86d4c4..f47bbbf0f 100644 --- a/src/pip/_internal/req/req_install.py +++ b/src/pip/_internal/req/req_install.py @@ -459,14 +459,18 @@ class InstallRequirement(object): def warn_on_mismatching_name(self): metadata_name = canonicalize_name(self.metadata["Name"]) - if canonicalize_name(self.req.name) != metadata_name: - logger.warning( - 'Generating metadata for package %s ' - 'produced metadata for project name %s. Fix your ' - '#egg=%s fragments.', - self.name, metadata_name, self.name - ) - self.req = Requirement(metadata_name) + if canonicalize_name(self.req.name) == metadata_name: + # Everything is fine. + return + + # If we're here, there's a mismatch. Log a warning about it. + logger.warning( + 'Generating metadata for package %s ' + 'produced metadata for project name %s. Fix your ' + '#egg=%s fragments.', + self.name, metadata_name, self.name + ) + self.req = Requirement(metadata_name) def remove_temporary_source(self): # type: () -> None