mirror of
https://github.com/pypa/pip
synced 2023-12-13 21:30:23 +01:00
Convert _build_one from method to function
It does not rely on WheelBuilder anymore.
This commit is contained in:
Stéphane Bidoul (ACSONE)
parent
3828699ddc
commit
c8d4277535
1 changed files with 92 additions and 91 deletions
|
|
@ -160,6 +160,97 @@ def _always_true(_):
|
|||
return True
|
||||
|
||||
|
||||
def _build_one(
|
||||
req, # type: InstallRequirement
|
||||
output_dir, # type: str
|
||||
build_options, # type: List[str]
|
||||
global_options, # type: List[str]
|
||||
):
|
||||
# type: (...) -> Optional[str]
|
||||
"""Build one wheel.
|
||||
|
||||
:return: The filename of the built wheel, or None if the build failed.
|
||||
"""
|
||||
try:
|
||||
ensure_dir(output_dir)
|
||||
except OSError as e:
|
||||
logger.warning(
|
||||
"Building wheel for %s failed: %s",
|
||||
req.name, e,
|
||||
)
|
||||
return None
|
||||
|
||||
# Install build deps into temporary directory (PEP 518)
|
||||
with req.build_env:
|
||||
return _build_one_inside_env(
|
||||
req, output_dir, build_options, global_options
|
||||
)
|
||||
|
||||
|
||||
def _build_one_inside_env(
|
||||
req, # type: InstallRequirement
|
||||
output_dir, # type: str
|
||||
build_options, # type: List[str]
|
||||
global_options, # type: List[str]
|
||||
):
|
||||
# type: (...) -> Optional[str]
|
||||
with TempDirectory(kind="wheel") as temp_dir:
|
||||
if req.use_pep517:
|
||||
wheel_path = build_wheel_pep517(
|
||||
name=req.name,
|
||||
backend=req.pep517_backend,
|
||||
metadata_directory=req.metadata_directory,
|
||||
build_options=build_options,
|
||||
tempd=temp_dir.path,
|
||||
)
|
||||
else:
|
||||
wheel_path = build_wheel_legacy(
|
||||
name=req.name,
|
||||
setup_py_path=req.setup_py_path,
|
||||
source_dir=req.unpacked_source_directory,
|
||||
global_options=global_options,
|
||||
build_options=build_options,
|
||||
tempd=temp_dir.path,
|
||||
)
|
||||
|
||||
if wheel_path is not None:
|
||||
wheel_name = os.path.basename(wheel_path)
|
||||
dest_path = os.path.join(output_dir, wheel_name)
|
||||
try:
|
||||
wheel_hash, length = hash_file(wheel_path)
|
||||
shutil.move(wheel_path, dest_path)
|
||||
logger.info('Created wheel for %s: '
|
||||
'filename=%s size=%d sha256=%s',
|
||||
req.name, wheel_name, length,
|
||||
wheel_hash.hexdigest())
|
||||
logger.info('Stored in directory: %s', output_dir)
|
||||
return dest_path
|
||||
except Exception as e:
|
||||
logger.warning(
|
||||
"Building wheel for %s failed: %s",
|
||||
req.name, e,
|
||||
)
|
||||
# Ignore return, we can't do anything else useful.
|
||||
_clean_one(req, global_options)
|
||||
return None
|
||||
|
||||
|
||||
def _clean_one(req, global_options):
|
||||
# type: (InstallRequirement, List[str]) -> bool
|
||||
clean_args = make_setuptools_clean_args(
|
||||
req.setup_py_path,
|
||||
global_options=global_options,
|
||||
)
|
||||
|
||||
logger.info('Running setup.py clean for %s', req.name)
|
||||
try:
|
||||
call_subprocess(clean_args, cwd=req.source_dir)
|
||||
return True
|
||||
except Exception:
|
||||
logger.error('Failed cleaning build dir for %s', req.name)
|
||||
return False
|
||||
|
||||
|
||||
class WheelBuilder(object):
|
||||
"""Build wheels from a RequirementSet."""
|
||||
|
||||
|
|
@ -172,96 +263,6 @@ class WheelBuilder(object):
|
|||
self.preparer = preparer
|
||||
self.wheel_cache = wheel_cache
|
||||
|
||||
def _build_one(
|
||||
self,
|
||||
req, # type: InstallRequirement
|
||||
output_dir, # type: str
|
||||
build_options, # type: List[str]
|
||||
global_options, # type: List[str]
|
||||
):
|
||||
# type: (...) -> Optional[str]
|
||||
"""Build one wheel.
|
||||
|
||||
:return: The filename of the built wheel, or None if the build failed.
|
||||
"""
|
||||
try:
|
||||
ensure_dir(output_dir)
|
||||
except OSError as e:
|
||||
logger.warning(
|
||||
"Building wheel for %s failed: %s",
|
||||
req.name, e,
|
||||
)
|
||||
return None
|
||||
|
||||
# Install build deps into temporary directory (PEP 518)
|
||||
with req.build_env:
|
||||
return self._build_one_inside_env(
|
||||
req, output_dir, build_options, global_options
|
||||
)
|
||||
|
||||
def _build_one_inside_env(
|
||||
self,
|
||||
req, # type: InstallRequirement
|
||||
output_dir, # type: str
|
||||
build_options, # type: List[str]
|
||||
global_options, # type: List[str]
|
||||
):
|
||||
# type: (...) -> Optional[str]
|
||||
with TempDirectory(kind="wheel") as temp_dir:
|
||||
if req.use_pep517:
|
||||
wheel_path = build_wheel_pep517(
|
||||
name=req.name,
|
||||
backend=req.pep517_backend,
|
||||
metadata_directory=req.metadata_directory,
|
||||
build_options=build_options,
|
||||
tempd=temp_dir.path,
|
||||
)
|
||||
else:
|
||||
wheel_path = build_wheel_legacy(
|
||||
name=req.name,
|
||||
setup_py_path=req.setup_py_path,
|
||||
source_dir=req.unpacked_source_directory,
|
||||
global_options=global_options,
|
||||
build_options=build_options,
|
||||
tempd=temp_dir.path,
|
||||
)
|
||||
|
||||
if wheel_path is not None:
|
||||
wheel_name = os.path.basename(wheel_path)
|
||||
dest_path = os.path.join(output_dir, wheel_name)
|
||||
try:
|
||||
wheel_hash, length = hash_file(wheel_path)
|
||||
shutil.move(wheel_path, dest_path)
|
||||
logger.info('Created wheel for %s: '
|
||||
'filename=%s size=%d sha256=%s',
|
||||
req.name, wheel_name, length,
|
||||
wheel_hash.hexdigest())
|
||||
logger.info('Stored in directory: %s', output_dir)
|
||||
return dest_path
|
||||
except Exception as e:
|
||||
logger.warning(
|
||||
"Building wheel for %s failed: %s",
|
||||
req.name, e,
|
||||
)
|
||||
# Ignore return, we can't do anything else useful.
|
||||
self._clean_one(req, global_options)
|
||||
return None
|
||||
|
||||
def _clean_one(self, req, global_options):
|
||||
# type: (InstallRequirement, List[str]) -> bool
|
||||
clean_args = make_setuptools_clean_args(
|
||||
req.setup_py_path,
|
||||
global_options=global_options,
|
||||
)
|
||||
|
||||
logger.info('Running setup.py clean for %s', req.name)
|
||||
try:
|
||||
call_subprocess(clean_args, cwd=req.source_dir)
|
||||
return True
|
||||
except Exception:
|
||||
logger.error('Failed cleaning build dir for %s', req.name)
|
||||
return False
|
||||
|
||||
def build(
|
||||
self,
|
||||
requirements, # type: Iterable[InstallRequirement]
|
||||
|
|
@ -304,7 +305,7 @@ class WheelBuilder(object):
|
|||
with indent_log():
|
||||
build_successes, build_failures = [], []
|
||||
for req, cache_dir in buildset:
|
||||
wheel_file = self._build_one(
|
||||
wheel_file = _build_one(
|
||||
req, cache_dir, build_options, global_options
|
||||
)
|
||||
if wheel_file:
|
||||
|
|
|
|||
Loading…
Reference in a new issue