Merge pull request #9171 from webknjaz/bugfixes/docs-feedback-sphinxext-orphan

This commit is contained in:
Pradyun Gedam 2020-11-29 19:17:18 +00:00 committed by GitHub
commit d91b7d9e88
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions

View File

@ -111,7 +111,7 @@ def _modify_rst_document_source_on_read(
orphan_mark = ':orphan:'
is_orphan = orphan_mark in source[0]
if is_orphan:
source[0].replace(orphan_mark, '')
source[0] = source[0].replace(orphan_mark, '')
else:
orphan_mark = ''

3
news/9171.trivial.rst Normal file
View File

@ -0,0 +1,3 @@
Fixed moving the ``:orphan:`` to top of documents in the Sphinx
extension for collecting the UX feedback from docs (initially
introduced in PR #8848).