From d9b5a9df85617b891d812ecebda6d2dfd366b03b Mon Sep 17 00:00:00 2001 From: chrysle Date: Mon, 14 Aug 2023 20:00:50 +0200 Subject: [PATCH] Apply suggestions from code review --- src/pip/_internal/configuration.py | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/pip/_internal/configuration.py b/src/pip/_internal/configuration.py index 057aa7358..b2f7db437 100644 --- a/src/pip/_internal/configuration.py +++ b/src/pip/_internal/configuration.py @@ -148,8 +148,7 @@ class Configuration: clean_config = {} for k, value in self._dictionary.items(): if isinstance(value, dict): - for k, v in value.items(): - clean_config[k] = v + clean_config.update(value) else: clean_config[k] = value return clean_config[key] @@ -175,10 +174,7 @@ class Configuration: parser.add_section(section) parser.set(section, name, value) - exists = self._config[self.load_only].get(fname) - if not exists: - self._config[self.load_only][fname] = {} - + self._config[self.load_only].setdefault(fname, {}) self._config[self.load_only][fname][key] = value self._mark_as_modified(fname, parser) @@ -286,9 +282,7 @@ class Configuration: for section in parser.sections(): items = parser.items(section) - exists = self._config[variant].get(fname) - if not exists: - self._config[variant][fname] = {} + self._config[variant].setdefault(fname, {}) self._config[variant][fname].update(self._normalized_keys(section, items)) return parser