1
1
Fork 0
mirror of https://github.com/pypa/pip synced 2023-12-13 21:30:23 +01:00

Remove unnecessary InstallRequirement cleanup in install_given_reqs

install_given_reqs is only called from InstallCommand.run, which calls
RequirementSet.cleanup_files, which calls
InstallRequirement.remove_temporary_source for each InstallRequirement,
so the call here was not necessary.

We have test coverage affirming this still works as expected in
tests/functional/test_install_cleanup.py.
This commit is contained in:
Chris Hunt 2019-12-26 14:46:05 -05:00
parent 0292938f89
commit db42a03ee2

View file

@ -86,7 +86,6 @@ def install_given_reqs(
)
if should_commit:
uninstalled_pathset.commit()
requirement.remove_temporary_source()
installed.append(InstallationResult(requirement.name))