McSinyx
/
pip
mirror of https://github.com/pypa/pip
1
1
Fork 0
Code Issues Releases Activity

Always return SUCCESS from download.run

This commit is contained in:
Devesh Kumar Singh 2020-05-22 19:44:29 +05:30
parent 5e33373a07
commit e8b842389c
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/pip/_internal/commands/download.py
View File

@ -6,7 +6,7 @@ import os
from pip._internal.cli import cmdoptions
from pip._internal.cli.cmdoptions import make_target_python
from pip._internal.cli.req_command import RequirementCommand, with_cleanup
from pip._internal.cli.status_codes import ERROR, SUCCESS
from pip._internal.cli.status_codes import SUCCESS
from pip._internal.req.req_tracker import get_requirement_tracker
from pip._internal.utils.misc import ensure_dir, normalize_path, write_output
from pip._internal.utils.temp_dir import TempDirectory
@ -143,6 +143,5 @@ class DownloadCommand(RequirementCommand):
if req.successfully_downloaded])
if downloaded:
write_output('Successfully downloaded %s', downloaded)
return SUCCESS
return ERROR
return SUCCESS

4
tests/functional/test_download.py
View File

@ -666,9 +666,7 @@ def test_download_exit_status_code_when_blank_requirements_file(script):
Test download exit status code when blank requirements file specified
"""
script.scratch_path.joinpath("blank.txt").write_text("\n")
result = script.pip('download', '-r', 'blank.txt', expect_error=True)
print(result)
assert result.returncode == ERROR
script.pip('download', '-r', 'blank.txt')
def test_download_prefer_binary_when_tarball_higher_than_wheel(script, data):