McSinyx
/
pip
mirror of https://github.com/pypa/pip
1
1
Fork 0
Code Issues Releases Activity

Unify calls to prepare_distribution_metadata to one callsite

This commit is contained in:
Pradyun Gedam 2019-08-04 11:16:16 +05:30
parent 82dbcdae87
commit f18ec526db
No known key found for this signature in database
GPG Key ID: DA17C4B29CB32E4B
1 changed files with 17 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/pip/_internal/operations/prepare.py
View File

@ -42,6 +42,15 @@ if MYPY_CHECK_RUNNING:
logger = logging.getLogger(__name__)
def _get_prepared_distribution(req, req_tracker, finder, build_isolation):
"""Prepare a distribution for installation.
"""
abstract_dist = make_distribution_for_install_requirement(req)
with req_tracker.track(req):
abstract_dist.prepare_distribution_metadata(finder, build_isolation)
return abstract_dist
class RequirementPreparer(object):
"""Prepares a Requirement
"""
@ -207,11 +216,11 @@ class RequirementPreparer(object):
'error %s for URL %s' %
(req, exc, link)
)
abstract_dist = make_distribution_for_install_requirement(req)
with self.req_tracker.track(req):
abstract_dist.prepare_distribution_metadata(
finder, self.build_isolation,
)
abstract_dist = _get_prepared_distribution(
req, self.req_tracker, finder, self.build_isolation,
)
if self._download_should_save:
# Make a .zip of the source_dir we already created.
if not link.is_artifact:
@ -242,11 +251,9 @@ class RequirementPreparer(object):
req.ensure_has_source_dir(self.src_dir)
req.update_editable(not self._download_should_save)
abstract_dist = make_distribution_for_install_requirement(req)
with self.req_tracker.track(req):
abstract_dist.prepare_distribution_metadata(
finder, self.build_isolation,
)
abstract_dist = _get_prepared_distribution(
req, self.req_tracker, finder, self.build_isolation,
)
if self._download_should_save:
req.archive(self.download_dir)