Fallback to self-invoke via directory on 3.6

This fixes a compatibility issue when a PEP 517 build requirement
itself needs to be built in an isolated environment, caused by
importlib.resources not being available.
This commit is contained in:
Tzu-ping Chung 2021-04-27 14:27:42 +08:00
parent 7a77484a49
commit f88420319d
2 changed files with 14 additions and 4 deletions

2
news/9878.bugfix.rst Normal file
View File

@ -0,0 +1,2 @@
Fix Python 3.6 compatibility when a PEP 517 build requirement itself needs to be
built in an isolated environment.

View File

@ -187,9 +187,17 @@ class BuildEnvironment:
prefix.setup = True
if not requirements:
return
with _create_standalone_pip() as standalone_pip:
with contextlib.ExitStack() as ctx:
# TODO: Remove this block when dropping 3.6 support. Python 3.6
# lacks importlib.resources and pep517 has issues loading files in
# a zip, so we fallback to the "old" method by adding the current
# pip directory to the child process's sys.path.
if sys.version_info < (3, 7):
pip_runnable = os.path.dirname(pip_location)
else:
pip_runnable = ctx.enter_context(_create_standalone_pip())
self._install_requirements(
standalone_pip,
pip_runnable,
finder,
requirements,
prefix,
@ -198,14 +206,14 @@ class BuildEnvironment:
@staticmethod
def _install_requirements(
standalone_pip: str,
pip_runnable: str,
finder: "PackageFinder",
requirements: Iterable[str],
prefix: _Prefix,
message: str,
) -> None:
args = [
sys.executable, standalone_pip, 'install',
sys.executable, pip_runnable, 'install',
'--ignore-installed', '--no-user', '--prefix', prefix.path,
'--no-warn-script-location',
] # type: List[str]